halibut/wcwidth.c, branch master My halibut tree Fix two potential buffer under/overruns. 2017-05-14T07:49:07+00:00 Simon Tatham anakin@pobox.com 2017-05-14T07:08:57+00:00 41ef29132b50404f6157d83d1edf9a133e422c9f The one in wcwidth.c actually came up in one of my valgrind runs: if you passed it a non-null-terminated wide string (specifically, one that reaches invalid memory exactly when the length parameter runs out), it would illegally load the character beyond the end of the string before noticing that the length parameter said it shouldn't. The one in bk_man.c may well not be able to come up at all, but I spotted it in passing and I thought I might as well fix it - it makes me twitch on general principles to see any use of buf[len-1] without having checked len>0 first. 
The one in wcwidth.c actually came up in one of my valgrind runs: if
you passed it a non-null-terminated wide string (specifically, one
that reaches invalid memory exactly when the length parameter runs
out), it would illegally load the character beyond the end of the
string before noticing that the length parameter said it shouldn't.

The one in bk_man.c may well not be able to come up at all, but I
spotted it in passing and I thought I might as well fix it - it makes
me twitch on general principles to see any use of buf[len-1] without
having checked len>0 first.
Remove a bunch of unused variables spotted by Ubuntu 12.04's gcc. 2012-05-03T17:43:21+00:00 Simon Tatham anakin@pobox.com 2012-05-03T17:43:21+00:00 689093cc870e60ab82a176c33613fa0aeaa0bf69 [originally from svn r9478] 
[originally from svn r9478]
bk_text and bk_info both need to know the on-screen width of 2004-04-22T17:47:28+00:00 Simon Tatham anakin@pobox.com 2004-04-22T17:47:28+00:00 3e7ac03ca71c9b93c73fa58fd1de9a2042ec13d7 characters in order to wrap and align them properly. Therefore, they should be using wcwidth(). So here are a couple of wrappers on wcwidth(), one which filters out the Unicode characters not representable in the target charset, and one which converts _from_ a charset to Unicode before calling wcwidth(). bk_text and bk_info should now align correctly even in the face of unsupported characters and Japanese. [originally from svn r4116] 
characters in order to wrap and align them properly. Therefore, they
should be using wcwidth(). So here are a couple of wrappers on
wcwidth(), one which filters out the Unicode characters not
representable in the target charset, and one which converts _from_ a
charset to Unicode before calling wcwidth(). bk_text and bk_info
should now align correctly even in the face of unsupported
characters and Japanese.

[originally from svn r4116]