puzzles/malloc.c, branch devel My sgt-puzzles tree malloc.c: check allocation sizes against PTRDIFF_MAX. 2021-12-11T11:59:25+00:00 Simon Tatham anakin@pobox.com 2021-12-11T11:13:00+00:00 57fbcd2b29aa74423d47a9efd783a1508ab1bfc5 I don't expect this to actually come up in any circumstance, but it prevents a warning in some versions of gcc that would otherwise arise from the use of 'int' to compute the input size: if gcc isn't confident that the int is positive, then it complains that possible inputs to malloc might be in the region of 2^64 - (small multiple of a negative 32-bit int). I would hope malloc would fail in any case on such an input, so failing a couple of lines earlier makes no important difference. Annoyingly, stdint.h is missing in my NestedVM build setup (though it has stdbool.h - it's not _totally_ C90). So I have to check that at cmake time. Also, removed the #defines for smalloc and friends from the tree234 test mode. These were needed in the old build system, when tree234-test was built ad-hoc without being linked against malloc.c. But now tree234-test links against the same utils library as everything else, and can use the real smalloc - and doing so prevents another of these warnings when compiling with -flto. 
I don't expect this to actually come up in any circumstance, but it
prevents a warning in some versions of gcc that would otherwise arise
from the use of 'int' to compute the input size: if gcc isn't
confident that the int is positive, then it complains that possible
inputs to malloc might be in the region of 2^64 - (small multiple of a
negative 32-bit int).

I would hope malloc would fail in any case on such an input, so
failing a couple of lines earlier makes no important difference.

Annoyingly, stdint.h is missing in my NestedVM build setup (though it
has stdbool.h - it's not _totally_ C90). So I have to check that at
cmake time.

Also, removed the #defines for smalloc and friends from the tree234
test mode. These were needed in the old build system, when
tree234-test was built ad-hoc without being linked against malloc.c.
But now tree234-test links against the same utils library as
everything else, and can use the real smalloc - and doing so prevents
another of these warnings when compiling with -flto.
malloc.c: fix copy-pasted comment from the Dawn Of Time. 2021-12-11T11:16:36+00:00 Simon Tatham anakin@pobox.com 2021-12-11T11:12:06+00:00 5c5c607fdb834bc73033736f5774ef53c42008aa My standard 'abort on failure' wrappers around malloc and friends look more or less the same in most of my C software. In this case, they were so much the same that there was even a comment betraying that I copy-pasted them from Halibut. And nobody has noticed in the whole lifetime of this code base :-) 
My standard 'abort on failure' wrappers around malloc and friends look
more or less the same in most of my C software. In this case, they
were so much the same that there was even a comment betraying that I
copy-pasted them from Halibut. And nobody has noticed in the whole
lifetime of this code base :-)
Miscellaneous fixes from James Harvey's PalmOS porting work: 2005-06-01T17:47:56+00:00 Simon Tatham anakin@pobox.com 2005-06-01T17:47:56+00:00 50edaa578b614eb74c57a38faa2d05ab628ff81b - fixed numerous memory leaks (not Palm-specific) - corrected a couple of 32-bit-int assumptions (vital for Palm but generally a good thing anyway) - lifted a few function pointer types into explicit typedefs (neutral for me but convenient for the source-munging Perl scripts he uses to deal with Palm code segment rules) - lifted a few function-level static arrays into global static arrays (neutral for me but apparently works round a Palm tools bug) - a couple more presets in Rectangles (so that Palm, or any other slow platform which can't handle the larger sizes easily, can still have some variety available) - in Solo, arranged a means of sharing scratch space between calls to nsolve to prevent a lot of redundant malloc/frees (gives a 10% speed increase even on existing platforms) [originally from svn r5897] 
 - fixed numerous memory leaks (not Palm-specific)
 - corrected a couple of 32-bit-int assumptions (vital for Palm but
   generally a good thing anyway)
 - lifted a few function pointer types into explicit typedefs
   (neutral for me but convenient for the source-munging Perl
   scripts he uses to deal with Palm code segment rules)
 - lifted a few function-level static arrays into global static
   arrays (neutral for me but apparently works round a Palm tools
   bug)
 - a couple more presets in Rectangles (so that Palm, or any other
   slow platform which can't handle the larger sizes easily, can
   still have some variety available)
 - in Solo, arranged a means of sharing scratch space between calls
   to nsolve to prevent a lot of redundant malloc/frees (gives a 10%
   speed increase even on existing platforms)

[originally from svn r5897]
dupstr() should take a const char *. In particular, this allows 2004-05-04T09:56:38+00:00 Simon Tatham anakin@pobox.com 2004-05-04T09:56:38+00:00 2f999a9a595714fe62630b68065cee8d668ba13e compilation under GTK 2. [originally from svn r4198] 
compilation under GTK 2.

[originally from svn r4198]
Further general development. Net is now playable, though 2004-04-26T17:10:44+00:00 Simon Tatham anakin@pobox.com 2004-04-26T17:10:44+00:00 9867234e70002b8252a48c2bc023875ff87b8ca1 configuration is absent as yet. [originally from svn r4145] 
configuration is absent as yet.

[originally from svn r4145]
Initial checkin of a portable framework for writing small GUI puzzle 2004-04-25T14:27:58+00:00 Simon Tatham anakin@pobox.com 2004-04-25T14:27:58+00:00 96dbb537ee14f992459a8359a113a78414addf9d games. [originally from svn r4138] 
games.

[originally from svn r4138]