move_cursor(): handle visible flag; return useful value

This adds an extra parameter to move_cursor() that's an optional pointer
to a bool indicating whether the cursor is visible.  This allows for
centralising the common idiom of having the keyboard cursor become
visible when a cursor key is pressed.  Consistently with the vast
majority of existing puzzles, the cursor moves even if it was invisible
before, and becomes visible even if it can't move.

The function now also returns one of the special constants that can be
returned by interpret_move(), so that the caller can correctly return
MOVE_UI_UPDATE or MOVE_NO_EFFECT without needing to carefully check for
changes itself.

Callers are updated only to the extent that they all pass NULL as the
new argument.  Most of them could now be substantially simplified.

1 files changed, 2 insertions, 1 deletions

diff --git a/pattern.c b/pattern.c
index 1eafaff..734b70b 100644
--- a/pattern.c
+++ b/pattern.c
@@ -1395,7 +1395,8 @@ static char *interpret_move(const game_state *state, game_ui *ui,
     if (IS_CURSOR_MOVE(button)) {
 	int x = ui->cur_x, y = ui->cur_y, newstate;
 	char buf[80];
-        move_cursor(button, &ui->cur_x, &ui->cur_y, state->common->w, state->common->h, false);
+        move_cursor(button, &ui->cur_x, &ui->cur_y,
+                    state->common->w, state->common->h, false, NULL);
         ui->cur_visible = true;
 	if (!control && !shift) return MOVE_UI_UPDATE;