From b3243d75043cf1d70beb88d2a36eaebfe85c2c3f Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 1 Oct 2017 13:53:24 +0100 Subject: Return error messages as 'const char *', not 'char *'. They're never dynamically allocated, and are almost always string literals, so const is more appropriate. --- bridges.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'bridges.c') diff --git a/bridges.c b/bridges.c index 0684b36..0a326f2 100644 --- a/bridges.c +++ b/bridges.c @@ -795,7 +795,7 @@ static game_params *custom_params(const config_item *cfg) return ret; } -static char *validate_params(const game_params *params, int full) +static const char *validate_params(const game_params *params, int full) { if (params->w < 3 || params->h < 3) return "Width and height must be at least 3"; @@ -1989,7 +1989,7 @@ generated: return ret; } -static char *validate_desc(const game_params *params, const char *desc) +static const char *validate_desc(const game_params *params, const char *desc) { int i, wh = params->w * params->h; @@ -2573,7 +2573,7 @@ badmove: } static char *solve_game(const game_state *state, const game_state *currstate, - const char *aux, char **error) + const char *aux, const char **error) { char *ret; game_state *solved; -- cgit v1.1