From b3243d75043cf1d70beb88d2a36eaebfe85c2c3f Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 1 Oct 2017 13:53:24 +0100 Subject: Return error messages as 'const char *', not 'char *'. They're never dynamically allocated, and are almost always string literals, so const is more appropriate. --- flood.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'flood.c') diff --git a/flood.c b/flood.c index 90247fc..a3a2506 100644 --- a/flood.c +++ b/flood.c @@ -205,7 +205,7 @@ static game_params *custom_params(const config_item *cfg) return ret; } -static char *validate_params(const game_params *params, int full) +static const char *validate_params(const game_params *params, int full) { if (params->w < 2 && params->h < 2) return "Grid must contain at least two squares"; @@ -589,7 +589,7 @@ static char *new_game_desc(const game_params *params, random_state *rs, return desc; } -static char *validate_desc(const game_params *params, const char *desc) +static const char *validate_desc(const game_params *params, const char *desc) { int w = params->w, h = params->h, wh = w*h; int i; @@ -683,7 +683,7 @@ static void free_game(game_state *state) } static char *solve_game(const game_state *state, const game_state *currstate, - const char *aux, char **error) + const char *aux, const char **error) { int w = state->w, h = state->h, wh = w*h; char *moves, *ret, *p; -- cgit v1.1