From b3243d75043cf1d70beb88d2a36eaebfe85c2c3f Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 1 Oct 2017 13:53:24 +0100 Subject: Return error messages as 'const char *', not 'char *'. They're never dynamically allocated, and are almost always string literals, so const is more appropriate. --- palisade.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'palisade.c') diff --git a/palisade.c b/palisade.c index 3b5878b..5227a1d 100644 --- a/palisade.c +++ b/palisade.c @@ -155,7 +155,7 @@ static game_params *custom_params(const config_item *cfg) * +---+ the dominos is horizontal or vertical. +---+---+ */ -static char *validate_params(const game_params *params, int full) +static const char *validate_params(const game_params *params, int full) { int w = params->w, h = params->h, k = params->k, wh = w * h; @@ -701,7 +701,7 @@ static char *new_game_desc(const game_params *params, random_state *rs, return sresize(numbers, p - numbers, clue); } -static char *validate_desc(const game_params *params, const char *desc) +static const char *validate_desc(const game_params *params, const char *desc) { int w = params->w, h = params->h, wh = w*h, squares = 0; @@ -782,7 +782,7 @@ static void free_game(game_state *state) } static char *solve_game(const game_state *state, const game_state *currstate, - const char *aux, char **error) + const char *aux, const char **error) { int w = state->shared->params.w, h = state->shared->params.h, wh = w*h; borderflag *move; -- cgit v1.1