From 0186d78da9e83103eb80b3814d4de8031f29232f Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Thu, 16 Feb 2023 21:21:15 +0000 Subject: Mark many more function (and some objects) static I noticed commit db3b531e2cab765a00475054d2e9046c9d0437d3 in the history where Simon added a bunch of "static" qualifiers. That suggested that consistently marking internal functions "static" is desirable, so I tried a build using GCC's -Wmissing-declarations, which requires prior declaration (presumed to be in a header file) of all global functions. This commit makes the GTK build clean under GCC's -Wmissing-declarations. I've also adding "static" to a few obviously internal objects, but GCC doesn't complain about those so I certainly haven't got them all. --- signpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'signpost.c') diff --git a/signpost.c b/signpost.c index 17557a3..c74d9d4 100644 --- a/signpost.c +++ b/signpost.c @@ -2321,7 +2321,7 @@ const struct game thegame = { const char *quis = NULL; int verbose = 0; -void usage(FILE *out) { +static void usage(FILE *out) { fprintf(out, "usage: %s [--stdin] [--soak] [--seed SEED] |\n", quis); } -- cgit v1.1