From eeb2db283de9115f7256fa4cc49597d63e06b0ab Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 1 Oct 2017 12:52:12 +0100 Subject: New name UI_UPDATE for interpret_move's return "". Now midend.c directly tests the returned pointer for equality to this value, instead of checking whether it's the empty string. A minor effect of this is that games may now return a dynamically allocated empty string from interpret_move() and treat it as just another legal move description. But I don't expect anyone to be perverse enough to actually do that! The main purpose is that it avoids returning a string literal from a function whose return type is a pointer to _non-const_ char, i.e. we are now one step closer to being able to make this code base clean under -Wwrite-strings. --- singles.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'singles.c') diff --git a/singles.c b/singles.c index 5fe054c..ff6960f 100644 --- a/singles.c +++ b/singles.c @@ -1522,7 +1522,7 @@ static char *interpret_move(const game_state *state, game_ui *ui, action = TOGGLE_CIRCLE; } } - if (action == UI) return ""; + if (action == UI) return UI_UPDATE; if (action == TOGGLE_BLACK || action == TOGGLE_CIRCLE) { i = y * state->w + x; -- cgit v1.1