From 0186d78da9e83103eb80b3814d4de8031f29232f Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Thu, 16 Feb 2023 21:21:15 +0000 Subject: Mark many more function (and some objects) static I noticed commit db3b531e2cab765a00475054d2e9046c9d0437d3 in the history where Simon added a bunch of "static" qualifiers. That suggested that consistently marking internal functions "static" is desirable, so I tried a build using GCC's -Wmissing-declarations, which requires prior declaration (presumed to be in a header file) of all global functions. This commit makes the GTK build clean under GCC's -Wmissing-declarations. I've also adding "static" to a few obviously internal objects, but GCC doesn't complain about those so I certainly haven't got them all. --- sort.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sort.c') diff --git a/sort.c b/sort.c index d1897b6..2e20cac 100644 --- a/sort.c +++ b/sort.c @@ -93,14 +93,14 @@ void arraysort_fn(void *array, size_t nmemb, size_t size, #include #include -int testcmp(const void *av, const void *bv, void *ctx) +static int testcmp(const void *av, const void *bv, void *ctx) { int a = *(const int *)av, b = *(const int *)bv; const int *keys = (const int *)ctx; return keys[a] < keys[b] ? -1 : keys[a] > keys[b] ? +1 : 0; } -int resetcmp(const void *av, const void *bv) +static int resetcmp(const void *av, const void *bv) { int a = *(const int *)av, b = *(const int *)bv; return a < b ? -1 : a > b ? +1 : 0; -- cgit v1.1