From b3243d75043cf1d70beb88d2a36eaebfe85c2c3f Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Sun, 1 Oct 2017 13:53:24 +0100 Subject: Return error messages as 'const char *', not 'char *'. They're never dynamically allocated, and are almost always string literals, so const is more appropriate. --- undead.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'undead.c') diff --git a/undead.c b/undead.c index a9343e8..df0735e 100644 --- a/undead.c +++ b/undead.c @@ -191,7 +191,7 @@ static game_params *custom_params(const config_item *cfg) return ret; } -static char *validate_params(const game_params *params, int full) +static const char *validate_params(const game_params *params, int full) { if ((params->w * params->h ) > 54) return "Grid is too big"; if (params->w < 3) return "Width must be at least 3"; @@ -1436,7 +1436,7 @@ static game_state *new_game(midend *me, const game_params *params, return state; } -static char *validate_desc(const game_params *params, const char *desc) +static const char *validate_desc(const game_params *params, const char *desc) { int i; int w = params->w, h = params->h; @@ -1489,7 +1489,7 @@ static char *validate_desc(const game_params *params, const char *desc) } static char *solve_game(const game_state *state_start, const game_state *currstate, - const char *aux, char **error) + const char *aux, const char **error) { int p; int *old_guess; -- cgit v1.1