<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/gui/list.c, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix scrolling left button inadvertently cancels listtree</title>
<updated>2015-11-10T19:40:36+00:00</updated>
<author>
<name>Sebastian Leonhardt</name>
<email>sebastian.leonhardt@web.de</email>
</author>
<published>2015-10-20T22:11:44+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a8758c953d50fb020b245d5739c41de113638b49'/>
<id>a8758c953d50fb020b245d5739c41de113638b49</id>
<content type='text'>
Depending on the actual keymap, canceling a listtree with the
"scroll left" button may not be intended, especially
if the list is entered from a completely different focus
(think of leaving a plugin with "long left")

Note:
initializing "scrolling_left" with true without anything actually
scrolling sounds odd to me... maybe this variable should be renamed?
"pgleft_allow_cancel" comes to my mind (with opposite boolean states)

Change-Id: I58a747fc90e91ae96e75932febb462f1f1a1b4ca
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Depending on the actual keymap, canceling a listtree with the
"scroll left" button may not be intended, especially
if the list is entered from a completely different focus
(think of leaving a plugin with "long left")

Note:
initializing "scrolling_left" with true without anything actually
scrolling sounds odd to me... maybe this variable should be renamed?
"pgleft_allow_cancel" comes to my mind (with opposite boolean states)

Change-Id: I58a747fc90e91ae96e75932febb462f1f1a1b4ca
</pre>
</div>
</content>
</entry>
<entry>
<title>events: Rework event subsystem (add_event, send_event) to be more versatile.</title>
<updated>2014-03-14T22:36:30+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-03-14T22:15:16+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=470989bd708d9a425dbbf2d83b8fcbd0a8d0f488'/>
<id>470989bd708d9a425dbbf2d83b8fcbd0a8d0f488</id>
<content type='text'>
add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.

On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).

As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.

This commit also adds some documentation to events.h

Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.

On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).

As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.

This commit also adds some documentation to events.h

Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772
</pre>
</div>
</content>
</entry>
<entry>
<title>lists: Adapt put_line().</title>
<updated>2014-01-07T13:13:40+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2013-12-20T22:34:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=eec89a90ffdd077d687914fe18a9e48028f07fb4'/>
<id>eec89a90ffdd077d687914fe18a9e48028f07fb4</id>
<content type='text'>
This enables removing large portions of code, simplifiyng the drawing routine.
All of the removed code is functionaltiy now available through put_line().

Change-Id: Ib8e61772134189a8c3c6d22345c0b45e912bea76
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This enables removing large portions of code, simplifiyng the drawing routine.
All of the removed code is functionaltiy now available through put_line().

Change-Id: Ib8e61772134189a8c3c6d22345c0b45e912bea76
</pre>
</div>
</content>
</entry>
<entry>
<title>simplelist: Fix simplelist_set_line_count() so it actually sets the count</title>
<updated>2013-03-28T11:32:57+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2013-03-27T11:43:40+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=83d3f1d3f65e4115bc5a8348d126b6ab7cbbcf64'/>
<id>83d3f1d3f65e4115bc5a8348d126b6ab7cbbcf64</id>
<content type='text'>
(hopefully) Fixes FS#12838

Change-Id: I932184afaf7b65121a0c459cd03c8482e3bad22b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
(hopefully) Fixes FS#12838

Change-Id: I932184afaf7b65121a0c459cd03c8482e3bad22b
</pre>
</div>
</content>
</entry>
<entry>
<title>simplelist: Make better use of the static buffer and simplify API</title>
<updated>2013-02-12T10:01:13+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2013-02-12T09:35:11+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=69228f92dbddc9940166c0d7af2b4c79d55f85e7'/>
<id>69228f92dbddc9940166c0d7af2b4c79d55f85e7</id>
<content type='text'>
Change-Id: I1327fcd01d6f817be6c7018d30d33446c9b57287
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I1327fcd01d6f817be6c7018d30d33446c9b57287
</pre>
</div>
</content>
</entry>
<entry>
<title>_lists_uiviewport_update_callback can be made static</title>
<updated>2012-05-19T23:57:49+00:00</updated>
<author>
<name>Bertrik Sikken</name>
<email>bertrik@sikken.nl</email>
</author>
<published>2012-05-19T23:57:49+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=f340768ad5210c875359e867353a1a73959a9da7'/>
<id>f340768ad5210c875359e867353a1a73959a9da7</id>
<content type='text'>
Change-Id: I25dfaa1636811a0340d1730a5a8f44caa85b1771
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I25dfaa1636811a0340d1730a5a8f44caa85b1771
</pre>
</div>
</content>
</entry>
<entry>
<title>Redraw simplelist if/when necessary-</title>
<updated>2012-03-22T20:05:30+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2012-03-22T19:59:01+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6e6f0c6ef35cebc2ca199ca01f12598ad0209c1c'/>
<id>6e6f0c6ef35cebc2ca199ca01f12598ad0209c1c</id>
<content type='text'>
Change-Id: I14a1cce8967af60a52d2d13e0b035b71fece8a63
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I14a1cce8967af60a52d2d13e0b035b71fece8a63
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix FS#12606 - next track can cause the screen to be cleared</title>
<updated>2012-03-20T11:10:19+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2012-03-20T10:27:33+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=94139ac0bd3e1ca5d384ac8ac5ad2a915d633a82'/>
<id>94139ac0bd3e1ca5d384ac8ac5ad2a915d633a82</id>
<content type='text'>
This is a bit of a hack. We now trigger an event when the skin engine
is doing a full redraw (which means fullscreen clear) before the
lcd_update() to give the current screen a chance to redraw to avoid the
screen flicker.

This commit fixes the issue for screens which are entirely the list
widget (i.e browser and menus), other screens will need aditional fixes
(i.e quickscreen, time&amp;date screen)

Change-Id: I3725c51518be724ce7aacee9877663c2de6866fa
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a bit of a hack. We now trigger an event when the skin engine
is doing a full redraw (which means fullscreen clear) before the
lcd_update() to give the current screen a chance to redraw to avoid the
screen flicker.

This commit fixes the issue for screens which are entirely the list
widget (i.e browser and menus), other screens will need aditional fixes
(i.e quickscreen, time&amp;date screen)

Change-Id: I3725c51518be724ce7aacee9877663c2de6866fa
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Fix FS#12606 - next track can cause the screen to be cleared"</title>
<updated>2012-03-15T00:31:18+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2012-03-15T00:31:18+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=f31e7a1225ef2daf7c511bd286d9776894deba9f'/>
<id>f31e7a1225ef2daf7c511bd286d9776894deba9f</id>
<content type='text'>
This reverts commit cb9bc3bbc8a66c3d5296bfbc68f4487c39c6ac68.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit cb9bc3bbc8a66c3d5296bfbc68f4487c39c6ac68.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix FS#12606 - next track can cause the screen to be cleared</title>
<updated>2012-03-14T11:52:24+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2012-03-14T11:16:58+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=cb9bc3bbc8a66c3d5296bfbc68f4487c39c6ac68'/>
<id>cb9bc3bbc8a66c3d5296bfbc68f4487c39c6ac68</id>
<content type='text'>
This is a bit of a hack. We now trigger an event when the skin engine
is doing a full redraw (which means fullscreen clear) before the
lcd_update() to give the current screen a chance to redraw to avoid the
screen flicker.

This commit fixes the issue for screens which are entirely the list
widget (i.e browser and menus), other screens will need aditional fixes
(i.e quickscreen, time&amp;date screen)

Change-Id: I3ffdcd8ccad2c663732f8d5983049c837de00fe5
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a bit of a hack. We now trigger an event when the skin engine
is doing a full redraw (which means fullscreen clear) before the
lcd_update() to give the current screen a chance to redraw to avoid the
screen flicker.

This commit fixes the issue for screens which are entirely the list
widget (i.e browser and menus), other screens will need aditional fixes
(i.e quickscreen, time&amp;date screen)

Change-Id: I3ffdcd8ccad2c663732f8d5983049c837de00fe5
</pre>
</div>
</content>
</entry>
</feed>
