<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/gui/skin_engine/skin_backdrops.c, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix broken buflib_handle check in backdrop settings loader</title>
<updated>2014-12-20T11:33:26+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-20T11:27:38+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055'/>
<id>1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055</id>
<content type='text'>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine/backdrops: Have to reload default backdrops from setting when it changed.</title>
<updated>2014-01-22T15:58:58+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-01-22T15:58:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6cb11764e001e8d4d8417c8f5c93e4168d4b3267'/>
<id>6cb11764e001e8d4d8417c8f5c93e4168d4b3267</id>
<content type='text'>
When skins use the default backdrop (via %X(-) or no %X at all) and the setting
changes it needs to be reloaded, otherwise when changing themes the new theme
could show the backdrop from the previous theme. The same needs to be
done when re-selecting the same theme after USB because the backdrop file was
potentially overwritten.

Fixes FS#12892 and FS#12942.

Change-Id: Ic2d20740cc385fa99667ce8a71507dbda2efceaf
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When skins use the default backdrop (via %X(-) or no %X at all) and the setting
changes it needs to be reloaded, otherwise when changing themes the new theme
could show the backdrop from the previous theme. The same needs to be
done when re-selecting the same theme after USB because the backdrop file was
potentially overwritten.

Fixes FS#12892 and FS#12942.

Change-Id: Ic2d20740cc385fa99667ce8a71507dbda2efceaf
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: Add a debug screen to display skin ram usage</title>
<updated>2013-02-12T10:01:13+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2013-02-12T10:00:05+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=aaf30651df27e0eb6fab876502fa1e6c084160bf'/>
<id>aaf30651df27e0eb6fab876502fa1e6c084160bf</id>
<content type='text'>
Change-Id: Ida9c33211d9360ac88e30a2cf8df9f191bee8b45
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ida9c33211d9360ac88e30a2cf8df9f191bee8b45
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix checks on buflib allocated handles (0 is not a valid handle value)</title>
<updated>2012-06-10T15:15:47+00:00</updated>
<author>
<name>Bertrik Sikken</name>
<email>bertrik@sikken.nl</email>
</author>
<published>2012-06-10T15:15:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d023bf0f5dedb67caf9229e3ddcbb5a9fea420ce'/>
<id>d023bf0f5dedb67caf9229e3ddcbb5a9fea420ce</id>
<content type='text'>
Change-Id: I8fdc5a59a5062f40a431cd49971390e21631b8ec
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I8fdc5a59a5062f40a431cd49971390e21631b8ec
</pre>
</div>
</content>
</entry>
<entry>
<title>Use buflib for the allocation of voice PCM resources.</title>
<updated>2012-05-02T21:22:28+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2012-05-02T21:22:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=da6cebb6b0b17b4a75a2bd4f51b7cf70b5dafe40'/>
<id>da6cebb6b0b17b4a75a2bd4f51b7cf70b5dafe40</id>
<content type='text'>
Buffers are not allocated and thread is not created until the first
call where voice is required.

Adds a different callback (sync_callback) to buflib so that other
sorts of synchonization are possible, such as briefly locking-out the
PCM callback for a buffer move. It's sort of a messy addition but it
is needed so voice decoding won't have to be stopped when its buffer
is moved.

Change-Id: I4d4d8c35eed5dd15fb7ee7df9323af3d036e92b3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Buffers are not allocated and thread is not created until the first
call where voice is required.

Adds a different callback (sync_callback) to buflib so that other
sorts of synchonization are possible, such as briefly locking-out the
PCM callback for a buffer move. It's sort of a messy addition but it
is needed so voice decoding won't have to be stopped when its buffer
is moved.

Change-Id: I4d4d8c35eed5dd15fb7ee7df9323af3d036e92b3
</pre>
</div>
</content>
</entry>
<entry>
<title>lcd/skin_engine: Add the ability to draw onto the backdrop layer</title>
<updated>2012-02-28T12:03:04+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2012-02-28T11:26:32+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2c71aa9feb0268da7d993feddbbe4db591fcd3ba'/>
<id>2c71aa9feb0268da7d993feddbbe4db591fcd3ba</id>
<content type='text'>
The framebuffer the lcd driver uses can now be changed on the fly
which means that regular lcd_* drawing functions can draw onto the
"backdrop" buffer. The skin engine can use this to create layered
effects.

Add the tag %VB to a viewport to draw that viewport onto the
backdrop layer. If you want to draw an image onto the backdrop
framebuffer use %x(backdrop filename) instead of %X() inside
a viewport with %VB.

Change-Id: I741498e2af6d4f2d78932cabe8942317893e7cfc
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The framebuffer the lcd driver uses can now be changed on the fly
which means that regular lcd_* drawing functions can draw onto the
"backdrop" buffer. The skin engine can use this to create layered
effects.

Add the tag %VB to a viewport to draw that viewport onto the
backdrop layer. If you want to draw an image onto the backdrop
framebuffer use %x(backdrop filename) instead of %X() inside
a viewport with %VB.

Change-Id: I741498e2af6d4f2d78932cabe8942317893e7cfc
</pre>
</div>
</content>
</entry>
<entry>
<title>slightly reaarange code to make fml happy :)</title>
<updated>2011-11-27T13:57:18+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2011-11-27T13:57:18+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=fc5cdacafdf0d76e84bd172492a67f46a547b999'/>
<id>fc5cdacafdf0d76e84bd172492a67f46a547b999</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31071 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31071 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Free a handle when we try to load a backdrop file which doesnt exist or cant be loaded</title>
<updated>2011-11-27T11:50:07+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2011-11-27T11:50:07+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=494860cfd4a8803a28f0dfe604efbf2b9b811d8d'/>
<id>494860cfd4a8803a28f0dfe604efbf2b9b811d8d</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31070 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31070 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>skinengine: Rework skin loading so skins can be un/loaded individually. This also means that loading a .cfg which doesnt change themes shouldnt have them reloaded</title>
<updated>2011-11-21T10:02:23+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2011-11-21T10:02:23+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=0ca4b38b1b04e6b7d6f5ad1f3654f8f361d8933f'/>
<id>0ca4b38b1b04e6b7d6f5ad1f3654f8f361d8933f</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31037 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31037 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Get rid of a really annoying #ifdef line to check if backdrop support should be enabled</title>
<updated>2011-11-19T13:46:25+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2011-11-19T13:46:25+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1252d0d54084a17255d2fad57a462cd15479561b'/>
<id>1252d0d54084a17255d2fad57a462cd15479561b</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31027 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31027 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
</feed>
