<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/gui/skin_engine/skin_parser.c, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix dangerous casts</title>
<updated>2017-02-04T16:24:47+00:00</updated>
<author>
<name>Amaury Pouly</name>
<email>amaury.pouly@gmail.com</email>
</author>
<published>2017-01-15T23:10:38+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d7871914acd2ed77f43344e36e08944524a67d9e'/>
<id>d7871914acd2ed77f43344e36e08944524a67d9e</id>
<content type='text'>
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h

Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h

Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
</pre>
</div>
</content>
</entry>
<entry>
<title>add supports for x,y value in percentage to several tags.</title>
<updated>2014-07-21T02:54:53+00:00</updated>
<author>
<name>Chiwen Chang</name>
<email>rock1104.tw@yahoo.com.tw</email>
</author>
<published>2014-07-21T02:31:01+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce'/>
<id>9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce</id>
<content type='text'>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: kill scrolling if the buffer moves</title>
<updated>2014-06-29T09:48:25+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-19T09:46:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=7b377d29fbdc32d0e413614370b00f21cd22049b'/>
<id>7b377d29fbdc32d0e413614370b00f21cd22049b</id>
<content type='text'>
I have a suspicion that if there is any scrolling skin lines when
the buflib buffer moves it will cause the lcd code to crash.

This *hopefully* explains the random skin related crashed which
have been reported.

Change-Id: I04ee58292e1cea7c77ef9737b0641192f4f7e4ba
Reviewed-on: http://gerrit.rockbox.org/877
Reviewed-by: Thomas Martitz &lt;kugel@rockbox.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I have a suspicion that if there is any scrolling skin lines when
the buflib buffer moves it will cause the lcd code to crash.

This *hopefully* explains the random skin related crashed which
have been reported.

Change-Id: I04ee58292e1cea7c77ef9737b0641192f4f7e4ba
Reviewed-on: http://gerrit.rockbox.org/877
Reviewed-by: Thomas Martitz &lt;kugel@rockbox.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fix indenting, editor went nuts</title>
<updated>2014-06-02T12:01:36+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-02T12:01:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6e701d3232cdd05a6806679bb88c1e34fbf22bd7'/>
<id>6e701d3232cdd05a6806679bb88c1e34fbf22bd7</id>
<content type='text'>
Change-Id: Ibe363e5c75260f50c6c6c6fc58a2758a7902ffc3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ibe363e5c75260f50c6c6c6fc58a2758a7902ffc3
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: Don't double free buflib handles shared by skin images</title>
<updated>2014-06-02T11:26:22+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-02T11:26:22+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=e417036f60ec187a6696f2e447a1f269a338d6e7'/>
<id>e417036f60ec187a6696f2e447a1f269a338d6e7</id>
<content type='text'>
Change-Id: I4158fb7dae664a746141f458c08bdcb84e148041
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4158fb7dae664a746141f458c08bdcb84e148041
</pre>
</div>
</content>
</entry>
<entry>
<title>Also make sure progressbars don't tihnk their images are loaded</title>
<updated>2014-05-18T10:58:00+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-05-18T10:58:00+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=8fb0bbcc20e3348193eedc44cd5c9c0fac899ad3'/>
<id>8fb0bbcc20e3348193eedc44cd5c9c0fac899ad3</id>
<content type='text'>
Change-Id: I83bb8e246e4858396ca0b5d0d90fbd2d08a88c1e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I83bb8e246e4858396ca0b5d0d90fbd2d08a88c1e
</pre>
</div>
</content>
</entry>
<entry>
<title>fix skin buffer crashes, img's are not loaded initialy</title>
<updated>2014-05-18T10:47:32+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-05-18T10:47:32+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=62d357b60141d64a754de86fdfaa50d819ab8aba'/>
<id>62d357b60141d64a754de86fdfaa50d819ab8aba</id>
<content type='text'>
Change-Id: I32b5d5e446f5ae9340be2bd47841b06a5dbabeec
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I32b5d5e446f5ae9340be2bd47841b06a5dbabeec
</pre>
</div>
</content>
</entry>
<entry>
<title>don't load the same bmp image more than once in a skin</title>
<updated>2014-05-14T09:41:55+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-03-27T07:15:12+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=01cbb795e9a059238f0e39d44d279c1d52874e06'/>
<id>01cbb795e9a059238f0e39d44d279c1d52874e06</id>
<content type='text'>
Change-Id: Ie38146a80bb356f40810f017c262b81edac69688
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ie38146a80bb356f40810f017c262b81edac69688
</pre>
</div>
</content>
</entry>
<entry>
<title>Implement time-based resume and playback start.</title>
<updated>2014-03-10T03:12:30+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2013-07-14T11:59:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=31b712286721dd606940c7b557d03e3f714b9604'/>
<id>31b712286721dd606940c7b557d03e3f714b9604</id>
<content type='text'>
This complements offset-based resume and playback start funcionality.
The implementation is global on both HWCODEC and SWCODEC.

Basically, if either the specified elapsed or offset are non-zero,
it indicates a mid-track resume.

To resume by time only, set elapsed to nonzero and offset to zero.
To resume by offset only, set offset to nonzero and elapsed to zero.

Which one the codec uses and which has priority is up to the codec;
however, using an elapsed time covers more cases:

* Codecs not able to use an offset such as VGM or other atomic
formats

* Starting playback at a nonzero elapsed time from a source that
contains no offset, such as a cuesheet

The change re-versions pretty much everything from tagcache to nvram.

Change-Id: Ic7aebb24e99a03ae99585c5e236eba960d163f38
Reviewed-on: http://gerrit.rockbox.org/516
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This complements offset-based resume and playback start funcionality.
The implementation is global on both HWCODEC and SWCODEC.

Basically, if either the specified elapsed or offset are non-zero,
it indicates a mid-track resume.

To resume by time only, set elapsed to nonzero and offset to zero.
To resume by offset only, set offset to nonzero and elapsed to zero.

Which one the codec uses and which has priority is up to the codec;
however, using an elapsed time covers more cases:

* Codecs not able to use an offset such as VGM or other atomic
formats

* Starting playback at a nonzero elapsed time from a source that
contains no offset, such as a cuesheet

The change re-versions pretty much everything from tagcache to nvram.

Change-Id: Ic7aebb24e99a03ae99585c5e236eba960d163f38
Reviewed-on: http://gerrit.rockbox.org/516
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: Stricter checking for x, y, width, height for bar tags.</title>
<updated>2014-01-12T22:13:45+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-01-12T22:13:45+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4e1c690ea7b2163f64e3ca9dc25ca69bc75ee433'/>
<id>4e1c690ea7b2163f64e3ca9dc25ca69bc75ee433</id>
<content type='text'>
Every theme that doesn't parse anymore now has broken values. I hope it's not
too many of them.

Change-Id: I6f52e55dc9197d0919f854240723a88f99c0b7da
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Every theme that doesn't parse anymore now has broken values. I hope it's not
too many of them.

Change-Id: I6f52e55dc9197d0919f854240723a88f99c0b7da
</pre>
</div>
</content>
</entry>
</feed>
