rockbox/apps/gui/skin_engine, branch quake5 My Rockbox tree Fix skin_engine.c Album Art never dealloc'd on theme change 2019-02-26T06:43:04+00:00 William Wilgus me.theuser@yahoo.com 2019-02-07T11:30:11+00:00 075108e34a69dec206603598738c2828b6bf7ff6 Patch from forum user Chris_s http://forums.rockbox.org/index.php/topic,52708.0.html Change-Id: I29f8702ced300d1dc90dfa0e8baa609b9051903e 
Patch from forum user Chris_s

http://forums.rockbox.org/index.php/topic,52708.0.html

Change-Id: I29f8702ced300d1dc90dfa0e8baa609b9051903e
Do playback restarts the proper way 2017-11-24T13:55:49+00:00 Michael Sevakis jethead71@rockbox.org 2017-11-24T12:55:56+00:00 abef23608152a2839c34dcfc283d1561b3eadd45 It isn't necessary to explicitly stop and restart playback to force it to update something that must cause rebuffering. Change-Id: I6ff5394fcafc7374af67ef9fbf9022bb4a79b773 
It isn't necessary to explicitly stop and restart playback to
force it to update something that must cause rebuffering.

Change-Id: I6ff5394fcafc7374af67ef9fbf9022bb4a79b773
Undo hacks to meant to get around string formatting limitations 2017-11-21T10:01:14+00:00 Michael Sevakis jethead71@rockbox.org 2017-09-18T10:00:05+00:00 aced667f48c29a160aa4e5c0a8df037092b28189 The new vuprintf makes unnecessary workarounds due to formatting limitations. I checked grep output for whatever appeared to fit but it's possible I missed some instances because they weren't so obvious. Also, this means sound settings can dynamically work with any number of decimals rather than the current assumption of one or two. Add an ipow() function to help and take advantage of dynamic field width and precision. Consolidate string formatting of sound settings. Change-Id: I46caf534859dfd1916cd440cd25e5206b192fcd8 
The new vuprintf makes unnecessary workarounds due to formatting
limitations. I checked grep output for whatever appeared to fit
but it's possible I missed some instances because they weren't
so obvious.

Also, this means sound settings can dynamically work with any
number of decimals rather than the current assumption of one or
two. Add an ipow() function to help and take advantage of dynamic
field width and precision. Consolidate string formatting of sound
settings.

Change-Id: I46caf534859dfd1916cd440cd25e5206b192fcd8
Improve radio RDS driver and framework 2017-02-12T03:19:32+00:00 Michael Sevakis jethead71@rockbox.org 2017-01-30T14:52:05+00:00 fc9695eb47732e1c189e2f033dbd55e5c346e8c4 * Remove unused bits like the radio event and simplify basic radio interface. It can be more self-contained with rds.h only required by radio and tuner code. * Add post-processing to text a-la Silicon Labs AN243. The chip's error correction can only do so much; additional checks are highly recommended. Simply testing for two identical messages in a row is extremely effective and I've never seen corrupted text since doing that, even with mediocre reception. Groups segments must arrive in order, not randomly; logic change only accepts them in order, starting at 0. Time readout was made a bit better but really we'd need to use verbose mode and ensure that no errors were seen during receiving of time and more checks would be need to have a stable PI. The text is the important bit anyway. * Time out of stale text. * Text is no longer updated until a complete group has been received, as is specified in the standard. Perhaps go back to scrolling text lines in the radio screen? * Add proper character conversion to UTF-8. Only the default G0 table for the moment. The other two could be added in. * Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow the option for processed RDS data to be pushed to the driver and still do proper post-processing (only text conversion for now for the latter). Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925 
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.

* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.

Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.

Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.

* Time out of stale text.

* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?

* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.

* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).

Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Fix dangerous casts 2017-02-04T16:24:47+00:00 Amaury Pouly amaury.pouly@gmail.com 2017-01-15T23:10:38+00:00 d7871914acd2ed77f43344e36e08944524a67d9e On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is not valid. In any case, one should use intptr_t and ptrdiff_t when casting to integers. This commit attempts to fix all instances reported by GCC. When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc 
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h

Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
Fix misleading indentation as pointed out by the new gcc warning 2016-08-12T13:33:28+00:00 Frank Gevaerts frank@gevaerts.be 2016-08-12T13:33:28+00:00 4f7f7f286d168998d260c16d2be62e02a379aae1 Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857 
Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857
Clarify usb_powered() and fix some code. 2015-01-08T15:45:32+00:00 Amaury Pouly amaury.pouly@gmail.com 2015-01-02T21:15:31+00:00 dc127f213c9b7e60f649bc236602e4f28285c53b Either by mistake or because its meaning changed, usb_powered() doesn't mean what the name suggest, so clarify its meaning by renaming it to usb_powered_only. So use of usb_powered() are replaced by usb_inserted() when it makes more sense. Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8 Reviewed-on: http://gerrit.rockbox.org/1097 Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com> 
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.

Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Fix broken buflib_handle check in backdrop settings loader 2014-12-20T11:33:26+00:00 Thomas Jarosch tomj@simonv.com 2014-12-20T11:27:38+00:00 1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055 The logic was messed up and always evaluated to true if buflib_handle is non-zero. Thanks to JdGordon for verifying the change. cppcheck reported: [rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1. Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83 
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
Correct some file permissions. 2014-09-08T14:04:39+00:00 Szymon Dziok b0hoon@o2.pl 2014-09-08T14:04:39+00:00 4c6939fc3dce2a72d53b68e8a71fc2ebf917d276 Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16 
Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16
add supports for x,y value in percentage to several tags. 2014-07-21T02:54:53+00:00 Chiwen Chang rock1104.tw@yahoo.com.tw 2014-07-21T02:31:01+00:00 9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce including BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe Reviewed-on: http://gerrit.rockbox.org/900 Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info> 
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>