<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/gui/skin_engine, branch working</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix misleading indentation as pointed out by the new gcc warning</title>
<updated>2016-08-12T13:33:28+00:00</updated>
<author>
<name>Frank Gevaerts</name>
<email>frank@gevaerts.be</email>
</author>
<published>2016-08-12T13:33:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4f7f7f286d168998d260c16d2be62e02a379aae1'/>
<id>4f7f7f286d168998d260c16d2be62e02a379aae1</id>
<content type='text'>
Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857
</pre>
</div>
</content>
</entry>
<entry>
<title>Clarify usb_powered() and fix some code.</title>
<updated>2015-01-08T15:45:32+00:00</updated>
<author>
<name>Amaury Pouly</name>
<email>amaury.pouly@gmail.com</email>
</author>
<published>2015-01-02T21:15:31+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=dc127f213c9b7e60f649bc236602e4f28285c53b'/>
<id>dc127f213c9b7e60f649bc236602e4f28285c53b</id>
<content type='text'>
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.

Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly &lt;amaury.pouly@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.

Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly &lt;amaury.pouly@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix broken buflib_handle check in backdrop settings loader</title>
<updated>2014-12-20T11:33:26+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-20T11:27:38+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055'/>
<id>1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055</id>
<content type='text'>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</pre>
</div>
</content>
</entry>
<entry>
<title>Correct some file permissions.</title>
<updated>2014-09-08T14:04:39+00:00</updated>
<author>
<name>Szymon Dziok</name>
<email>b0hoon@o2.pl</email>
</author>
<published>2014-09-08T14:04:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4c6939fc3dce2a72d53b68e8a71fc2ebf917d276'/>
<id>4c6939fc3dce2a72d53b68e8a71fc2ebf917d276</id>
<content type='text'>
Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16
</pre>
</div>
</content>
</entry>
<entry>
<title>add supports for x,y value in percentage to several tags.</title>
<updated>2014-07-21T02:54:53+00:00</updated>
<author>
<name>Chiwen Chang</name>
<email>rock1104.tw@yahoo.com.tw</email>
</author>
<published>2014-07-21T02:31:01+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce'/>
<id>9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce</id>
<content type='text'>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: kill scrolling if the buffer moves</title>
<updated>2014-06-29T09:48:25+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-19T09:46:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=7b377d29fbdc32d0e413614370b00f21cd22049b'/>
<id>7b377d29fbdc32d0e413614370b00f21cd22049b</id>
<content type='text'>
I have a suspicion that if there is any scrolling skin lines when
the buflib buffer moves it will cause the lcd code to crash.

This *hopefully* explains the random skin related crashed which
have been reported.

Change-Id: I04ee58292e1cea7c77ef9737b0641192f4f7e4ba
Reviewed-on: http://gerrit.rockbox.org/877
Reviewed-by: Thomas Martitz &lt;kugel@rockbox.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I have a suspicion that if there is any scrolling skin lines when
the buflib buffer moves it will cause the lcd code to crash.

This *hopefully* explains the random skin related crashed which
have been reported.

Change-Id: I04ee58292e1cea7c77ef9737b0641192f4f7e4ba
Reviewed-on: http://gerrit.rockbox.org/877
Reviewed-by: Thomas Martitz &lt;kugel@rockbox.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lcd-24bit: Introduce a 24-bit mid-level LCD driver</title>
<updated>2014-06-20T22:15:53+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-06-18T05:15:00+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a1842c04f9cb73210d4cacde61a9e4b115050765'/>
<id>a1842c04f9cb73210d4cacde61a9e4b115050765</id>
<content type='text'>
With LCD driver all calculation will be performed on RGB888 and the hardware/OS
can display from our 24bit framebuffer.

It is not yet as performance optimized as the existing drivers but should be
good enough.The vast number of small changes is due to the fact that
fb_data can be a struct type now, while most of the code expected a scalar type.

lcd-as-memframe ASM code does not work with 24bit currently so the with 24bit
it enforces the generic C code.

All plugins are ported over. Except for rockpaint. It uses so much memory that
it wouldnt fit into the 512k plugin buffer anymore (patches welcome).

Change-Id: Ibb1964545028ce0d8ff9833ccc3ab66be3ee0754
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With LCD driver all calculation will be performed on RGB888 and the hardware/OS
can display from our 24bit framebuffer.

It is not yet as performance optimized as the existing drivers but should be
good enough.The vast number of small changes is due to the fact that
fb_data can be a struct type now, while most of the code expected a scalar type.

lcd-as-memframe ASM code does not work with 24bit currently so the with 24bit
it enforces the generic C code.

All plugins are ported over. Except for rockpaint. It uses so much memory that
it wouldnt fit into the 512k plugin buffer anymore (patches welcome).

Change-Id: Ibb1964545028ce0d8ff9833ccc3ab66be3ee0754
</pre>
</div>
</content>
</entry>
<entry>
<title>fix indenting, editor went nuts</title>
<updated>2014-06-02T12:01:36+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-02T12:01:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6e701d3232cdd05a6806679bb88c1e34fbf22bd7'/>
<id>6e701d3232cdd05a6806679bb88c1e34fbf22bd7</id>
<content type='text'>
Change-Id: Ibe363e5c75260f50c6c6c6fc58a2758a7902ffc3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ibe363e5c75260f50c6c6c6fc58a2758a7902ffc3
</pre>
</div>
</content>
</entry>
<entry>
<title>skin_engine: Don't double free buflib handles shared by skin images</title>
<updated>2014-06-02T11:26:22+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-06-02T11:26:22+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=e417036f60ec187a6696f2e447a1f269a338d6e7'/>
<id>e417036f60ec187a6696f2e447a1f269a338d6e7</id>
<content type='text'>
Change-Id: I4158fb7dae664a746141f458c08bdcb84e148041
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4158fb7dae664a746141f458c08bdcb84e148041
</pre>
</div>
</content>
</entry>
<entry>
<title>Also make sure progressbars don't tihnk their images are loaded</title>
<updated>2014-05-18T10:58:00+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2014-05-18T10:58:00+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=8fb0bbcc20e3348193eedc44cd5c9c0fac899ad3'/>
<id>8fb0bbcc20e3348193eedc44cd5c9c0fac899ad3</id>
<content type='text'>
Change-Id: I83bb8e246e4858396ca0b5d0d90fbd2d08a88c1e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I83bb8e246e4858396ca0b5d0d90fbd2d08a88c1e
</pre>
</div>
</content>
</entry>
</feed>
