<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/gui, branch puzzles</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix misleading indentation as pointed out by the new gcc warning</title>
<updated>2016-08-12T13:33:28+00:00</updated>
<author>
<name>Frank Gevaerts</name>
<email>frank@gevaerts.be</email>
</author>
<published>2016-08-12T13:33:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4f7f7f286d168998d260c16d2be62e02a379aae1'/>
<id>4f7f7f286d168998d260c16d2be62e02a379aae1</id>
<content type='text'>
Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia9c0b09ffb57dccbc7d13fce3b3a8a7d46b84857
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix reset runtime</title>
<updated>2016-04-04T09:05:43+00:00</updated>
<author>
<name>Mihail Zenkov</name>
<email>mihail.zenkov@gmail.com</email>
</author>
<published>2016-03-30T22:25:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6228c8da185066e3e8824bffc47ed2d11147e84b'/>
<id>6228c8da185066e3e8824bffc47ed2d11147e84b</id>
<content type='text'>
Change-Id: Ic1ba0c7c7883aae43100c67235dbc2db83056fe7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ic1ba0c7c7883aae43100c67235dbc2db83056fe7
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix scrolling left button inadvertently cancels listtree</title>
<updated>2015-11-10T19:40:36+00:00</updated>
<author>
<name>Sebastian Leonhardt</name>
<email>sebastian.leonhardt@web.de</email>
</author>
<published>2015-10-20T22:11:44+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a8758c953d50fb020b245d5739c41de113638b49'/>
<id>a8758c953d50fb020b245d5739c41de113638b49</id>
<content type='text'>
Depending on the actual keymap, canceling a listtree with the
"scroll left" button may not be intended, especially
if the list is entered from a completely different focus
(think of leaving a plugin with "long left")

Note:
initializing "scrolling_left" with true without anything actually
scrolling sounds odd to me... maybe this variable should be renamed?
"pgleft_allow_cancel" comes to my mind (with opposite boolean states)

Change-Id: I58a747fc90e91ae96e75932febb462f1f1a1b4ca
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Depending on the actual keymap, canceling a listtree with the
"scroll left" button may not be intended, especially
if the list is entered from a completely different focus
(think of leaving a plugin with "long left")

Note:
initializing "scrolling_left" with true without anything actually
scrolling sounds odd to me... maybe this variable should be renamed?
"pgleft_allow_cancel" comes to my mind (with opposite boolean states)

Change-Id: I58a747fc90e91ae96e75932febb462f1f1a1b4ca
</pre>
</div>
</content>
</entry>
<entry>
<title>AB repeat: fix bug that prevents to jump to beginning of track</title>
<updated>2015-10-25T19:58:36+00:00</updated>
<author>
<name>Sebastian Leonhardt</name>
<email>sebastian.leonhardt@web.de</email>
</author>
<published>2015-10-25T19:58:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=ce26212138d53147e3e2e91f7b864d5deada344f'/>
<id>ce26212138d53147e3e2e91f7b864d5deada344f</id>
<content type='text'>
Change-Id: Ia323a2b16eaaf7d9afa888b71fd8b20fd9e2e62c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia323a2b16eaaf7d9afa888b71fd8b20fd9e2e62c
</pre>
</div>
</content>
</entry>
<entry>
<title>iPod Classic: reads HDD S.M.A.R.T. data</title>
<updated>2015-10-07T04:15:04+00:00</updated>
<author>
<name>Cástor Muñoz</name>
<email>cmvidal@gmail.com</email>
</author>
<published>2014-12-09T18:38:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d20185ac96c4b50ed4de7098a101a31f2b140b82'/>
<id>d20185ac96c4b50ed4de7098a101a31f2b140b82</id>
<content type='text'>
Adds ata_read_smart() function to storage ATA driver, current
SMART data can be displayed and optionally written to hard
disk using System-&gt;Debug menu.

Change-Id: Ie8817bb311d5d956df2f0fbfaf554e2d53e89a93
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds ata_read_smart() function to storage ATA driver, current
SMART data can be displayed and optionally written to hard
disk using System-&gt;Debug menu.

Change-Id: Ie8817bb311d5d956df2f0fbfaf554e2d53e89a93
</pre>
</div>
</content>
</entry>
<entry>
<title>Clarify usb_powered() and fix some code.</title>
<updated>2015-01-08T15:45:32+00:00</updated>
<author>
<name>Amaury Pouly</name>
<email>amaury.pouly@gmail.com</email>
</author>
<published>2015-01-02T21:15:31+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=dc127f213c9b7e60f649bc236602e4f28285c53b'/>
<id>dc127f213c9b7e60f649bc236602e4f28285c53b</id>
<content type='text'>
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.

Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly &lt;amaury.pouly@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.

Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly &lt;amaury.pouly@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix broken buflib_handle check in backdrop settings loader</title>
<updated>2014-12-20T11:33:26+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-20T11:27:38+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055'/>
<id>1ff5fd4d6b8d954b4a110c1c97a2e917c9e31055</id>
<content type='text'>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The logic was messed up and always evaluated to true
if buflib_handle is non-zero.

Thanks to JdGordon for verifying the change.

cppcheck reported:
[rockbox/apps/gui/skin_engine/skin_backdrops.c:262]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Change-Id: Ib52a73e0a6a2017a631e2dec19b638a2974dab83
</pre>
</div>
</content>
</entry>
<entry>
<title>Correct some file permissions.</title>
<updated>2014-09-08T14:04:39+00:00</updated>
<author>
<name>Szymon Dziok</name>
<email>b0hoon@o2.pl</email>
</author>
<published>2014-09-08T14:04:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4c6939fc3dce2a72d53b68e8a71fc2ebf917d276'/>
<id>4c6939fc3dce2a72d53b68e8a71fc2ebf917d276</id>
<content type='text'>
Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4a092a19d6a9c66dfeb2777c9655aa4b19d11e16
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix up some more red</title>
<updated>2014-08-06T01:32:13+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2014-08-06T01:19:07+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=29f5385263367ada481cb91fb5f44b6c1f90c59c'/>
<id>29f5385263367ada481cb91fb5f44b6c1f90c59c</id>
<content type='text'>
find_first_set_bit() becomes a small inline on ARMv5+ and checkwps now gets
made with -std=gnu99 (it eats all the GCCOPTS) like the rest of things.

Change-Id: Ie6039b17fec057a3dcb0f453d8fd5efac984df89
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
find_first_set_bit() becomes a small inline on ARMv5+ and checkwps now gets
made with -std=gnu99 (it eats all the GCCOPTS) like the rest of things.

Change-Id: Ie6039b17fec057a3dcb0f453d8fd5efac984df89
</pre>
</div>
</content>
</entry>
<entry>
<title>add supports for x,y value in percentage to several tags.</title>
<updated>2014-07-21T02:54:53+00:00</updated>
<author>
<name>Chiwen Chang</name>
<email>rock1104.tw@yahoo.com.tw</email>
</author>
<published>2014-07-21T02:31:01+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce'/>
<id>9fb65294fb8bd9cfcf3e830f82bf01c3afdbbcce</id>
<content type='text'>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
including
BAR_PARAMS, %xl, %dr, %T,%St, %xl and %Cl

Change-Id: I0811ebfff5f83085481dcbf08f97b7223f677bfe
Reviewed-on: http://gerrit.rockbox.org/900
Reviewed-by: Jonathan Gordon &lt;rockbox@jdgordon.info&gt;
</pre>
</div>
</content>
</entry>
</feed>
