rockbox/apps/playback.c, branch duke3d

Get rid of useless playlist probing and fix up some data types.

2017-12-17T21:33:50+00:00

Playback checked the files' presence before attempting to buffer
the track. Just get rid of that and save an extra open/close call.
It will find out if the path is bad when the metadata fails.

Fix some size_t/off_t conflation. No need to update plugin version
because no plugin actually uses bufopen().

Change-Id: I3db112449dc0b2eeb91c546f308880ac82494fc7

Fix big WTF when closing the current track.

2017-12-16T03:39:46+00:00

It must be set to something else valid (unless it's the only one
left) when closing it, IN ALL CASES, not just if it's first or last.
Don't know what was in my head. Hopefully takes care of a reported
issue. Even if it's not causing any issues, it was still incorrect.

Change-Id: I594af8b35d774ec222dadce80dfa8b95138f037e

Get voice event out of playback.c

2017-12-13T01:28:56+00:00

Purpose: A step in removing all voice references from playback code
and prelude to other changes.

Change-Id: Ic3ad7f7a33b979693e18a3456ced37eb1d2281a4

Fix yellow on hosted targets from c1a01be

2017-12-09T22:34:33+00:00

Change-Id: I4c63efc6570368df76b6c4bbfb5b673dd081145b

Playback: Move internal track list onto buffer

2017-12-09T22:05:59+00:00

Does away the statically-allocated track list which frees quite
a fair amount of in-RAM size.

There's no compile-time hard track limit.

Recommended TODO (but not right away): Have data small enough use
the handle structure as its buffer data area. Almost the entire
handle structure is unused for simple allocations without any
associated filesystem path.

Change-Id: I74a4561e5a837e049811ac421722ec00dadc0d50

Ensure ci is properly updated if seeking before track load completes

2017-12-07T16:33:29+00:00

If in the middle of a manual skip, playback would try to seek, and
therefore start, the codec before the audio handle was available.
This wasn't really a problem since the codec would just bail out
and be retried later. But, it is a problem for a change I was working
on with seeking where the codec could get caught in a full-speed
loop trying to seek itself (stoppable, not lockup).

The main side effect of this change that you may notice, if using an
HDD with dircache turned on and the disk is not spinning, is that you
can keep holding down prev/next if dir skipping and the WPS will
start FF/RW mode. By the time the new track shows up, you will have
seeked into it some amount.

Well, the PBE is getting the info ASAP anyway and as far as it's
concerned, the next track is under way. On that end of things, it's
correct. Perhaps WPS should lock out its own seek mode at certain
times.

Change-Id: Ifc7409a886df399cec189d1bae2adba3872e857a

Playback: C99-ize FOREACH_ALBUMART; make loop counter local

2017-12-04T17:59:15+00:00

Change-Id: Ie6d571ef217246e22b465ef39097ad9d9d1a6436

Do playback restarts the proper way

2017-11-24T13:55:49+00:00

It isn't necessary to explicitly stop and restart playback to
force it to update something that must cause rebuffering.

Change-Id: I6ff5394fcafc7374af67ef9fbf9022bb4a79b773

Fix a problem with audio not starting on a list of short files

2017-04-06T23:32:35+00:00

Forced audio start was left out when a third codec attempts to
start a second track transition. Only one pending transition is
allowed at a time. There wouldn't be enough PCM in the buffer to
trigger audio playback and audio would just return without giving
the pcm buffer a kick.

Fixes FS#13100 - Player failed on short tracks

Change-Id: I338b0b12022c591930451fd5ed26a2a73008835f

Fix broken logf

2016-03-30T20:48:17+00:00