<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/plugins/mikmod, branch puzzles</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>mikmod plugin: Remove bogus doubled return statement</title>
<updated>2014-12-22T21:33:28+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-22T21:33:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=b681e932a9da797249ddc0e4ccab7ed7cf50fd41'/>
<id>b681e932a9da797249ddc0e4ccab7ed7cf50fd41</id>
<content type='text'>
Stick to the safer version of those two.

Tested mikmod still works with some nice Necros .s3m files.

Change-Id: I6774cdf3345a4c89b2f9cf3bb8d832963ca30c38
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Stick to the safer version of those two.

Tested mikmod still works with some nice Necros .s3m files.

Change-Id: I6774cdf3345a4c89b2f9cf3bb8d832963ca30c38
</pre>
</div>
</content>
</entry>
<entry>
<title>Prevent theoretical out-of-bounds access in STM_Load()</title>
<updated>2014-12-20T12:37:40+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-20T12:37:40+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c54537a6639bc9ea495fac5e9ecb3ee7a699b484'/>
<id>c54537a6639bc9ea495fac5e9ecb3ee7a699b484</id>
<content type='text'>
We should be safe since STM_Load() should
never be called if STM_Test() fails.
Still it's better safe than sorry.

cppcheck reported:
[rockbox/apps/plugins/mikmod/load_stm.c:302]: (error) Array 'STM_Version[3]' accessed at index 3, which is out of bounds.

Change-Id: I914935fd108c492d013de24d17dcb9c227af6cd8
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We should be safe since STM_Load() should
never be called if STM_Test() fails.
Still it's better safe than sorry.

cppcheck reported:
[rockbox/apps/plugins/mikmod/load_stm.c:302]: (error) Array 'STM_Version[3]' accessed at index 3, which is out of bounds.

Change-Id: I914935fd108c492d013de24d17dcb9c227af6cd8
</pre>
</div>
</content>
</entry>
<entry>
<title>Deprecate the EXTRA_LIBS variable.</title>
<updated>2013-01-24T15:06:45+00:00</updated>
<author>
<name>Björn Stenberg</name>
<email>bjorn@haxx.se</email>
</author>
<published>2013-01-24T15:01:28+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1501df045f75b1ee607b49ce2f970c762a2538a4'/>
<id>1501df045f75b1ee607b49ce2f970c762a2538a4</id>
<content type='text'>
Instead specify explicit library dependencies for codecs and plugins.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead specify explicit library dependencies for codecs and plugins.
</pre>
</div>
</content>
</entry>
<entry>
<title>mikmod plugin: make functions static when possible</title>
<updated>2012-04-14T15:31:14+00:00</updated>
<author>
<name>Bertrik Sikken</name>
<email>bertrik@sikken.nl</email>
</author>
<published>2012-03-04T19:13:43+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c26ab37aca59da2fde7d96ab8528ac2b002a8192'/>
<id>c26ab37aca59da2fde7d96ab8528ac2b002a8192</id>
<content type='text'>
Change-Id: Ic0102071318c55c19952029be6998ecf5f33eb98
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ic0102071318c55c19952029be6998ecf5f33eb98
</pre>
</div>
</content>
</entry>
<entry>
<title>tlsf: move to /lib (it's also used by plugins).</title>
<updated>2012-03-28T21:02:39+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2012-03-27T14:27:02+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c56950ea3a9e0244461ce445f25bd7a80c8f7199'/>
<id>c56950ea3a9e0244461ce445f25bd7a80c8f7199</id>
<content type='text'>
Change-Id: I5e37b28c1ce4608d60b036343f280af3311ad490
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I5e37b28c1ce4608d60b036343f280af3311ad490
</pre>
</div>
</content>
</entry>
<entry>
<title>build system: unify/simplify library handling a bit.</title>
<updated>2012-03-26T20:27:40+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2012-03-26T20:24:57+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=f269aa0060950f7b9c42216267c639a2fb556196'/>
<id>f269aa0060950f7b9c42216267c639a2fb556196</id>
<content type='text'>
libs in $ROOT/lib now add to $(CORE_LIBS) and $(EXTRA_LIBS) and are
automatically linked by the core and codecs/plugins respectively.

Change-Id: Iff482c792a8c8142718f6a16a450c6e2f1497c9a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
libs in $ROOT/lib now add to $(CORE_LIBS) and $(EXTRA_LIBS) and are
automatically linked by the core and codecs/plugins respectively.

Change-Id: Iff482c792a8c8142718f6a16a450c6e2f1497c9a
</pre>
</div>
</content>
</entry>
<entry>
<title>Revise the PCM callback system after adding multichannel audio.</title>
<updated>2012-03-03T06:23:38+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2012-02-23T13:14:46+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=286a4c5caa1945c8d1cb365a3d90fb09d5700cb2'/>
<id>286a4c5caa1945c8d1cb365a3d90fb09d5700cb2</id>
<content type='text'>
Additional status callback is added to pcm_play/rec_data instead of
using a special function to set it. Status includes DMA error
reporting to the status callback. Playback and recording callback
become more alike except playback uses "const void **addr" (because
the data should not be altered) and recording  uses "void **addr".
"const" is put in place throughout where appropriate.

Most changes are fairly trivial. One that should be checked in
particular because it isn't so much is telechips, if anyone cares to
bother. PP5002 is not so trivial either but that tested as working.

Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2
Reviewed-on: http://gerrit.rockbox.org/166
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Additional status callback is added to pcm_play/rec_data instead of
using a special function to set it. Status includes DMA error
reporting to the status callback. Playback and recording callback
become more alike except playback uses "const void **addr" (because
the data should not be altered) and recording  uses "void **addr".
"const" is put in place throughout where appropriate.

Most changes are fairly trivial. One that should be checked in
particular because it isn't so much is telechips, if anyone cares to
bother. PP5002 is not so trivial either but that tested as working.

Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2
Reviewed-on: http://gerrit.rockbox.org/166
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>FS#12273 - use buflib for font storage. thanks to the testers :)</title>
<updated>2011-09-24T13:19:34+00:00</updated>
<author>
<name>Jonathan Gordon</name>
<email>rockbox@jdgordon.info</email>
</author>
<published>2011-09-24T13:19:34+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=aa0f4a4bbe370032d8166628f456709be1330118'/>
<id>aa0f4a4bbe370032d8166628f456709be1330118</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30589 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30589 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>mikmod: enable compiler optimizations for coldfire, they were disabled to work around a bug in the old toolchain.</title>
<updated>2011-09-04T08:32:02+00:00</updated>
<author>
<name>Nils Wallménius</name>
<email>nils@rockbox.org</email>
</author>
<published>2011-09-04T08:32:02+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=060b3fa4f12b3325f29ff8303e22dd318632bd87'/>
<id>060b3fa4f12b3325f29ff8303e22dd318632bd87</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30427 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30427 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove several 'set but not used' GCC 4.6.1 warnings from MikMod.</title>
<updated>2011-09-03T23:54:43+00:00</updated>
<author>
<name>Andree Buschmann</name>
<email>AndreeBuschmann@t-online.de</email>
</author>
<published>2011-09-03T23:54:43+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=6cb5ec1bfef3ca621a1de8e3f7dda0f333407961'/>
<id>6cb5ec1bfef3ca621a1de8e3f7dda0f333407961</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30426 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30426 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
</feed>
