<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/plugins/pdbox/PDa/src, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>pdbox: fix bug shown by new gcc warning</title>
<updated>2016-10-12T14:52:49+00:00</updated>
<author>
<name>Frank Gevaerts</name>
<email>frank@gevaerts.be</email>
</author>
<published>2016-10-12T14:52:49+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2a2800b528010320ca504a39106806ec21f02203'/>
<id>2a2800b528010320ca504a39106806ec21f02203</id>
<content type='text'>
Change-Id: Ife308a3090f9bc62f2e98d2d979fdf393c22054d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ife308a3090f9bc62f2e98d2d979fdf393c22054d
</pre>
</div>
</content>
</entry>
<entry>
<title>Make thirty functions static to reduce binary size</title>
<updated>2015-01-05T17:44:36+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-05T17:44:36+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=fdd4aef34003587d7fd9ed754dd35ce901b639bf'/>
<id>fdd4aef34003587d7fd9ed754dd35ce901b639bf</id>
<content type='text'>
If any of those functions should be (unused) API functions,
they can easily be turned back once really needed.

Detected using a new cppcheck check that
uses the internal symbol database to catch
functions that are only used in the current file.

Change-Id: Ic2b1e5b8020b76397f11cefc4e205f3b7ac1f184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If any of those functions should be (unused) API functions,
they can easily be turned back once really needed.

Detected using a new cppcheck check that
uses the internal symbol database to catch
functions that are only used in the current file.

Change-Id: Ic2b1e5b8020b76397f11cefc4e205f3b7ac1f184
</pre>
</div>
</content>
</entry>
<entry>
<title>pdbox: Always use fixedpoint version of math functions</title>
<updated>2012-10-07T13:04:24+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2012-10-07T13:04:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=71778bd21ee57d105a58fa93d7a295c5dc0e3b5c'/>
<id>71778bd21ee57d105a58fa93d7a295c5dc0e3b5c</id>
<content type='text'>
Change-Id: Ie5671d8f425804c9cf3265bad86eadadaf73ea1c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ie5671d8f425804c9cf3265bad86eadadaf73ea1c
</pre>
</div>
</content>
</entry>
<entry>
<title>Revise the PCM callback system after adding multichannel audio.</title>
<updated>2012-03-03T06:23:38+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2012-02-23T13:14:46+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=286a4c5caa1945c8d1cb365a3d90fb09d5700cb2'/>
<id>286a4c5caa1945c8d1cb365a3d90fb09d5700cb2</id>
<content type='text'>
Additional status callback is added to pcm_play/rec_data instead of
using a special function to set it. Status includes DMA error
reporting to the status callback. Playback and recording callback
become more alike except playback uses "const void **addr" (because
the data should not be altered) and recording  uses "void **addr".
"const" is put in place throughout where appropriate.

Most changes are fairly trivial. One that should be checked in
particular because it isn't so much is telechips, if anyone cares to
bother. PP5002 is not so trivial either but that tested as working.

Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2
Reviewed-on: http://gerrit.rockbox.org/166
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Additional status callback is added to pcm_play/rec_data instead of
using a special function to set it. Status includes DMA error
reporting to the status callback. Playback and recording callback
become more alike except playback uses "const void **addr" (because
the data should not be altered) and recording  uses "void **addr".
"const" is put in place throughout where appropriate.

Most changes are fairly trivial. One that should be checked in
particular because it isn't so much is telechips, if anyone cares to
bother. PP5002 is not so trivial either but that tested as working.

Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2
Reviewed-on: http://gerrit.rockbox.org/166
Reviewed-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
Tested-by: Michael Sevakis &lt;jethead71@rockbox.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix wrong pointer arithmetic in the PDbox aiff header writing code</title>
<updated>2012-01-22T20:41:38+00:00</updated>
<author>
<name>Frank Gevaerts</name>
<email>frank@gevaerts.be</email>
</author>
<published>2012-01-22T20:35:23+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=7efbd632c2ee76e6868635ecfa09ea96b25c3a63'/>
<id>7efbd632c2ee76e6868635ecfa09ea96b25c3a63</id>
<content type='text'>
The SSND bit is intended to be right after the t_aiff-sized header.
Someone got cast vs + precedence rules wrong here.

Change-Id: Iccec75043ed5e35724331f9833b24f7e3b90c447
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The SSND bit is intended to be right after the t_aiff-sized header.
Someone got cast vs + precedence rules wrong here.

Change-Id: Iccec75043ed5e35724331f9833b24f7e3b90c447
</pre>
</div>
</content>
</entry>
<entry>
<title>Committing fix for FS#12249. Patch by Buschel. Further fixes for AIFF loader in PDBox in the future.</title>
<updated>2011-11-08T23:48:24+00:00</updated>
<author>
<name>Wincent Balin</name>
<email>wincent@rockbox.org</email>
</author>
<published>2011-11-08T23:48:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d01954cad2a8b6de0faadec599a24bac14350043'/>
<id>d01954cad2a8b6de0faadec599a24bac14350043</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30944 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30944 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix last known 'set but not used' warning by GCC 4.6.1.</title>
<updated>2011-05-13T19:40:17+00:00</updated>
<author>
<name>Andree Buschmann</name>
<email>AndreeBuschmann@t-online.de</email>
</author>
<published>2011-05-13T19:40:17+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=0a070c54202d946b37946343ea2f083fee82871a'/>
<id>0a070c54202d946b37946343ea2f083fee82871a</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29875 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29875 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix even more 'set but not used' warnings and a regression.</title>
<updated>2011-05-13T19:23:27+00:00</updated>
<author>
<name>Andree Buschmann</name>
<email>AndreeBuschmann@t-online.de</email>
</author>
<published>2011-05-13T19:23:27+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2aa0759077ce43b75470eae5be32c102aeea12ce'/>
<id>2aa0759077ce43b75470eae5be32c102aeea12ce</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29873 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29873 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix further 'set but not used' warnings.</title>
<updated>2011-05-13T19:06:04+00:00</updated>
<author>
<name>Andree Buschmann</name>
<email>AndreeBuschmann@t-online.de</email>
</author>
<published>2011-05-13T19:06:04+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4f4edd89e42a50539a140f6290aefd425720e469'/>
<id>4f4edd89e42a50539a140f6290aefd425720e469</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29872 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29872 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix several 'variable set but not used' warnings reported by GCC 6.4.1.</title>
<updated>2011-05-13T18:47:42+00:00</updated>
<author>
<name>Andree Buschmann</name>
<email>AndreeBuschmann@t-online.de</email>
</author>
<published>2011-05-13T18:47:42+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=f7808c1fe5578e0d789fe7d9181e3502482507b8'/>
<id>f7808c1fe5578e0d789fe7d9181e3502482507b8</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
</feed>
