<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/apps/plugins/text_viewer/tv_text_reader.h, branch duke3d</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>FS#11399 by me: fix r26998 for text_viewer</title>
<updated>2010-06-23T13:56:08+00:00</updated>
<author>
<name>Rafaël Carré</name>
<email>rafael.carre@gmail.com</email>
</author>
<published>2010-06-23T13:56:08+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=59fd2b24bd7ad8ff0c18f66ffbf83f7ceefa9d55'/>
<id>59fd2b24bd7ad8ff0c18f66ffbf83f7ceefa9d55</id>
<content type='text'>
Restore the old behaviour:

- preferences must be read-write for tv_preferences.c , read-only for
  all other modules -&gt; use pointer to const struct
- init functions must get the plugin buffer + its size as arguments for
  easily adding new functions -&gt; use pointer to buffer pointer and size
  to make allocation easier
- preferences meaning is private to each file and must not be known by
  tv_preferences.c -&gt; move tv_check_header_and_footer() back in
  tv_window.c; also avoid chaining 3 times the callbacks by calling
  tv_set_preferences() only once if more than one preference needs
  changing

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27089 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Restore the old behaviour:

- preferences must be read-write for tv_preferences.c , read-only for
  all other modules -&gt; use pointer to const struct
- init functions must get the plugin buffer + its size as arguments for
  easily adding new functions -&gt; use pointer to buffer pointer and size
  to make allocation easier
- preferences meaning is private to each file and must not be known by
  tv_preferences.c -&gt; move tv_check_header_and_footer() back in
  tv_window.c; also avoid chaining 3 times the callbacks by calling
  tv_set_preferences() only once if more than one preference needs
  changing

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27089 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>text_viewer: cleanup &amp; bugfix</title>
<updated>2010-06-20T21:53:47+00:00</updated>
<author>
<name>Rafaël Carré</name>
<email>rafael.carre@gmail.com</email>
</author>
<published>2010-06-20T21:53:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=298316d19297eea82869b63235b535e5904fc0dd'/>
<id>298316d19297eea82869b63235b535e5904fc0dd</id>
<content type='text'>
cleanup:
    - don't use enum in struct / return values
    - don't use a getter for preferences but a global pointer
    - explicitely make enums start at 0
    - use static tables for header/footer settings
    - remove unneeded memset before strlcpy
    - use static buffer allocation, not dynamic
    - check header/footer preferences before using the callbacks
    - don't include font filename in archos player preferences (break
      file format)

bugfix:
    - statically allocate old preferences in tv_set_preferences()

Sometimes I can read a file on Clipv2, but it still aborts quite often
refs: FS#11399

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26998 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
cleanup:
    - don't use enum in struct / return values
    - don't use a getter for preferences but a global pointer
    - explicitely make enums start at 0
    - use static tables for header/footer settings
    - remove unneeded memset before strlcpy
    - use static buffer allocation, not dynamic
    - check header/footer preferences before using the callbacks
    - don't include font filename in archos player preferences (break
      file format)

bugfix:
    - statically allocate old preferences in tv_set_preferences()

Sometimes I can read a file on Clipv2, but it still aborts quite often
refs: FS#11399

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26998 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>reworks text viewer plugin. (FS#11209)</title>
<updated>2010-06-05T10:30:08+00:00</updated>
<author>
<name>Yoshihisa Uchida</name>
<email>uchida@rockbox.org</email>
</author>
<published>2010-06-05T10:30:08+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=fdba8404503af0448586615330a7b27f2ced531c'/>
<id>fdba8404503af0448586615330a7b27f2ced531c</id>
<content type='text'>
new text viewer plugin: text_viewer.rock.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26571 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
new text viewer plugin: text_viewer.rock.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26571 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
</feed>
