rockbox/apps/screen_access.h, branch puzzles My Rockbox tree put_line/scrolling: Make the scroll engine inform custom scrollers about start/stop of scrolling. 2014-01-12T00:34:06+00:00 Thomas Martitz kugel@rockbox.org 2014-01-12T00:30:26+00:00 488a1b983e1c2fac14de25aa781caf12628e53c8 With the new lcd_putsxy_scroll_func() code can register custom scroll functions (put_line() makes use of that). In order for the custom scroller to be able to properly manage its userdata pointer (set via struct scrollinfo::userdata) the scroll engine must inform the scroller about start and stop of scrolling. To inform about start the lcd_scroll_* functions now return true when the line will scroll. To inform about stop the scroll engine calls into the scroller one last time, with the text set to NULL. put_line() can use this to release the userdata registered per scrolling line so that it can be recycled. This fixes that some scrolling lines became glitchy after some time because the userdata was recycled too early. Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9 
With the new lcd_putsxy_scroll_func() code can register custom scroll functions
(put_line() makes use of that). In order for the custom scroller to be able
to properly manage its userdata pointer (set via struct scrollinfo::userdata)
the scroll engine must inform the scroller about start and stop of scrolling.

To inform about start the lcd_scroll_* functions now return true when
the line will scroll. To inform about stop the scroll engine calls into the
scroller one last time, with the text set to NULL.

put_line() can use this to release the userdata registered per scrolling line
so that it can be recycled.

This fixes that some scrolling lines became glitchy after some time because
the userdata was recycled too early.

Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9
lcd-16bit: Remove {lss,lse,lst}_pattern fields from struct viewport. 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-30T05:41:05+00:00 e1c7b3b8f72becc9079c04253a2985f577850a48 These where used for line styling during scrolling, which is now done in apps/, The viewport struct doesn't need to record these anymore. Change-Id: I810d9dcb2644b00a798c6e75acab69c74a78e77f 
These where used for line styling during scrolling, which is now done in apps/,
The  viewport struct doesn't need to record these anymore.

Change-Id: I810d9dcb2644b00a798c6e75acab69c74a78e77f
lcd-common/scroll_engine: Remove unused functions lcd_puts_style_xyoffset() and lcd_puts_scroll_style_xyoffset(). 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-14T16:15:09+00:00 9a4686b563ac9e27615e1032792bd9878bb291f7 With this functions removed there is no exported function in firmware left that draws line decorations. Also no function supports specifying an y-offset anymore (was used for pixel accurate positioning of otherwise strictly line-based API calls). Both should be handled in apps/ now. Change-Id: Iba4b28ccc6e686c7db63e34b51ad4badae983fce 
With this functions removed there is no exported function in firmware left
that draws line decorations. Also no function supports specifying an y-offset
anymore (was used for pixel accurate positioning of otherwise strictly line-based
API calls).

Both should be handled in apps/ now.

Change-Id: Iba4b28ccc6e686c7db63e34b51ad4badae983fce
lcd-common/scroll_engine: Remove unused functions lcd_puts_scroll_style(). 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-14T16:13:12+00:00 775ebe4ff6508d13712beb6bc18e546adb39f47d Change-Id: Ia4f943b3738ab6e66b0e3f1507c629b36d7eba94 
Change-Id: Ia4f943b3738ab6e66b0e3f1507c629b36d7eba94
lcd-common: Remove unused function lcd_puts_style_offset(). 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-13T16:20:42+00:00 7cd07290e6fc21ab8b2b6d438d7a6b24b3708e35 Change-Id: I24da23d132f933fe647416dc58e8f50879715423 
Change-Id: I24da23d132f933fe647416dc58e8f50879715423
lcd-common: Remove unused function lcd_puts_offset(). 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-13T16:17:16+00:00 8f64625888965d7eed46101fad8fc7fbd9e30f03 Change-Id: I39749bf3db915e5a8ddb6e6f25eb201ea0aaf981 
Change-Id: I39749bf3db915e5a8ddb6e6f25eb201ea0aaf981
lcd-common/scroll_engine: Remove unused functions lcd_puts_scroll_offset() and lcd_puts_scroll_style_offset(). 2014-01-07T13:13:48+00:00 Thomas Martitz kugel@rockbox.org 2013-04-11T10:07:06+00:00 a422604435bbb92b6d69552e347c8fa56c0830a2 Change-Id: Ia84ae88020d06a1cb634942ab5e635fd5d10ac66 
Change-Id: Ia84ae88020d06a1cb634942ab5e635fd5d10ac66
Introduce put_line(). 2014-01-07T13:13:17+00:00 Thomas Martitz kugel@rockbox.org 2013-12-20T22:34:28+00:00 5d6974641b14ef81396e8deebcc65a87c07334e5 This function is a fully-fletched, high-level pixel-based line printer, that combines functionality of several firmware and list functions. It can draw spacing, icons and text in a single call, in any order and each multiple times. It can also apply line decorations at the same time. It features printf-like semantics by accepting a format string that contain format tags as well as inline text. It's accessible directly, but also through the multi-screen api for plugins. Change-Id: I70f5a77bbf4b0252521f2e47ead377b9d6d29b54 
This function is a fully-fletched, high-level pixel-based line printer, that
combines functionality of several firmware and list functions. It can
draw spacing, icons and text in a single call, in any order and each multiple
times. It can also apply line decorations at the same time.

It features printf-like semantics by accepting a format string that contain
format tags as well as inline text.

It's accessible directly, but also through the multi-screen api for plugins.

Change-Id: I70f5a77bbf4b0252521f2e47ead377b9d6d29b54
lcd-charcell: Add set_drawmode() wrapper to multi-screen API. 2014-01-07T10:36:00+00:00 Thomas Martitz kugel@rockbox.org 2013-12-20T22:34:28+00:00 acee675a5e67635e812a2d325a0f450d3409d53a Change-Id: Idb6477aca8b19cb346ba2c2f5b91074e4679b0dd 
Change-Id: Idb6477aca8b19cb346ba2c2f5b91074e4679b0dd
lcd-16bit: Introduce lcd_gradient_fillrect_part(). 2014-01-07T10:36:00+00:00 Thomas Martitz kugel@rockbox.org 2013-12-20T22:34:28+00:00 77836e57362f91cd037ea9c97a8fda00187d2070 It is similar to lcd_gradient_fillrect(), except that it only draws a part of the complete gradient. This can be used to draw only the bottom half of a full gradient. Change-Id: Ib47cc5237f6966e35ba07988bddbb00fd97adf96 
It is similar to lcd_gradient_fillrect(), except that it only draws a part
of the complete gradient. This can be used to draw only the bottom half
of a full gradient.

Change-Id: Ib47cc5237f6966e35ba07988bddbb00fd97adf96