rockbox/firmware/drivers/lcd-bitmap-common.c, branch working

put_line/scrolling: Make the scroll engine inform custom scrollers about start/stop of scrolling.

2014-01-12T00:34:06+00:00

With the new lcd_putsxy_scroll_func() code can register custom scroll functions
(put_line() makes use of that). In order for the custom scroller to be able
to properly manage its userdata pointer (set via struct scrollinfo::userdata)
the scroll engine must inform the scroller about start and stop of scrolling.

To inform about start the lcd_scroll_* functions now return true when
the line will scroll. To inform about stop the scroll engine calls into the
scroller one last time, with the text set to NULL.

put_line() can use this to release the userdata registered per scrolling line
so that it can be recycled.

This fixes that some scrolling lines became glitchy after some time because
the userdata was recycled too early.

Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9

scroll engine: Factor out renderer function so it can be called by lcd code.

2014-01-11T18:17:58+00:00

This is used by lcd_puts_scroll_worker() to render the line immediately
instead of waiting for the next scroll tick when only the text was updated.
Previously lcd_puts_scroll_worker() did not render anything in this case
which could lead to visible blinking.

This fixes blinking scrolling lines with dynamic text in the skin engine.

Change-Id: I475bde8c8eb7c92f505e3c5ecf4d32bb90690536

lcd_nine_segment_bmp: Fixes for non-ideal image dimensions.

2014-01-08T23:43:46+00:00

1) The 9-segment images need not be multiple of 3 pixels anymore. If it
isn't the inner segments will be smaller than the corners.

2) If the desired actual images is not a multiple of the segment sizes the
function drawed more than the desired rectangle. This is fixed by
drawing the last segment only partially.

Change-Id: Ic918facd8734fa4a4aa72536f0b67de82d81651e

lcd-16bit: Move lcd_gradient_fillrect/_part() to lcd-16bit-common.c.

2014-01-07T13:13:48+00:00

Change-Id: I6b2d2ba73464610556cfd9ecec52fc62adb007c7

lcd-common: Remove direct style (line decorations) from lcd-puts* functions.

2014-01-07T13:13:48+00:00

This logic is moved into apps (put_line()) which can better handle line
decorations with respect to scrolling, mulitline and other complications.

Firmware doesn't need this. The remaining drawing function know only one style,
that is foreground on background/backdrop (changing drawmode is still supported).

Change-Id: I707060edc388a7d723a7d09b0cf5cbda6ec56708

lcd-common: Remove support for specifying y_offset from lcd_puts* functions.

2014-01-07T13:13:48+00:00

This main (and only) purpose for it was to adjust the pixel position of the text
in otherwise linebased (scrolling) functions. With pixel-based scrolling
this isnt necessary anymore.

Change-Id: I2a45b8ca6a3f8f50aa2f6630201b30ce9ddfe043

lcd-common: Remove support for custom line heights from viewport.

2014-01-07T13:13:48+00:00

Since scrolling is now pixel-based this is not necessary anymore. custom line
height is handled by put_line() but can also possible to implement with
lcd_puts_scroll_func().

Change-Id: Iee9b12bf99afac93d95d2a1a6f5d5b4db237b21c

lcd-common/scroll_engine: Remove unused functions lcd_puts_style_xyoffset() and lcd_puts_scroll_style_xyoffset().

2014-01-07T13:13:48+00:00

With this functions removed there is no exported function in firmware left
that draws line decorations. Also no function supports specifying an y-offset
anymore (was used for pixel accurate positioning of otherwise strictly line-based
API calls).

Both should be handled in apps/ now.

Change-Id: Iba4b28ccc6e686c7db63e34b51ad4badae983fce

lcd-common/scroll_engine: Remove unused functions lcd_puts_scroll_style().

2014-01-07T13:13:48+00:00

Change-Id: Ia4f943b3738ab6e66b0e3f1507c629b36d7eba94

lcd-common: Remove unused function lcd_puts_style_offset().

2014-01-07T13:13:48+00:00

Change-Id: I24da23d132f933fe647416dc58e8f50879715423