rockbox/firmware/drivers/lcd-scroll.c, branch master My Rockbox tree put_line/scrolling: Make the scroll engine inform custom scrollers about start/stop of scrolling. 2014-01-12T00:34:06+00:00 Thomas Martitz kugel@rockbox.org 2014-01-12T00:30:26+00:00 488a1b983e1c2fac14de25aa781caf12628e53c8 With the new lcd_putsxy_scroll_func() code can register custom scroll functions (put_line() makes use of that). In order for the custom scroller to be able to properly manage its userdata pointer (set via struct scrollinfo::userdata) the scroll engine must inform the scroller about start and stop of scrolling. To inform about start the lcd_scroll_* functions now return true when the line will scroll. To inform about stop the scroll engine calls into the scroller one last time, with the text set to NULL. put_line() can use this to release the userdata registered per scrolling line so that it can be recycled. This fixes that some scrolling lines became glitchy after some time because the userdata was recycled too early. Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9 
With the new lcd_putsxy_scroll_func() code can register custom scroll functions
(put_line() makes use of that). In order for the custom scroller to be able
to properly manage its userdata pointer (set via struct scrollinfo::userdata)
the scroll engine must inform the scroller about start and stop of scrolling.

To inform about start the lcd_scroll_* functions now return true when
the line will scroll. To inform about stop the scroll engine calls into the
scroller one last time, with the text set to NULL.

put_line() can use this to release the userdata registered per scrolling line
so that it can be recycled.

This fixes that some scrolling lines became glitchy after some time because
the userdata was recycled too early.

Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9
scroll engine: Factor out renderer function so it can be called by lcd code. 2014-01-11T18:17:58+00:00 Thomas Martitz kugel@rockbox.org 2014-01-11T18:17:58+00:00 26b317e094a37c43d23e661cf99fe858c159f1b2 This is used by lcd_puts_scroll_worker() to render the line immediately instead of waiting for the next scroll tick when only the text was updated. Previously lcd_puts_scroll_worker() did not render anything in this case which could lead to visible blinking. This fixes blinking scrolling lines with dynamic text in the skin engine. Change-Id: I475bde8c8eb7c92f505e3c5ecf4d32bb90690536 
This is used by lcd_puts_scroll_worker() to render the line immediately
instead of waiting for the next scroll tick when only the text was updated.
Previously lcd_puts_scroll_worker() did not render anything in this case
which could lead to visible blinking.

This fixes blinking scrolling lines with dynamic text in the skin engine.

Change-Id: I475bde8c8eb7c92f505e3c5ecf4d32bb90690536
Fix reds. Also apply the new scrolling to lcd charcell (this even uncovered an 2013-12-14T23:38:48+00:00 Thomas Martitz kugel@rockbox.org 2013-12-14T23:38:48+00:00 c72b454286864d728de676ebdf92288dd04ace45 error). Change-Id: I29243bb36b6cec1471bd6c0afc64e00547a68c50 
error).

Change-Id: I29243bb36b6cec1471bd6c0afc64e00547a68c50
scroll_engine: Major rework to support pixel-based scrolling and scroll callbacks. 2013-12-14T22:11:31+00:00 Thomas Martitz kugel@rockbox.org 2013-01-31T06:24:19+00:00 50eb528bc1f9d2f7b7260eff8b85a5ed5b96e679 Much of the scrolling work is moved from lcd-bitmap-common to lcd-scroll.c, a small scroll callback routine remains. This callback can potentially be overridden by more extensive scrollers. The callback also gets fed with pixel-based scrolling information, which finally removes the strict line-based nature of the scroll engine. Along with this is the change from scroll_stop_viewport_line() to scroll_stop_viewport_rect() which works on a pixel-based rectangle instead of lines. The ultimate goal is to move most of the scroll work to apps, which can much better decide which line decorations to apply etc. This work is laying the ground work. Change-Id: I3b2885cf7d8696ddd9253d5a9a73318d3d42831a 
Much of the scrolling work is moved from lcd-bitmap-common to lcd-scroll.c,
a small scroll callback routine remains. This callback can potentially be
overridden by more extensive scrollers.

The callback also gets fed with pixel-based scrolling information, which
finally removes the strict line-based nature of the scroll engine. Along with
this is the change from scroll_stop_viewport_line() to scroll_stop_viewport_rect()
which works on a pixel-based rectangle instead of lines.

The ultimate goal is to move most of the scroll work to apps, which can
much better decide which line decorations to apply etc. This work is laying
the ground work.

Change-Id: I3b2885cf7d8696ddd9253d5a9a73318d3d42831a
scroll_engine: Split out common main and remote lcd functions. 2013-12-14T22:11:30+00:00 Thomas Martitz kugel@rockbox.org 2013-04-04T05:12:10+00:00 b094d80dab4f7ac501172d0412e9e53289ede27b Uses a similar technique as lcd_*.c files of #including a common .c file, so that a unified implementation can be reused for both displays. Change-Id: I21f6de76df757b093e1a1dff0a4caf96a44fe77e 
Uses a similar technique as lcd_*.c files of #including a common .c file, so
that a unified implementation can be reused for both displays.

Change-Id: I21f6de76df757b093e1a1dff0a4caf96a44fe77e