rockbox/firmware/include, branch puzzlesmanual My Rockbox tree Do some housekeeping with fat.h and SECTOR_SIZE 2017-03-13T02:05:44+00:00 Michael Sevakis jethead71@rockbox.org 2017-03-13T02:05:44+00:00 6db80020b45ae22b19524b01f60d0653d70ac7ca Many includes of fat.h are pointless. Some includes are just for SECTOR_SIZE. Add a file 'firmware/include/fs_defines.h' for that and to define tuneable values that were scattered amongst various headers. Remove some local definitions of SECTOR_SIZE since they have to be in agreement with the rest of the fs code anyway. (We'll see what's in fact pointless in a moment ;) Change-Id: I9ba183bf58bd87f5c45eba7bd675c7e2c1c18ed5 
Many includes of fat.h are pointless. Some includes are just for
SECTOR_SIZE. Add a file 'firmware/include/fs_defines.h' for that
and to define tuneable values that were scattered amongst various
headers.

Remove some local definitions of SECTOR_SIZE since they have to be
in agreement with the rest of the fs code anyway.

(We'll see what's in fact pointless in a moment ;)

Change-Id: I9ba183bf58bd87f5c45eba7bd675c7e2c1c18ed5
Dircache: Refine name allocation and error handling. 2017-03-13T01:09:16+00:00 Michael Sevakis jethead71@rockbox.org 2017-03-13T00:59:44+00:00 70c929179b80e0657e31558e34d2bc62e1176564 * 8 bits is enough to allow 260 character base names when five bytes is the minimum indirect storage size (0..255->5..260). * Don't truncate anything that's too long as that can lead to bad behavior, simply don't include the offending entry in the parent. * Set the .tinyname flag to 1 by default to indicate that the entry's name doesn't need freeing. Clear it only when allocating indirect storage. * Rename some things to help catch all instances Change-Id: Iff747b624acbb8e03ed26c24afdf0fc715fd9d99 
* 8 bits is enough to allow 260 character base names when five
bytes is the minimum indirect storage size (0..255->5..260).

* Don't truncate anything that's too long as that can lead to
bad behavior, simply don't include the offending entry in the
parent.

* Set the .tinyname flag to 1 by default to indicate that
the entry's name doesn't need freeing. Clear it only when
allocating indirect storage.

* Rename some things to help catch all instances

Change-Id: Iff747b624acbb8e03ed26c24afdf0fc715fd9d99
Remove FF_CREAT and FF_EXCL flags in from file code. 2017-02-14T22:54:50+00:00 Michael Sevakis jethead71@rockbox.org 2017-02-13T02:56:44+00:00 8ff1b6b6033aad55fadf076f066da5d8b7d2e631 These flags aren't stored for an open file because they're simply actions for open() to take, corresponding to O_CREAT and O_EXCL. Just pass the oflag argument along to the deeper call, with some minor filtering. Change-Id: Ic8bcfba718ebf4228bdc45de3088af1974820557 
These flags aren't stored for an open file because they're simply
actions for open() to take, corresponding to O_CREAT and O_EXCL.
Just pass the oflag argument along to the deeper call, with some
minor filtering.

Change-Id: Ic8bcfba718ebf4228bdc45de3088af1974820557
Restore dircache hookup in the database ramcache. 2017-02-10T10:05:23+00:00 Michael Sevakis jethead71@rockbox.org 2017-01-18T09:39:35+00:00 7373cf518f4d4c47f49693690c2ab8ec29bb8510 Do a few other changes to dircache and file code flags to accomodate its demands. Change-Id: I4742a54e8cfbe4d8b9cffb75faaf920dd907cf8a 
Do a few other changes to dircache and file code flags to
accomodate its demands.

Change-Id: I4742a54e8cfbe4d8b9cffb75faaf920dd907cf8a
Do some debug and preparatory work for ramcache and playlist 2017-01-17T19:35:36+00:00 Michael Sevakis jethead71@rockbox.org 2017-01-08T22:14:10+00:00 a931c76b3a46d1884e985a3bfc82b947521dab97 The file system rework introduced incompatibility between dircache and the tagcache ramcache and playlist dircache path caching. This update makes changes to filesystem code to reintegrate all that. It also fixes a couple bugs that were found when vetting all the code. The filestream cache was being reset without regard to the stream even if it was shared in write mode (made work of .playlist_control). Better handling of unmounting gives files a better go at force-closing them without risk to disk integrity. Did some miscellaneous pedantic changes. Improved efficiency of testing a file's existence (a little) since the path parser will be shared between file code and parsing for the sake of finding dircache references, not duplicated as before. This commit doesn't reenable said items just for the sake of keeping changes separate and related. Plan for the next is to enable dircache again for the playlists (easy peasy) and reenable tagcache ramcache but *without* the dircache path caching because it's rather substantial to change in itself. The ramcache will still function without dircache. Change-Id: I7e2a9910b866251fa8333e1275f72fcfc8425d2d 
The file system rework introduced incompatibility between dircache
and the tagcache ramcache and playlist dircache path caching. This
update makes changes to filesystem code to reintegrate all that.

It also fixes a couple bugs that were found when vetting all the
code. The filestream cache was being reset without regard to
the stream even if it was shared in write mode (made work of
.playlist_control). Better handling of unmounting gives files a
better go at force-closing them without risk to disk integrity.

Did some miscellaneous pedantic changes. Improved efficiency of
testing a file's existence (a little) since the path parser will
be shared between file code and parsing for the sake of finding
dircache references, not duplicated as before.

This commit doesn't reenable said items just for the sake of
keeping changes separate and related.

Plan for the next is to enable dircache again for the playlists
(easy peasy) and reenable tagcache ramcache but *without* the
dircache path caching because it's rather substantial to change
in itself. The ramcache will still function without dircache.

Change-Id: I7e2a9910b866251fa8333e1275f72fcfc8425d2d
Fix path handling snafu for CheckWPS tool 2017-01-16T12:30:39+00:00 Michael Sevakis jethead71@rockbox.org 2017-01-16T12:23:09+00:00 4f7fea2addf4a5bc7c301e78f53d9080eaf43fb6 Somehow it got hooked to simulator file functions when it should be (and was) using raw OS functions. Credit: Frank Gevaerts Change-Id: Iac02fed1067830a432183632a047e00dfd03d3c2 
Somehow it got hooked to simulator file functions when it should
be (and was) using raw OS functions.

Credit: Frank Gevaerts

Change-Id: Iac02fed1067830a432183632a047e00dfd03d3c2
Support using swapxx() and bswap_xx() for byteswaps in rbendian.h 2017-01-15T17:37:46+00:00 Franklin Wei git@fwei.tk 2017-01-07T20:29:57+00:00 ed6526404f37fc9e98d299488939787c6db932ba - patch suggested by Massa in http://forums.rockbox.org/index.php/topic,51618.msg238760.html#msg238760 Change-Id: Iba93ff53119db00a18d944d52bc8b1c5fe593fc9 
- patch suggested by Massa in http://forums.rockbox.org/index.php/topic,51618.msg238760.html#msg238760

Change-Id: Iba93ff53119db00a18d944d52bc8b1c5fe593fc9
Improve core_alloc() / buflib_alloc() documentation 2015-01-02T17:51:15+00:00 Thomas Jarosch tomj@simonv.com 2015-01-02T17:41:30+00:00 66df5f3891779f8d55dd5afba1db466cea2cc2e9 Document the fact that buffers are movable by default. Care must be taken to not pass them to functions that yield(). Also clarify other things: - Passing NULL as "ops" to buflib_alloc_ex() causes buffers to be movable by default (but not shrinkable). - If you want shrinkable buffers during compaction, you have to provide a shrink callback. - To disable buffer movement, you have to pass NULL for the move_callback inside the callback structure. - The concept of default callbacks was removed long ago, remove the only reference of it. Change-Id: I3bf0ea6b08b507d80a19f3c2c835aca32b3f7800 
Document the fact that buffers are movable by default.
Care must be taken to not pass them to functions that yield().

Also clarify other things:
- Passing NULL as "ops" to buflib_alloc_ex() causes
  buffers to be movable by default (but not shrinkable).

- If you want shrinkable buffers during compaction,
  you have to provide a shrink callback.

- To disable buffer movement, you have to pass NULL
  for the move_callback inside the callback structure.

- The concept of default callbacks was removed
  long ago, remove the only reference of it.

Change-Id: I3bf0ea6b08b507d80a19f3c2c835aca32b3f7800
Document 'union buflib_data' 2014-12-29T22:49:12+00:00 Thomas Jarosch tomj@simonv.com 2014-12-29T22:36:50+00:00 da5a36d6d298de44da687797f7547ab17b58d043 Change-Id: Ia98fa8e7887338d6c0b7a5795a0ae5c7a13014ba 
Change-Id: Ia98fa8e7887338d6c0b7a5795a0ae5c7a13014ba
Two more typo fixes 2014-12-27T01:00:15+00:00 Thomas Jarosch tomj@simonv.com 2014-12-27T01:00:15+00:00 d68262eede9c5a5f911f9619784f466a6730e21a Change-Id: Id3ec7c1da356cb7c617a1d9ad57c9e0ae9fa6611 
Change-Id: Id3ec7c1da356cb7c617a1d9ad57c9e0ae9fa6611