<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/firmware/target/sh, branch wolf3d</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Unify storage threads into one</title>
<updated>2017-10-26T18:35:41+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2017-03-15T05:51:54+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1654efc31339972d0e6bd41a499fcffc0a45822e'/>
<id>1654efc31339972d0e6bd41a499fcffc0a45822e</id>
<content type='text'>
* Editing a bunch of drivers' thread routines in order to
implement a new feature is tedious.

* No matter the number of storage drivers, they share one thread.
No extra threads needed for CONFIG_STORAGE_MULTI.

* Each has an event callback called by the storage thread.

* A default callback is provided to fake sleeping in order to
trigger idle callbacks. It could also do other default processing.
Changes to it will be part of driver code without editing each
one.

* Drivers may sleep and wake as they please as long as they give
a low pulse on their storage bit to ask to go into sleep mode.
Idle callback is called on its behalf and driver immediately put
into sleep mode.

* Drivers may indicate they are to continue receiving events in
USB mode, otherwise they receve nothing until disconnect (they
do receive SYS_USB_DISCONNECTED no matter what).

* Rework a few things to keep the callback implementation sane
and maintainable. ata.c was dreadful with all those bools; make
it a state machine and easier to follow. Remove last_user_activity;
it has no purpose that isn't served by keeping the disk active
through last_disk_activity instead.

* Even-out stack sizes partly because of a lack of a decent place
to define them by driver or SoC or whatever; it doesn't seem too
critical to do that anyway. Many are simply too large while at
least one isn't really adequate. They may be individually
overridden if necessary (figure out where). The thread uses the
greatest size demanded. Newer file code is much more frugal with
stack space. I barely see use crack 50% after idle callbacks
(usually mid-40s). Card insert/eject doesn't demand much.

* No forcing of idle callbacks. If it isn't necessary for one or
more non-disk storage types, it really isn't any more necessary for
disk storage. Besides, it makes the whole thing easier to implement.

Change-Id: Id30c284d82a8af66e47f2cfe104c52cbd8aa7215
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Editing a bunch of drivers' thread routines in order to
implement a new feature is tedious.

* No matter the number of storage drivers, they share one thread.
No extra threads needed for CONFIG_STORAGE_MULTI.

* Each has an event callback called by the storage thread.

* A default callback is provided to fake sleeping in order to
trigger idle callbacks. It could also do other default processing.
Changes to it will be part of driver code without editing each
one.

* Drivers may sleep and wake as they please as long as they give
a low pulse on their storage bit to ask to go into sleep mode.
Idle callback is called on its behalf and driver immediately put
into sleep mode.

* Drivers may indicate they are to continue receiving events in
USB mode, otherwise they receve nothing until disconnect (they
do receive SYS_USB_DISCONNECTED no matter what).

* Rework a few things to keep the callback implementation sane
and maintainable. ata.c was dreadful with all those bools; make
it a state machine and easier to follow. Remove last_user_activity;
it has no purpose that isn't served by keeping the disk active
through last_disk_activity instead.

* Even-out stack sizes partly because of a lack of a decent place
to define them by driver or SoC or whatever; it doesn't seem too
critical to do that anyway. Many are simply too large while at
least one isn't really adequate. They may be individually
overridden if necessary (figure out where). The thread uses the
greatest size demanded. Newer file code is much more frugal with
stack space. I barely see use crack 50% after idle callbacks
(usually mid-40s). Card insert/eject doesn't demand much.

* No forcing of idle callbacks. If it isn't necessary for one or
more non-disk storage types, it really isn't any more necessary for
disk storage. Besides, it makes the whole thing easier to implement.

Change-Id: Id30c284d82a8af66e47f2cfe104c52cbd8aa7215
</pre>
</div>
</content>
</entry>
<entry>
<title>Get rid of stupid _backlight_* function names</title>
<updated>2015-01-12T10:09:27+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2015-01-08T23:22:40+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=89ba7e818c0d96b779b02bc7b31c0c6a19294a46'/>
<id>89ba7e818c0d96b779b02bc7b31c0c6a19294a46</id>
<content type='text'>
_remote_backlight_* and _buttonlight_* are cleaned as well

Change-Id: I73653752831bbe170c26ba95d3bc04c2e3a5cf30
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
_remote_backlight_* and _buttonlight_* are cleaned as well

Change-Id: I73653752831bbe170c26ba95d3bc04c2e3a5cf30
</pre>
</div>
</content>
</entry>
<entry>
<title>Make a few local variables static</title>
<updated>2015-01-11T17:02:43+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-11T17:02:43+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=cfbd9cb22fc1499c3b2f8207d72dce4cb388e09f'/>
<id>cfbd9cb22fc1499c3b2f8207d72dce4cb388e09f</id>
<content type='text'>
Change-Id: Ieb77a7f2cdf765afa3121320d03c0478cd97eb0f
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ieb77a7f2cdf765afa3121320d03c0478cd97eb0f
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing kernel.h includes (hopefully all of them), take #2.</title>
<updated>2014-01-05T19:42:48+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-01-05T19:42:48+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=22b33d6eb8ad159aa1f4de25fbe6ae7281d99dbb'/>
<id>22b33d6eb8ad159aa1f4de25fbe6ae7281d99dbb</id>
<content type='text'>
Change-Id: I62cedf992bb096987050621cfc34f0432e9da170
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I62cedf992bb096987050621cfc34f0432e9da170
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing kernel.h includes (hopefully all of them).</title>
<updated>2014-01-05T19:32:09+00:00</updated>
<author>
<name>Thomas Martitz</name>
<email>kugel@rockbox.org</email>
</author>
<published>2014-01-05T19:32:09+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=22a28f9caa2f96b52e1a427c32851298e14f8f33'/>
<id>22a28f9caa2f96b52e1a427c32851298e14f8f33</id>
<content type='text'>
Change-Id: I9c1825296a788587b8d494d8514b3314847b0ff0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I9c1825296a788587b8d494d8514b3314847b0ff0
</pre>
</div>
</content>
</entry>
<entry>
<title>Cleanup MV/MD macros a little.</title>
<updated>2013-08-17T16:18:22+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2013-08-17T16:18:22+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a56f1ca1ed63b93eb61fd5319f47347b3eb1e364'/>
<id>a56f1ca1ed63b93eb61fd5319f47347b3eb1e364</id>
<content type='text'>
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal
with function parameters. IF_MD/IF_MV are enough.

Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0
if not.

Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When using variadic macros there's no need for IF_MD2/IF_MV2 to deal
with function parameters. IF_MD/IF_MV are enough.

Throw in IF_MD_DRV/ID_MV_VOL that return the parameter if MD/MV, or 0
if not.

Change-Id: I7605e6039f3be19cb47110c84dcb3c5516f2c3eb
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "SH gcc 4.6.3 with link-time optimization, for Archos targets"</title>
<updated>2012-10-24T12:05:39+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2012-10-24T12:05:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=5dec7af1ecf5c0d483d13c8ad9cc0a13868a7c16'/>
<id>5dec7af1ecf5c0d483d13c8ad9cc0a13868a7c16</id>
<content type='text'>
This was commited by accident, sorry.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was commited by accident, sorry.
</pre>
</div>
</content>
</entry>
<entry>
<title>SH gcc 4.6.3 with link-time optimization, for Archos targets</title>
<updated>2012-10-24T12:02:41+00:00</updated>
<author>
<name>Boris Gjenero</name>
<email>dreamlayers@rockbox.org</email>
</author>
<published>2012-10-22T19:30:01+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c975de1534f4b4092ad75f85353eec32a9a31b92'/>
<id>c975de1534f4b4092ad75f85353eec32a9a31b92</id>
<content type='text'>
This is work from FS#12431 synced to current HEAD and slightly
tweaked (gcc 4.6.2 -&gt; 4.6.3, binutils 2.21.1 -&gt; 2.22)

Change-Id: I76af91e80ac2a9c16a776c7f0a33cc51603bbf9b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is work from FS#12431 synced to current HEAD and slightly
tweaked (gcc 4.6.2 -&gt; 4.6.3, binutils 2.21.1 -&gt; 2.22)

Change-Id: I76af91e80ac2a9c16a776c7f0a33cc51603bbf9b
</pre>
</div>
</content>
</entry>
<entry>
<title>remove debug-target.h</title>
<updated>2012-05-07T04:55:59+00:00</updated>
<author>
<name>Rafaël Carré</name>
<email>funman@videolan.org</email>
</author>
<published>2012-05-07T04:55:59+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=7ca20810367d9a1b211f242d1b1183dbedeeda68'/>
<id>7ca20810367d9a1b211f242d1b1183dbedeeda68</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Tweak paramters of mp3_play_data and callback.</title>
<updated>2012-03-04T19:50:47+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2012-03-04T19:44:43+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d18a5cad7f002b2f67385e57118048ea3db185a6'/>
<id>d18a5cad7f002b2f67385e57118048ea3db185a6</id>
<content type='text'>
Use generic void * and size_t and make mp3_play_data and its callback
agree on types. Use mp3_play_callback_t instead of prototyping
right in the function call (so it's not so messy to look at). Change
doesn't appear to require plugin API version increment.

Change-Id: Idcab2740ee316a2beb6e0a87b8f4934d9d6b3dd8
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use generic void * and size_t and make mp3_play_data and its callback
agree on types. Use mp3_play_callback_t instead of prototyping
right in the function call (so it's not so messy to look at). Change
doesn't appear to require plugin API version increment.

Change-Id: Idcab2740ee316a2beb6e0a87b8f4934d9d6b3dd8
</pre>
</div>
</content>
</entry>
</feed>
