rockbox/lib/rbcodec/metadata, branch working

Fix warning in WMA Pro and remove a c++ comment.

2014-11-28T22:04:50+00:00

Change-Id: Id9b50c1fdeca4d87f158da717de8958330f027ef

Fix FS#13009.

2014-11-28T21:30:05+00:00

This file revealed several problems with our ASF parser:

1)  The packet count in the ASF was actually a 64 bit value,
leading to overflow in very long files.

2)  Seeking blindly trusted the bitrate listed in the ASF header
rather than computing it from the packet size and number of packets.

Fix these problems and fix a few minor issues.

Change-Id: Ie0f68734e6423e837757528ddb155f3bdcc979f3

fix yellow

2014-09-22T08:55:11+00:00

Change-Id: Ie3aa9b208e3f4f17d4d02f11f69839e9b381217d

metadata: Add cuesheet embedded in ape tags.

2014-09-22T08:20:39+00:00

Change-Id: I5d9e731c3ea786fb910afbb0a5201fc68dcab9f9
Reviewed-on: http://gerrit.rockbox.org/965
Reviewed-by: Nick Peskett 
Tested: Nick Peskett 
Reviewed-by: Marcin Bukat

Proposed fix for FS#12878: Zero-length embedded album art prevents mp3 playback

2013-12-23T16:55:15+00:00

see http://www.rockbox.org/tracker/task/12878

Change-Id: Ib4233c06e18d1d193dfb9e73e745ca5d174e40b2
Reviewed-on: http://gerrit.rockbox.org/507
Reviewed-by: Michael Giacomelli 
Reviewed-by: Thomas Martitz

Add support for flac embeded album art.

2013-12-13T11:37:20+00:00

Change-Id: I077768f7d80b57976f9a7278b640ef67cf4f2af2
Reviewed-on: http://gerrit.rockbox.org/694
Reviewed-by: Thomas Martitz

Fix id3v2 album art if more than one image is present.

2013-06-15T19:04:13+00:00

Rockbox only uses the first album art image (APIC / PIC frame) found in id3v2
tags. When a file contains more than one image the second one is ignored but
the parsealbumart() callback overwrites the already set data. This causes the
metadata structure to contain an invalid pointer to the image data, resulting
in no image shown.

Make parsealbumart() aware of this and skip parsing when an albumart image has
already been found. Fixes FS#12870.

Change-Id: Id8164f319cd5e1ee868b581f8f4ad3ea69c17f77

SPC Codec: Have metadata parser fill in frequency and bitrate.

2013-05-22T00:01:17+00:00

Change-Id: I6c72f4d1c79b1a99a11fb28e7d46886c08a56a75

Properly seek to next id3v2 frame for unsynced tags.

2013-04-26T20:45:04+00:00

When seeking to the next id3v2 frame we need to consider if the tag has the
unsync flag set. Not doing so will likely make parsing end up in the middle of
the current frame if the frame size exceeds the upper limit set during read.
The latter usually happens for album art frames.

Fixes FS#12849.

Change-Id: Ic92853eef4374508d84df347bcc66b6661d5037d

VGM Codec: Improve time and fade behavior. Tweak minor misc.

2013-03-07T00:47:05+00:00

Prevents cutoff of tracks, especially short ones:
* Extend looped tracks by fade length to fade at start of loop repeat.
* No fade occurs for non-repeating track only having an intro.
* Uses id3.tail_trim field to store fade duration.

Use libGME built-in elapsed time reporting instead of custom calculation:
* libGME already reports in milliseconds.
* Don't advance time counter when Repeat == One. It just runs the progress
  over the length limit.

Fix a comment about sample rate and set the reported bitrate to be
accurate for 44.1 kHz stereo.

Change-Id: I3ede22bda0f9a941a3fef751f4d678eb0027344c