<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/lib/unwarminder, branch puzzles</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>ARM unwinder for thumb: Fix broken MOV opcode</title>
<updated>2015-01-12T18:36:58+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T18:33:46+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=789df17dd9f5f6f940ffc1b1db11c4e777400767'/>
<id>789df17dd9f5f6f940ffc1b1db11c4e777400767</id>
<content type='text'>
The origin of the register value was never
moved in the desired register state due to a typo ('rhs' vs. 'rhd').

While looking at the code, I noticed the action taken
for the register value is another copy'n'paste error
from the ADD opcode above -&gt; it added to the register value
instead of MOVing the current value.

Patch submitted upstream.

cppcheck reported:
[lib/unwarminder/unwarm_thumb.c:473]: (warning) Redundant assignment of 'state.regData[rhd].o' to itself.

Change-Id: I78cdbf37a191007a3bddbaa350b906dbce2fe671
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The origin of the register value was never
moved in the desired register state due to a typo ('rhs' vs. 'rhd').

While looking at the code, I noticed the action taken
for the register value is another copy'n'paste error
from the ADD opcode above -&gt; it added to the register value
instead of MOVing the current value.

Patch submitted upstream.

cppcheck reported:
[lib/unwarminder/unwarm_thumb.c:473]: (warning) Redundant assignment of 'state.regData[rhd].o' to itself.

Change-Id: I78cdbf37a191007a3bddbaa350b906dbce2fe671
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix red</title>
<updated>2015-01-12T18:31:39+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T18:31:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=799024198f196b71b3afed402bbd7c4ccc4c23b4'/>
<id>799024198f196b71b3afed402bbd7c4ccc4c23b4</id>
<content type='text'>
Change-Id: Ia7565dac0f6b9703a5dfff723167620deb218bc3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ia7565dac0f6b9703a5dfff723167620deb218bc3
</pre>
</div>
</content>
</entry>
<entry>
<title>ARM unwinder for thumb: Fix broken SUB opcode</title>
<updated>2015-01-12T18:26:23+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T18:26:16+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=7361a433d09358a339e4ea81d5da3f7dd7f1b1ca'/>
<id>7361a433d09358a339e4ea81d5da3f7dd7f1b1ca</id>
<content type='text'>
Detected while looking through the code.
Patch submitted upstream.

Change-Id: I7ebe7b5f5947cf3df1b054d545dba92829f21b99
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Detected while looking through the code.
Patch submitted upstream.

Change-Id: I7ebe7b5f5947cf3df1b054d545dba92829f21b99
</pre>
</div>
</content>
</entry>
<entry>
<title>ARM unwinder: Add missing 'register' variable in debug output</title>
<updated>2015-01-12T18:15:08+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T18:15:05+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=fa592cc7255a91715b5bd91a3a003b848bcba5f2'/>
<id>fa592cc7255a91715b5bd91a3a003b848bcba5f2</id>
<content type='text'>
Also fix a wrong format specifier for an unsigned variable.
Detected by cppcheck, patch submitted upstream.

Change-Id: I9b84d91eeb242ed77b53ecc16252c5b35190bb9f
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also fix a wrong format specifier for an unsigned variable.
Detected by cppcheck, patch submitted upstream.

Change-Id: I9b84d91eeb242ed77b53ecc16252c5b35190bb9f
</pre>
</div>
</content>
</entry>
<entry>
<title>ARM unwinder: Add missing va_end() call.</title>
<updated>2015-01-12T18:10:24+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T18:10:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1589b28afca9a8193258ad73a8847ceb952d3e0f'/>
<id>1589b28afca9a8193258ad73a8847ceb952d3e0f</id>
<content type='text'>
Detected by cppcheck, patch submitted upstream.

Change-Id: Ieeec9d2e7e2c22d64c94936958f5a4ff02d3548b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Detected by cppcheck, patch submitted upstream.

Change-Id: Ieeec9d2e7e2c22d64c94936958f5a4ff02d3548b
</pre>
</div>
</content>
</entry>
<entry>
<title>Add newlines at the end of the file</title>
<updated>2014-12-17T22:34:48+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-17T22:23:35+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=55a5aab97cf4d487688a958c65a4851c8e3e0405'/>
<id>55a5aab97cf4d487688a958c65a4851c8e3e0405</id>
<content type='text'>
Quiet maemo's gcc 4.2.1 compiler warning.

Change-Id: I35dfb2c0cb269b05edd62adf71fe0308a4b9ba5b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Quiet maemo's gcc 4.2.1 compiler warning.

Change-Id: I35dfb2c0cb269b05edd62adf71fe0308a4b9ba5b
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused return value variable in lib/unwarminder/backtrace.c</title>
<updated>2014-08-25T18:07:19+00:00</updated>
<author>
<name>Michael Sevakis</name>
<email>jethead71@rockbox.org</email>
</author>
<published>2014-08-25T18:07:19+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=bfbec3a3a7de448902b2b3244f5b4f942ef09570'/>
<id>bfbec3a3a7de448902b2b3244f5b4f942ef09570</id>
<content type='text'>
Stop the Android warning about it

Change-Id: I2f01220004f128befaa5757786b8de174566cbb5
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Stop the Android warning about it

Change-Id: I2f01220004f128befaa5757786b8de174566cbb5
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix return address when data_abort_handler skips faulting instruction.</title>
<updated>2013-05-23T23:51:19+00:00</updated>
<author>
<name>Boris Gjenero</name>
<email>boris.gjenero@gmail.com</email>
</author>
<published>2013-05-23T23:31:33+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4077eac8398345d3500be794190eec83852135ba'/>
<id>4077eac8398345d3500be794190eec83852135ba</id>
<content type='text'>
When writing a value to PC, execution continues at that location,
so subtracting 4 returns to the next instruction. Previously, two
instructions after the faulting instruction were being skipped, causing
safe_read functions to return true even if a data abort happened.

Change-Id: I3fd02d54646323ea2050d0504e38f6d22f09c749
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When writing a value to PC, execution continues at that location,
so subtracting 4 returns to the next instruction. Previously, two
instructions after the faulting instruction were being skipped, causing
safe_read functions to return true even if a data abort happened.

Change-Id: I3fd02d54646323ea2050d0504e38f6d22f09c749
</pre>
</div>
</content>
</entry>
<entry>
<title>unwarminder: make SP and PC visible on smaller screens</title>
<updated>2012-09-05T06:53:48+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2012-09-05T06:52:39+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a46e0b02c1ac95d8843e580c0a4bf4d5b3a7452a'/>
<id>a46e0b02c1ac95d8843e580c0a4bf4d5b3a7452a</id>
<content type='text'>
Change-Id: I78c0e6edb1ad097154885b9fa93d74616047cbc1
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I78c0e6edb1ad097154885b9fa93d74616047cbc1
</pre>
</div>
</content>
</entry>
<entry>
<title>unwarminder: fix data_abort_handler (wrong address to UIE)</title>
<updated>2012-06-07T12:48:43+00:00</updated>
<author>
<name>Amaury Pouly</name>
<email>amaury.pouly@gmail.com</email>
</author>
<published>2012-05-31T23:52:19+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1a4fa1603ba4b3a55f3862a17c74b1224b55c1fd'/>
<id>1a4fa1603ba4b3a55f3862a17c74b1224b55c1fd</id>
<content type='text'>
Change-Id: I060735363f2e408c42a8e11ac1f31dc96e3cb2d6
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I060735363f2e408c42a8e11ac1f31dc96e3cb2d6
</pre>
</div>
</content>
</entry>
</feed>
