<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/rbutil/rbutilqt/base/autodetection.cpp, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix crash when detecting a player in MTP mode.</title>
<updated>2014-05-24T20:57:25+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2014-05-24T20:56:44+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=896b771710c67efe69ee54e17ba2154f286917e2'/>
<id>896b771710c67efe69ee54e17ba2154f286917e2</id>
<content type='text'>
Change-Id: I65bf6928584735d6a179750c313fb8e7dcf7add5
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I65bf6928584735d6a179750c313fb8e7dcf7add5
</pre>
</div>
</content>
</entry>
<entry>
<title>Use cutelogger for Rockbox Utility internal trace.</title>
<updated>2013-11-04T22:32:52+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-11-03T10:08:18+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=4d2ce949b3b41f8bf0af446fa20205ddd229e579'/>
<id>4d2ce949b3b41f8bf0af446fa20205ddd229e579</id>
<content type='text'>
Change tracing from qDebug() to use cutelogger, which is available under the
LGPL2.1. This allows to automatically add filename and line number to the log,
and also provides multiple log levels.

Change-Id: I5dbdaf902ba54ea99f07ae10a07467c52fdac910
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change tracing from qDebug() to use cutelogger, which is available under the
LGPL2.1. This allows to automatically add filename and line number to the log,
and also provides multiple log levels.

Change-Id: I5dbdaf902ba54ea99f07ae10a07467c52fdac910
</pre>
</div>
</content>
</entry>
<entry>
<title>Use function for updating detected device entry.</title>
<updated>2013-09-30T21:42:21+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-09-20T19:03:51+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=1977281bb3de54db1be7527bdea3ab9089f15011'/>
<id>1977281bb3de54db1be7527bdea3ab9089f15011</id>
<content type='text'>
Use a function instead of looking for an existing entry and creating a new one
if necessary every time.

Change-Id: I7b385dad7366f27370545a7d1a9f7052510cca11
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use a function instead of looking for an existing entry and creating a new one
if necessary every time.

Change-Id: I7b385dad7366f27370545a7d1a9f7052510cca11
</pre>
</div>
</content>
</entry>
<entry>
<title>Rework autodetection to better handle ambiguous cases.</title>
<updated>2013-09-18T21:37:39+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-09-18T20:06:41+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=b943c59f3575ee357b66cc316baec95ffcfd5f10'/>
<id>b943c59f3575ee357b66cc316baec95ffcfd5f10</id>
<content type='text'>
The old detection code simply assumed only one player to be connected and threw
all information it could find together, causing wrong results in various cases.
Rewrite it to better handle this.

- Don't expect only a single player to be attached. Return a list of players
  found instead. The configuration dialog can then show the user a list to
  select from. This is not implemented yet, the configuration dialog will only
  show the devices found and tell the user to disconnect all but one.

- Handle ambiguous cases better. A player found that is ambiguous is treated as
  such, and if refining the result didn't lead to a single match for each
  possible player a single entry is created that indicates it being ambiguous.

The current code needs a bit of additional cleanup (the result exposes internal
data to the caller it shouldn't) to be done later.

Change-Id: I22dc2f73cdd6a9d90c34f3a0703aa9e0a2d2087a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The old detection code simply assumed only one player to be connected and threw
all information it could find together, causing wrong results in various cases.
Rewrite it to better handle this.

- Don't expect only a single player to be attached. Return a list of players
  found instead. The configuration dialog can then show the user a list to
  select from. This is not implemented yet, the configuration dialog will only
  show the devices found and tell the user to disconnect all but one.

- Handle ambiguous cases better. A player found that is ambiguous is treated as
  such, and if refining the result didn't lead to a single match for each
  possible player a single entry is created that indicates it being ambiguous.

The current code needs a bit of additional cleanup (the result exposes internal
data to the caller it shouldn't) to be done later.

Change-Id: I22dc2f73cdd6a9d90c34f3a0703aa9e0a2d2087a
</pre>
</div>
</content>
</entry>
<entry>
<title>Change autodetection result to a list.</title>
<updated>2013-04-09T20:39:13+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-04-06T19:15:05+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=e30b3d84e8d744098df13617fceed562bcdb8462'/>
<id>e30b3d84e8d744098df13617fceed562bcdb8462</id>
<content type='text'>
Both autodetection functionality and the configuration dialog assumed detection
to only return one found device. This isn't necessarily true, especially since
some players can be detected but detecting their mountpoint might be ambiguous
(only if no previous Rockbox installation is present).

Instead of returning individual results (found "ok" player, found "error"
player etc.) return a list containing an entry for each player. Current
autodetection code will never return more than one entry since it doesn't
handle multiple devices yet, and the configuration dialog will show an error if
multiple devices are found. Thus there is no user visible change yet. Both
autodetection and configuration dialog can now get extended to handle multiple
devices.

Change-Id: I79b763dbd6e7111783194bcc22ab7cc06a4061c1
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Both autodetection functionality and the configuration dialog assumed detection
to only return one found device. This isn't necessarily true, especially since
some players can be detected but detecting their mountpoint might be ambiguous
(only if no previous Rockbox installation is present).

Instead of returning individual results (found "ok" player, found "error"
player etc.) return a list containing an entry for each player. Current
autodetection code will never return more than one entry since it doesn't
handle multiple devices yet, and the configuration dialog will show an error if
multiple devices are found. Thus there is no user visible change yet. Both
autodetection and configuration dialog can now get extended to handle multiple
devices.

Change-Id: I79b763dbd6e7111783194bcc22ab7cc06a4061c1
</pre>
</div>
</content>
</entry>
<entry>
<title>Extend Utils::mountpoints() to allow filtering for supported types.</title>
<updated>2013-04-04T20:42:22+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-04-01T18:37:13+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=5ce21366d799c92e1f01abde9d42e0959622c628'/>
<id>5ce21366d799c92e1f01abde9d42e0959622c628</id>
<content type='text'>
Instead of trying every mountpoint during autodetection allow filtering out
filesystems that are not supported when retrieving the system mountpoints.

Change-Id: Ic23a5c804cb7c78c146dbc1af7443c67ce12464e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of trying every mountpoint during autodetection allow filtering out
filesystems that are not supported when retrieving the system mountpoints.

Change-Id: Ic23a5c804cb7c78c146dbc1af7443c67ce12464e
</pre>
</div>
</content>
</entry>
<entry>
<title>Provide dealloc function to sansapatcher.</title>
<updated>2013-01-01T14:06:41+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-01-01T12:23:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=163ab4617096edb6384aa8fc7a764d440aee3fb9'/>
<id>163ab4617096edb6384aa8fc7a764d440aee3fb9</id>
<content type='text'>
Similar as done with ipodpatcher provide a function to free the allocated
sector buffer.

Change-Id: Ie51e82f7191496bb48973148af1cc35cd37993d3
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Similar as done with ipodpatcher provide a function to free the allocated
sector buffer.

Change-Id: Ie51e82f7191496bb48973148af1cc35cd37993d3
</pre>
</div>
</content>
</entry>
<entry>
<title>Provide dealloc function to ipodpatcher.</title>
<updated>2013-01-01T14:06:41+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2013-01-01T10:04:21+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=b63d429c8f2c68994600d98bfaddf59ca16fc889'/>
<id>b63d429c8f2c68994600d98bfaddf59ca16fc889</id>
<content type='text'>
On Windows the sector buffer is allocated using VirtualAlloc, thus releasing
this buffer should be done using VirtualFree. Provide an additional function
for deallocating the buffer so users of ipodpatcher do not need to know about
this.

Change-Id: Ibb0fc575a185148a389e63935e86a392bf8d180d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
On Windows the sector buffer is allocated using VirtualAlloc, thus releasing
this buffer should be done using VirtualFree. Provide an additional function
for deallocating the buffer so users of ipodpatcher do not need to know about
this.

Change-Id: Ibb0fc575a185148a389e63935e86a392bf8d180d
</pre>
</div>
</content>
</entry>
<entry>
<title>sansapatcher: move sectorbuf pointer into sansa_t structure.</title>
<updated>2013-01-01T14:06:34+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2012-12-23T22:36:00+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=9c1ed84d28edfa4a2b5b0a327dccd83d1a1beef8'/>
<id>9c1ed84d28edfa4a2b5b0a327dccd83d1a1beef8</id>
<content type='text'>
Similar as the ipod_t structure for ipodpatcher the sansa_t structure holds all
relevant information for sansapatcher. Put the global sansa_sectorbuf pointer
into it as well.

Change-Id: Iad08ef6aafc49609c3d0d556914246f230ee0179
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Similar as the ipod_t structure for ipodpatcher the sansa_t structure holds all
relevant information for sansapatcher. Put the global sansa_sectorbuf pointer
into it as well.

Change-Id: Iad08ef6aafc49609c3d0d556914246f230ee0179
</pre>
</div>
</content>
</entry>
<entry>
<title>ipodpatcher: move sectorbuf pointer into ipod_t structure.</title>
<updated>2013-01-01T14:05:52+00:00</updated>
<author>
<name>Dominik Riebeling</name>
<email>Dominik.Riebeling@gmail.com</email>
</author>
<published>2012-12-23T22:30:57+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=24e37ddf57bac6a1c9786d50abbe3a1982930382'/>
<id>24e37ddf57bac6a1c9786d50abbe3a1982930382</id>
<content type='text'>
The ipod_t structure holds all relevant information for ipodpatcher. Put the
global ipod_sectorbuf pointer into it as well. Allows the Rockbox Utility Ipod
class to be instanciated multiple times since each instance can now have its
own buffer.

Change-Id: Ie319cbadbc20c367ceadba9a46b4dc34b57a79a7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The ipod_t structure holds all relevant information for ipodpatcher. Put the
global ipod_sectorbuf pointer into it as well. Allows the Rockbox Utility Ipod
class to be instanciated multiple times since each instance can now have its
own buffer.

Change-Id: Ie319cbadbc20c367ceadba9a46b4dc34b57a79a7
</pre>
</div>
</content>
</entry>
</feed>
