<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/utils/jz4740_tools, branch master</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>Fix crash on uninitialized variable</title>
<updated>2015-01-13T20:57:24+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-13T20:57:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8'/>
<id>2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8</id>
<content type='text'>
The WRITE() macro checks if the "fw" pointer
is open upon fwrite() error. Since fw was
not initialized before use, it might crash for non-zero fw.

cppcheck reported.
[utils/jz4740_tools/HXFreplace.c:187]: (error) Uninitialized variable: fw

Change-Id: I558170f9f17828c9fd515a5da36ad8b5cb30a9ad
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The WRITE() macro checks if the "fw" pointer
is open upon fwrite() error. Since fw was
not initialized before use, it might crash for non-zero fw.

cppcheck reported.
[utils/jz4740_tools/HXFreplace.c:187]: (error) Uninitialized variable: fw

Change-Id: I558170f9f17828c9fd515a5da36ad8b5cb30a9ad
</pre>
</div>
</content>
</entry>
<entry>
<title>jz4740 usbtool: Fix undefined behavior in set_reg()</title>
<updated>2015-01-04T17:16:44+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-04T17:10:42+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c907e127f8b1d267e91e82d28cdb210288852b82'/>
<id>c907e127f8b1d267e91e82d28cdb210288852b82</id>
<content type='text'>
The variable 'i' should actually be 'size'.
See the read_reg() function above it.

Confirmed via private email from Maurus Cuelenaere. Thanks!
(who also remembered having trouble reading/setting
 registers over USB back then ;))

cppcheck reported:
[rockbox/utils/jz4740_tools/jz4740_usbtool.c:281]: (error) Uninitialized variable: i

Change-Id: I0f34834335e89d2504e7597e8db22cf69b5ca7e7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The variable 'i' should actually be 'size'.
See the read_reg() function above it.

Confirmed via private email from Maurus Cuelenaere. Thanks!
(who also remembered having trouble reading/setting
 registers over USB back then ;))

cppcheck reported:
[rockbox/utils/jz4740_tools/jz4740_usbtool.c:281]: (error) Uninitialized variable: i

Change-Id: I0f34834335e89d2504e7597e8db22cf69b5ca7e7
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix off-by-one buffer error</title>
<updated>2011-10-14T12:07:47+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2011-10-14T12:07:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=eac291348da754aaa6630a3ac95b290bcd850243'/>
<id>eac291348da754aaa6630a3ac95b290bcd850243</id>
<content type='text'>
The _GET_CPU macro will write a terminating zero at cpu[8].

Detected by cppcheck

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30749 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The _GET_CPU macro will write a terminating zero at cpu[8].

Detected by cppcheck

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30749 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove superfluous executable bits on a bunch of files.</title>
<updated>2011-06-08T14:22:03+00:00</updated>
<author>
<name>Torne Wuff</name>
<email>torne@wolfpuppy.org.uk</email>
</author>
<published>2011-06-08T14:22:03+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=754b1572fb09ad6911c7d57cb4f806bb98ab7015'/>
<id>754b1572fb09ad6911c7d57cb4f806bb98ab7015</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29986 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29986 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Make sure files which aren't windows-specific use \n line endings only</title>
<updated>2010-06-17T16:59:51+00:00</updated>
<author>
<name>Rafaël Carré</name>
<email>rafael.carre@gmail.com</email>
</author>
<published>2010-06-17T16:59:51+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c0bd4173aa3b8f49153964d5a3ff311fc7d59651'/>
<id>c0bd4173aa3b8f49153964d5a3ff311fc7d59651</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26893 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26893 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>jz4740_tools : bin2c.c location has changed</title>
<updated>2009-06-19T23:00:07+00:00</updated>
<author>
<name>Rafaël Carré</name>
<email>rafael.carre@gmail.com</email>
</author>
<published>2009-06-19T23:00:07+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=638df101194c2bd8dba6c64f1684dc83e4457d55'/>
<id>638df101194c2bd8dba6c64f1684dc83e4457d55</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21356 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21356 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Update jz4740_tools README</title>
<updated>2009-04-21T15:41:21+00:00</updated>
<author>
<name>Maurus Cuelenaere</name>
<email>mcuelenaere@gmail.com</email>
</author>
<published>2009-04-21T15:41:21+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=034547c7549b6b29f6b15dcc8b8a07e5e4e69a4a'/>
<id>034547c7549b6b29f6b15dcc8b8a07e5e4e69a4a</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20770 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20770 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Jz4740 USB tool:</title>
<updated>2009-04-04T17:53:59+00:00</updated>
<author>
<name>Maurus Cuelenaere</name>
<email>mcuelenaere@gmail.com</email>
</author>
<published>2009-04-04T17:53:59+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c5a3c8c670d2c505eaa608cc9cdedd932df3720a'/>
<id>c5a3c8c670d2c505eaa608cc9cdedd932df3720a</id>
<content type='text'>
 * Add a slight delay, so that the pre-boot code gets time to execute
 * Remove an unneeded check


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20616 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 * Add a slight delay, so that the pre-boot code gets time to execute
 * Remove an unneeded check


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20616 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Jz4740 USB tools warnings</title>
<updated>2009-03-31T17:08:33+00:00</updated>
<author>
<name>Maurus Cuelenaere</name>
<email>mcuelenaere@gmail.com</email>
</author>
<published>2009-03-31T17:08:33+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=d99913289b679ee2ebb54e366daae4956c0fee6a'/>
<id>d99913289b679ee2ebb54e366daae4956c0fee6a</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20592 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20592 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Jz4740 USB tools a bit more configurable by letting you choose what file you want to upload when doing usbtool 10</title>
<updated>2009-03-20T22:50:08+00:00</updated>
<author>
<name>Maurus Cuelenaere</name>
<email>mcuelenaere@gmail.com</email>
</author>
<published>2009-03-20T22:50:08+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c7b6ad5fdf3e89b5c68e2448dc360c6838a3b241'/>
<id>c7b6ad5fdf3e89b5c68e2448dc360c6838a3b241</id>
<content type='text'>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20415 a1c6a512-1295-4272-9138-f99709370657
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20415 a1c6a512-1295-4272-9138-f99709370657
</pre>
</div>
</content>
</entry>
</feed>
