<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rockbox/utils, branch xracer</title>
<subtitle>My Rockbox tree</subtitle>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/'/>
<entry>
<title>atj213x: Fix DMAC block in description file</title>
<updated>2015-01-23T10:03:49+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2015-01-23T10:03:49+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=f65baf9b0f385bc479de9ab2eb92aab23167eba8'/>
<id>f65baf9b0f385bc479de9ab2eb92aab23167eba8</id>
<content type='text'>
Change-Id: I4afc17b06f85d552248c0248e6b4b921ffc1e7a7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I4afc17b06f85d552248c0248e6b4b921ffc1e7a7
</pre>
</div>
</content>
</entry>
<entry>
<title>atj213x: fix desc file errors</title>
<updated>2015-01-22T12:38:13+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2015-01-22T12:33:35+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=15d4be5e9f8919b55ba5f9df548b4336a06cc433'/>
<id>15d4be5e9f8919b55ba5f9df548b4336a06cc433</id>
<content type='text'>
Catched by swiss_knife check there are some overlaping fields
and invalid characters in some names.

Change-Id: Ia26ffd2e29452f4ddd9f8229f78bb2a2cc325ab4
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Catched by swiss_knife check there are some overlaping fields
and invalid characters in some names.

Change-Id: Ia26ffd2e29452f4ddd9f8229f78bb2a2cc325ab4
</pre>
</div>
</content>
</entry>
<entry>
<title>hwstub: implement read/write data abort recovery</title>
<updated>2015-01-13T22:35:33+00:00</updated>
<author>
<name>Amaury Pouly</name>
<email>amaury.pouly@gmail.com</email>
</author>
<published>2014-09-20T12:29:12+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2cdfc43f10e3d755018ea508b64b209608d71864'/>
<id>2cdfc43f10e3d755018ea508b64b209608d71864</id>
<content type='text'>
Change-Id: I1625873b6864584c40984723d82548ad242ee08e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I1625873b6864584c40984723d82548ad242ee08e
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix crash on uninitialized variable</title>
<updated>2015-01-13T20:57:24+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-13T20:57:24+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8'/>
<id>2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8</id>
<content type='text'>
The WRITE() macro checks if the "fw" pointer
is open upon fwrite() error. Since fw was
not initialized before use, it might crash for non-zero fw.

cppcheck reported.
[utils/jz4740_tools/HXFreplace.c:187]: (error) Uninitialized variable: fw

Change-Id: I558170f9f17828c9fd515a5da36ad8b5cb30a9ad
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The WRITE() macro checks if the "fw" pointer
is open upon fwrite() error. Since fw was
not initialized before use, it might crash for non-zero fw.

cppcheck reported.
[utils/jz4740_tools/HXFreplace.c:187]: (error) Uninitialized variable: fw

Change-Id: I558170f9f17828c9fd515a5da36ad8b5cb30a9ad
</pre>
</div>
</content>
</entry>
<entry>
<title>Clean up bogus 'make compiler happy' code</title>
<updated>2015-01-12T20:13:00+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-12T20:12:58+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=a71603b4d17b1f7da06c77176a795a7464dc859a'/>
<id>a71603b4d17b1f7da06c77176a795a7464dc859a</id>
<content type='text'>
Less code makes the compiler even happier.

Change-Id: I24cf586ba44f432b541fd17079f93dbd52314828
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Less code makes the compiler even happier.

Change-Id: I24cf586ba44f432b541fd17079f93dbd52314828
</pre>
</div>
</content>
</entry>
<entry>
<title>regtools/headergen: Make generator more flexible</title>
<updated>2015-01-12T10:28:52+00:00</updated>
<author>
<name>Marcin Bukat</name>
<email>marcin.bukat@gmail.com</email>
</author>
<published>2014-12-08T12:24:33+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=bbd7d1dba39ab1a89b4cc0c18352e35349e66faa'/>
<id>bbd7d1dba39ab1a89b4cc0c18352e35349e66faa</id>
<content type='text'>
Change-Id: I2328ec021ed990a40257d4ce6f4fc5b3db2ba998
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I2328ec021ed990a40257d4ce6f4fc5b3db2ba998
</pre>
</div>
</content>
</entry>
<entry>
<title>jz4740 usbtool: Fix undefined behavior in set_reg()</title>
<updated>2015-01-04T17:16:44+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-04T17:10:42+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=c907e127f8b1d267e91e82d28cdb210288852b82'/>
<id>c907e127f8b1d267e91e82d28cdb210288852b82</id>
<content type='text'>
The variable 'i' should actually be 'size'.
See the read_reg() function above it.

Confirmed via private email from Maurus Cuelenaere. Thanks!
(who also remembered having trouble reading/setting
 registers over USB back then ;))

cppcheck reported:
[rockbox/utils/jz4740_tools/jz4740_usbtool.c:281]: (error) Uninitialized variable: i

Change-Id: I0f34834335e89d2504e7597e8db22cf69b5ca7e7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The variable 'i' should actually be 'size'.
See the read_reg() function above it.

Confirmed via private email from Maurus Cuelenaere. Thanks!
(who also remembered having trouble reading/setting
 registers over USB back then ;))

cppcheck reported:
[rockbox/utils/jz4740_tools/jz4740_usbtool.c:281]: (error) Uninitialized variable: i

Change-Id: I0f34834335e89d2504e7597e8db22cf69b5ca7e7
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix uninitialized variable (should fix libusb retry handling)</title>
<updated>2015-01-04T12:35:47+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-04T12:35:47+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=89ab3c27610d441479c6e4133c73043762191b5a'/>
<id>89ab3c27610d441479c6e4133c73043762191b5a</id>
<content type='text'>
Reported by cppcheck

Change-Id: I5ac7b73f2e3eaee3d5427d118944613e572f684d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reported by cppcheck

Change-Id: I5ac7b73f2e3eaee3d5427d118944613e572f684d
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unneeded std::string .c_str() call</title>
<updated>2015-01-04T11:33:09+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2015-01-04T11:33:09+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=8f1fbd1dc8be2718c5ddd7fa8635338c1fe9a2d2'/>
<id>8f1fbd1dc8be2718c5ddd7fa8635338c1fe9a2d2</id>
<content type='text'>
cppcheck reported:
[utils/zenutils/source/update_patch/main.cpp:105]: (performance) Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant.

Change-Id: Ied9de135e693af22e1fdc3aa3b67d14b7d2c21e6
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
cppcheck reported:
[utils/zenutils/source/update_patch/main.cpp:105]: (performance) Passing the result of c_str() to a function that takes std::string as argument no. 1 is slow and redundant.

Change-Id: Ied9de135e693af22e1fdc3aa3b67d14b7d2c21e6
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove useless assignment of 'len'</title>
<updated>2014-12-20T14:52:35+00:00</updated>
<author>
<name>Thomas Jarosch</name>
<email>tomj@simonv.com</email>
</author>
<published>2014-12-20T14:52:35+00:00</published>
<link rel='alternate' type='text/html' href='https://www.franklinwei.com/cgit/rockbox/commit/?id=29ffa832fec4a2123c10730ee6f3d6fc08e39de0'/>
<id>29ffa832fec4a2123c10730ee6f3d6fc08e39de0</id>
<content type='text'>
The variable 'len' is not used after this statement.
Probably a copy'n'paste leftover from the similar
looking block above.

cppcheck reported:
[rockbox/utils/zenutils/source/shared/cenc.cpp:212]: (style) Same expression on both sides of '-'.

Change-Id: Ia8357187ed39d3fab10d97df75a1146c4f733790
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The variable 'len' is not used after this statement.
Probably a copy'n'paste leftover from the similar
looking block above.

cppcheck reported:
[rockbox/utils/zenutils/source/shared/cenc.cpp:212]: (style) Same expression on both sides of '-'.

Change-Id: Ia8357187ed39d3fab10d97df75a1146c4f733790
</pre>
</div>
</content>
</entry>
</feed>
