summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrank Gevaerts <frank@gevaerts.be>2019-07-20 17:11:32 +0200
committerFrank Gevaerts <frank@gevaerts.be>2019-07-20 17:11:32 +0200
commit3665eecf473b8ea62dc26db2718952c4ddf6cdfc (patch)
tree225b15bbe5e71cad8cb95882a1b8cb592f82fce5
parent3cb272c97a23f6b28a60201614f38fd1a566de08 (diff)
downloadrockbox-3665eecf473b8ea62dc26db2718952c4ddf6cdfc.zip
rockbox-3665eecf473b8ea62dc26db2718952c4ddf6cdfc.tar.gz
rockbox-3665eecf473b8ea62dc26db2718952c4ddf6cdfc.tar.bz2
rockbox-3665eecf473b8ea62dc26db2718952c4ddf6cdfc.tar.xz
Increase set_time_screen() buffer size for hosted to keep the compiler happy.
The format strings in the snprintf can in theory need 60 characters This will not happen in practice (because seconds are 0..60 and not full-range integers etc.), but -D_FORTIFY_SOURCE will still warn about it, so we use 60 characters for HOSTED to make the compiler happy. Native builds still use 20, which is enough in practice. Change-Id: I22a2bab8134442e531a10bf883f3a369ade0fdc3
-rw-r--r--apps/screens.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/apps/screens.c b/apps/screens.c
index db83a98..9cb5ebe 100644
--- a/apps/screens.c
+++ b/apps/screens.c
@@ -374,7 +374,16 @@ bool set_time_screen(const char* title, struct tm *tm)
int button;
unsigned int i, realyear, min, max;
unsigned char *ptr[6];
+#if (CONFIG_PLATFORM & PLATFORM_HOSTED)
+ /* The format strings in the snprintf can in theory need 60 characters
+ This will not happen in practice (because seconds are 0..60 and not
+ full-range integers etc.), but -D_FORTIFY_SOURCE will still warn
+ about it, so we use 60 characters for HOSTED to make the compiler
+ happy. Native builds still use 20, which is enough in practice. */
+ unsigned char buffer[60];
+#else
unsigned char buffer[20];
+#endif
int *valptr = NULL;
static unsigned char daysinmonth[] =
{31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};