summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* Fix chinese-trad translationPurling Nayuki2014-01-16
| | | | | | Change-Id: Ifccb5c17d165d18e5076fb7ebc1af3cda3e2f778 Reviewed-on: http://gerrit.rockbox.org/726 Reviewed-by: Frank Gevaerts <frank@gevaerts.be>
* Fix red. Screw those last-minute changes :\Thomas Martitz2014-01-16
| | | | Change-Id: I12666e98114e490a13023af7149fc37147d4e864
* sansaclipzip: Correct simulator buttonmap for the different button layout.Thomas Martitz2014-01-16
| | | | Change-Id: I1b4cc257e8d85822177c377cc0fda14e8904fddb
* font: Fix crash due to uninitialized field.Thomas Martitz2014-01-16
| | | | Change-Id: If2fafb15a9998eebb2936e819507758e003abe30
* buflib: Add crc field protecting buflib cookie integrityMarcin Bukat2014-01-16
| | | | | | | | | | | | | | | This should catch the case of buffer misuse which results in corrupted cookie of next allocation. The check is performed on move_block() so it may be a bit late. There is buflib_check_valid() provided which checks the integrity of all cookies for given context. On DEBUG build with --sdl-thread this check is carried out for core_ctx on every context switch to catch problems earlier. Change-Id: I999d4576084592394e3dbd3bdf0f32935ff5f601 Reviewed-on: http://gerrit.rockbox.org/711 Reviewed-by: Thomas Martitz <kugel@rockbox.org>
* ipods: fix DEBUG buildsMarcin Bukat2014-01-16
| | | | | | | | | iap-core.h defines LOGF_ENABLE unconditionally but hexstring() helper function was not compiled if logf support was not selected in configure. The regular builds worked by accident because logf() lines where discarded by preprocessor. Change-Id: Id76af478e7c760d81168ebf9bf3eb973a679987c
* Fix Player warning.Thomas Martitz2014-01-16
| | | | Change-Id: I43989c92935710b36b68891a637db2e2cafb0401
* usb screen: Crop logo to the UI viewport dimensions.Thomas Martitz2014-01-16
| | | | | | | If the UI viewport is too small only the most top/left parts of the logo will be displayed. This goes one step further than bac85f2. Change-Id: I832b0e787e57e3b102a9c097cf1cccd7d4ad92d9
* usb screen: Push the usb screen onto the activity stack. This enables %cs ↵Thomas Martitz2014-01-16
| | | | | | tag support for it. Change-Id: Icecb72007aa3aba501c702e1aa65c801fcbc3857
* menus: Stop scrolling before entering the USB screen or remnants of the ↵Thomas Martitz2014-01-16
| | | | | | previous list could appear on it. Change-Id: I2753c239ef787e0a6af64c3d9c5bdeb26326a9d0
* usb: Do not disable themes in the USB screen.Thomas Martitz2014-01-15
| | | | | | | Fonts can now be assumed (by the code) to be available during USB. Make use of this fact in the USB screen and don't disable the skins. Change-Id: I525359aae16660604e8fe89addc0bdf97a3fafc1
* fonts: Do not unload completely on USB.Thomas Martitz2014-01-15
| | | | | | | | | The font engine can now perform cache lookups even if the font file is closed, if the font was disabled with the new font_disable_all() function. It is highly probable that the lookup succeeds but in the cache-miss case a blank, full-width glyph will be returned. Change-Id: I3c97e747d2a0ba30c7b495c6118c9f029d265b56
* tagtree: Use strnatcasecmp() for the database browser too.Thomas Martitz2014-01-15
| | | | | | | | | | | Even though you can insert leading zeros that makes ascii sort work for numbers, sometimes the leading zeros don't suffice. In order to always sort numerically strnatcasecmp() is needed. With the default tagnavi.config this affects albums with discnum > 9 or tracnums > 99. This FS#12888. Change-Id: Ie265c86eaf6dd07b6beda9e5eef25eb81eef8fd4
* Fix PlayerThomas Martitz2014-01-15
| | | | Change-Id: Ie489f91f78a9bdbded9b4ce09c74602dbca3934b
* Fix checkwps.Thomas Martitz2014-01-15
| | | | Change-Id: Ic10df965d55939b4d5ff5105f83a08a097877910
* coldfire: Use single app.lds script for all coldfires.Marcin Bukat2014-01-15
| | | | | | | | | | | The only true difference in this platform is the amount of iram between MCF5249 and MCF5250. Instead of duplicating the file simply use one with proper ifdefs. Change-Id: Ifd56ebd2666813633502e3b5d83669424659c039 Reviewed-on: http://gerrit.rockbox.org/713 Reviewed-by: Thomas Martitz <kugel@rockbox.org> Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
* skins: Update SBS when changing activities.Thomas Martitz2014-01-15
| | | | | | | | | | When changing activities (those that are indicated via %cs skin tag), the sbs needs to be updated, so that the UI viewport can be applied before that activity draws its UI. Fixes FS#12804. I hope this commit doesn't have bad side effects. Change-Id: If45654e356749f5f27991430dbd1da6f23e6f802
* radio: Fix crash with radioart after skipping some stationsThomas Martitz2014-01-15
| | | | Change-Id: I5dbf60598f9b0b7d56272b6736726c1e6bc2295c
* wpsbuild: Call gcc without having to create a temp file.Thomas Martitz2014-01-15
| | | | | | Change-Id: I7adc48209fd3050243770137df2022c617c68dc8 Reviewed-on: http://gerrit.rockbox.org/721 Reviewed-by: Thomas Martitz <kugel@rockbox.org>
* FMS: Load/update the skin at last, when fully initialzed, so that it can ↵Thomas Martitz2014-01-14
| | | | | | display the right content from the beginning. Change-Id: I15a708d34912c0749f2497baabf90d26deaaf5df
* HDD1630: enable headphones detection.Szymon Dziok2014-01-14
| | | | Change-Id: I329b12a8e90b4721b644ac326dfe75e52ce6c2b8
* HDD1630: implement lcd_enable (display on/off).Szymon Dziok2014-01-13
| | | | Change-Id: I8b72a9c333d8a9dbcb62c366a9af298f1dd9b2f7
* HDD1630: a proper way to enable and disable backlight.Szymon Dziok2014-01-13
| | | | Change-Id: Ic08a8a3ec4bcd6320ba07cb9bda1c95257ef14c9
* Make the m:robe 100 stable again.Szymon Dziok2014-01-13
| | | | Change-Id: If170b0b5f7035b02d59418c201d006805546e724
* Always check, if the USB logo for remotes overrides their physical size.Szymon Dziok2014-01-13
| | | | | | | | This fixes displaying of the main USB screen on m:robe 100. A remote for this particular target has no native remote USB logo and it uses a larger one. However it's a good idea to perform this check always IMHO. Change-Id: I56ceb2316c551269be011b60271d8da11cb8b073
* Fix text position in the cabbie (case without AA) and remove unnecessary ↵Szymon Dziok2014-01-13
| | | | | | scrolling. Change-Id: I3f065446dc1bb937d1af3d6d1bbdac02d26cae5c
* Don't try to set default_val in volume_limit_is_changed().Frank Gevaerts2014-01-13
| | | | | | | We don't use the default_val anywhere, so there's no need to try to use it in a buggy and null pointer dereferencing way here. Change-Id: Ie60dbab7647056e2bf457cb5dcc5b60012ea1651
* Implement volume limiter featurePurlingNayuki2014-01-13
| | | | | | | | | | | | | | Add a "volume limit" parameter to the configuration file. The maximum value of volume setting in sound menu will be limited to the same as volume limit. Also each time when setvol() is excuted, Rockbox will check if the global_settings.volume value larger than global_settings.volume_limit. If larger, take the value of volume_limit instead. The volume_limit argument shares the same maximum and minimum values with volume argument, while taking the maximum volume as its default value. Change-Id: I8ca9bc6ea6e617b48fc346aae5f2a0a1d259ae36 Reviewed-on: http://gerrit.rockbox.org/697 Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
* Improve wording.Thomas Martitz2014-01-13
| | | | Change-Id: I2e59fe8eb2d71968586fb035250978c90a619f76
* manual: Update bar tags for new noborder parameter and default value for y.Thomas Martitz2014-01-13
| | | | Change-Id: I4587ed5f073bd66d4efdf925b7beeca9a8b14a07
* skin_engine: Stricter checking for x, y, width, height for bar tags.Thomas Martitz2014-01-12
| | | | | | | Every theme that doesn't parse anymore now has broken values. I hope it's not too many of them. Change-Id: I6f52e55dc9197d0919f854240723a88f99c0b7da
* fuze+: Fix pitchscreen keymap.Thomas Martitz2014-01-12
| | | | | | | | | Like on other targets, left/right should change by 2% only temporarily. In timestretch mode fast speed change was not available. Fixes FS#12900. Change-Id: I8819c2ae7266bc09565b5ef13055985acf483f98
* scroll_engine: Fix FS#12894: Text scrolling stops working after a few ↵Thomas Martitz2014-01-12
| | | | | | | | | | | | | seconds/minutes Since commit 706b920 a timeout of TIMEOUT_BLOCK (-1) will cause queue_event_w_tmo() block indefinitely (previously it behaved as TIMEOUT_NOBLOCK). scroll_process_message() can be called with negative timeouts, with luck also -1. To fix this convert all negative timeouts to TIMEOUT_NOBLOCK explicitely. Change-Id: I1fc20d93acbba50d713c8364f635365930b38cbf
* put_line(): Add another check against possible buffer overflow (see 193911a).Thomas Martitz2014-01-12
| | | | Change-Id: Idc6637cc42afe612375dab3acac8495278f68f0a
* put_line(): Fix buffer overflow.Thomas Martitz2014-01-12
| | | | | | | | At the end of the format string it wrote a last byte (or inline string) past the end of the lcd boundaries, potentially overwriting unrelated memory. It now makes sure it won't exceed the viewport's width. Change-Id: Id4cfce918e8b070b7fc3c7d33f389f7a171963ff
* skin_engine: New param "noborder" for the bar tags.Thomas Martitz2014-01-12
| | | | | | | | | | By specifying this param the bar will not have a border/box. Instead the inner part that fills up is maximized on the bar area. Note that this only affects bars using foreground and background colors, not those constructed with images. Change-Id: Ib8dd49ecbaf9e16b96de840f5f365871b73d4fa4
* put_line(): Do not lock up if the scroll engine runs out of lines.Thomas Martitz2014-01-12
| | | | | | | | | | | Allocate MAX_LINES+1 because at the time get_line_desc() is called the scroll engine did not yet determine that it ran out of lines (because puts_scroll_func() wasn't called yet. Therefore we can run out of lines before setting the used field. By allocating one item more we can survive that point and set used to false if the scroll engine runs out of lines. Change-Id: I7a9af1bce256c6e07d254f096bd5865fa7cf2cee
* touchscreen/skin_engine: The touchregion handler didn't handle that vertical ↵Thomas Martitz2014-01-12
| | | | | | bars are bottom-up by default Change-Id: I4e7fc451c7ba318acb110c587bff4306c393e09f
* Fix remote warnings and charcell reds, and remove minor left-over tuff.Thomas Martitz2014-01-12
| | | | Change-Id: I10987ea9fcad94d502afd4ae4a80ab9022c75d2e
* put_line/scrolling: Make the scroll engine inform custom scrollers about ↵Thomas Martitz2014-01-12
| | | | | | | | | | | | | | | | | | | | | start/stop of scrolling. With the new lcd_putsxy_scroll_func() code can register custom scroll functions (put_line() makes use of that). In order for the custom scroller to be able to properly manage its userdata pointer (set via struct scrollinfo::userdata) the scroll engine must inform the scroller about start and stop of scrolling. To inform about start the lcd_scroll_* functions now return true when the line will scroll. To inform about stop the scroll engine calls into the scroller one last time, with the text set to NULL. put_line() can use this to release the userdata registered per scrolling line so that it can be recycled. This fixes that some scrolling lines became glitchy after some time because the userdata was recycled too early. Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9
* Don't use core_alloc_maximum() in usb_storage.Frank Gevaerts2014-01-11
| | | | | | | | usb_storage needs a fairly reasonable amount of memory. Allocating what we need and no more allows other (future) USB drivers to get something too, and is much cleaner in general. Change-Id: Iec9573c0f251f02400f92d92727cbf2969785de0
* scroll engine: Factor out renderer function so it can be called by lcd code.Thomas Martitz2014-01-11
| | | | | | | | | | | This is used by lcd_puts_scroll_worker() to render the line immediately instead of waiting for the next scroll tick when only the text was updated. Previously lcd_puts_scroll_worker() did not render anything in this case which could lead to visible blinking. This fixes blinking scrolling lines with dynamic text in the skin engine. Change-Id: I475bde8c8eb7c92f505e3c5ecf4d32bb90690536
* cuesheet: Fix another possible buffer overflow with long filenames.Thomas Martitz2014-01-11
| | | | Change-Id: I9d8fa8fcb0a872f688664c53881fde93f2de9436
* cuesheet: Fix possible buffer overflow with long filenames.Thomas Martitz2014-01-11
| | | | Change-Id: I49fe6da35057895d3c5a08a8723afe41eef7afe8
* cuesheet: Search for /path/to/music.mp3.cue as well if all fails.Konstantin Kudakov2014-01-11
| | | | Change-Id: If58ea7c7b94de54f6d9b014f069807bb88c6a147
* icons: When loading mono icons keep them in mono format.Thomas Martitz2014-01-11
| | | | | | This enables monochrome icons them to work with the invert line selector. Change-Id: Ic3e9219e93b4879166a10180e6067446a84a62bf
* bmp loader: Fix loading of monochrome/greyscale BMPs with newer headers.Thomas Martitz2014-01-11
| | | | | | | | | The code expected the color table at offset 54 (14+size of BITMAPINFOHEADER), which was after the BITMAPINFOHEADER header. However, newer BITMAPINFOHEADER versions exist which have more fields before the color table. Fix this by explicitely seeking to the color table. Change-Id: If1dfc77e7485e5a9e0bc0e7f577152da9358bd71
* Print `last logf lines on panic().Frank Gevaerts2014-01-11
| | | | | | | | | | | | If logf is enabled, panic() will print the last lines. On small screens this is more or less useless, but on large screens it can be very useful for debugging. Change-Id: I26dfc76e9ac4a2ddc2def8db1616a04f943dbba3 Reviewed-on: http://gerrit.rockbox.org/709 Reviewed-by: Thomas Martitz <kugel@rockbox.org> Reviewed-by: Frank Gevaerts <frank@gevaerts.be> Tested: Frank Gevaerts <frank@gevaerts.be>
* playlist_viewer: Reset icon callback after leaving the playlist viewer settings.Thomas Martitz2014-01-11
| | | | | | | This fixes that the playlist viewer still shows the icons after changing the playlist viewer specific show_icons value until re-opened. Change-Id: I42f287bcf02b27f0255dc157560c2e6575307eb6
* playlist_viewer: Resurrect playlist viewer settings submenu in the playlist ↵Thomas Martitz2014-01-11
| | | | | | | | | | | viewer context menu. This was lost in 97a4c1ef (svn r30177) for unkown reason but the manual still mentions this item, so I assume it was an accident. It doesn't hurt anyway. Fixes FS#12930. Change-Id: I2f5cd81913ec7bb911d1117e50c010a5c1b89b52