summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* Remove I/O priority. It is harmful when used with the new file code.Michael Sevakis2014-08-30
| | | | | | | | | | HAVE_IO_PRIORITY was defined for native targets with dircache. It is already effectively disabled for the most part since dircache no longer lowers its thread's I/O priority. It existed primarily for the aforementioned configuration. Change-Id: Ia04935305397ba14df34647c8ea29c2acaea92aa
* Fix last warning for WarbleMichael Sevakis2014-08-30
| | | | | | Unused result warnings will have to be dealt with separately. Change-Id: I00c45e28d4d43a5376745036e650ff8df576c2db
* Get the last errors I hope!Michael Sevakis2014-08-30
| | | | Change-Id: Ia285b95480cc9ac6494b745d80892c4b1b912341
* Hopefully fix most of the errors and warnings from the last pushMichael Sevakis2014-08-29
| | | | Change-Id: I1a466b2d55f120796910039a0296ca324c58e891
* Add normal alloca() definition and implement a strdupa and friendsMichael Sevakis2014-08-29
| | | | Change-Id: I21c9c21fd664fb11bc8496ace4a389f535a030d6
* Add mempcpy implementationMichael Sevakis2014-08-29
| | | | | | | | | | | | | | A GNU extension that returns dst + size instead of dst. It's a nice shortcut when copying strings with a known size or back-to-back blocks and you have to do it often. May of course be called directly or alternately through __builtin_mempcpy in some compiler versions. For ASM on native targets, it is implemented as an alternate entrypoint to memcpy which adds minimal code and overhead. Change-Id: I4cbb3483f6df3c1007247fe0a95fd7078737462b
* Rewrite filesystem code (WIP)Michael Sevakis2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch redoes the filesystem code from the FAT driver up to the clipboard code in onplay.c. Not every aspect of this is finished therefore it is still "WIP". I don't wish to do too much at once (haha!). What is left to do is get dircache back in the sim and find an implementation for the dircache indicies in the tagcache and playlist code or do something else that has the same benefit. Leaving these out for now does not make anything unusable. All the basics are done. Phone app code should probably get vetted (and app path handling just plain rewritten as environment expansions); the SDL app and Android run well. Main things addressed: 1) Thread safety: There is none right now in the trunk code. Most of what currently works is luck when multiple threads are involved or multiple descriptors to the same file are open. 2) POSIX compliance: Many of the functions behave nothing like their counterparts on a host system. This leads to inconsistent code or very different behavior from native to hosted. One huge offender was rename(). Going point by point would fill a book. 3) Actual running RAM usage: Many targets will use less RAM and less stack space (some more RAM because I upped the number of cache buffers for large memory). There's very little memory lying fallow in rarely-used areas (see 'Key core changes' below). Also, all targets may open the same number of directory streams whereas before those with less than 8MB RAM were limited to 8, not 12 implying those targets will save slightly less. 4) Performance: The test_disk plugin shows markedly improved performance, particularly in the area of (uncached) directory scanning, due partly to more optimal directory reading and to a better sector cache algorithm. Uncached times tend to be better while there is a bit of a slowdown in dircache due to it being a bit heavier of an implementation. It's not noticeable by a human as far as I can say. Key core changes: 1) Files and directories share core code and data structures. 2) The filesystem code knows which descriptors refer to same file. This ensures that changes from one stream are appropriately reflected in every open descriptor for that file (fileobj_mgr.c). 3) File and directory cache buffers are borrowed from the main sector cache. This means that when they are not in use by a file, they are not wasted, but used for the cache. Most of the time, only a few of them are needed. It also means that adding more file and directory handles is less expensive. All one must do in ensure a large enough cache to borrow from. 4) Relative path components are supported and the namespace is unified. It does not support full relative paths to an implied current directory; what is does support is use of "." and "..". Adding the former would not be very difficult. The namespace is unified in the sense that volumes may be specified several times along with relative parts, e.g.: "/<0>/foo/../../<1>/bar" :<=> "/<1>/bar". 5) Stack usage is down due to sharing of data, static allocation and less duplication of strings on the stack. This requires more serialization than I would like but since the number of threads is limited to a low number, the tradoff in favor of the stack seems reasonable. 6) Separates and heirarchicalizes (sic) the SIM and APP filesystem code. SIM path and volume handling is just like the target. Some aspects of the APP file code get more straightforward (e.g. no path hashing is needed). Dircache: Deserves its own section. Dircache is new but pays homage to the old. The old one was not compatible and so it, since it got redone, does all the stuff it always should have done such as: 1) It may be update and used at any time during the build process. No longer has one to wait for it to finish building to do basic file management (create, remove, rename, etc.). 2) It does not need to be either fully scanned or completely disabled; it can be incomplete (i.e. overfilled, missing paths), still be of benefit and be correct. 3) Handles mounting and dismounting of individual volumes which means a full rebuild is not needed just because you pop a new SD card in the slot. Now, because it reuses its freed entry data, may rebuild only that volume. 4) Much more fundamental to the file code. When it is built, it is the keeper of the master file list whether enabled or not ("disabled" is just a state of the cache). Its must always to ready to be started and bind all streams opened prior to being enabled. 5) Maintains any short filenames in OEM format which means that it does not need to be rebuilt when changing the default codepage. Miscellaneous Compatibility: 1) Update any other code that would otherwise not work such as the hotswap mounting code in various card drivers. 2) File management: Clipboard needed updating because of the behavioral changes. Still needs a little more work on some finer points. 3) Remove now-obsolete functionality such as the mutex's "no preempt" flag (which was only for the prior FAT driver). 4) struct dirinfo uses time_t rather than raw FAT directory entry time fields. I plan to follow up on genericizing everything there (i.e. no FAT attributes). 5) unicode.c needed some redoing so that the file code does not try try to load codepages during a scan, which is actually a problem with the current code. The default codepage, if any is required, is now kept in RAM separarately (bufalloced) from codepages specified to iso_decode() (which must not be bufalloced because the conversion may be done by playback threads). Brings with it some additional reusable core code: 1) Revised file functions: Reusable code that does things such as safe path concatenation and parsing without buffer limitations or data duplication. Variants that copy or alter the input path may be based off these. To do: 1) Put dircache functionality back in the sim. Treating it internally as a different kind of file system seems the best approach at this time. 2) Restore use of dircache indexes in the playlist and database or something effectively the same. Since the cache doesn't have to be complete in order to be used, not getting a hit on the cache doesn't unambiguously say if the path exists or not. Change-Id: Ia30f3082a136253e3a0eae0784e3091d138915c8 Reviewed-on: http://gerrit.rockbox.org/566 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
* Fix up the bootloadersMichael Sevakis2014-08-28
| | | | | | They can't access the raw RBVERSION define any longer. Change-Id: I698062b36306399945c01de54cdccaa1a1a8434e
* Prevent spurious recompiles on account of changed version.Michael Sevakis2014-08-28
| | | | | | | | | | | | | | After a local commit, any file that included version.h would have to be recompiled on account of the changed version string. This changes version.h in the build directory to rbversion.h and includes the preprocessor macro from rbversion.h in firmware/common/version.c so that only that one file needs to be recompiled after a local commit rather than a whole slew of them. Change-Id: I900d97e3a24a0610698283416d97b4fa3a3a2cf6 Reviewed-on: http://gerrit.rockbox.org/937 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
* Patch up rbendian.h for Win32 cross-compileMichael Sevakis2014-08-26
| | | | | | MingW doesn't provide that stuff. Change-Id: Ifa8310ed00f4f79f06adb71db71e58b70e7d2b60
* hwpatcher: add framework for CRC computationAmaury Pouly2014-08-26
| | | | | | Change-Id: Ib78f0fe58db5cec86f043d3e9e1ca14e69297ba0 Reviewed-on: http://gerrit.rockbox.org/911 Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
* Remove unused return value variable in lib/unwarminder/backtrace.cMichael Sevakis2014-08-25
| | | | | | Stop the Android warning about it Change-Id: I2f01220004f128befaa5757786b8de174566cbb5
* panicf doesn't return so why not tell GCC and $AVE :Michael Sevakis2014-08-25
| | | | Change-Id: I6096576f539bfb02b340b82fabc5019f6756b722
* Do a better endian.h setup that isn't as fragileMichael Sevakis2014-08-25
| | | | | | | | | | | | | | | | We redefine the top-level macros to our own in order to maintain compatibility with compound initializers by wrapping the mid or low level definitions from the OS header. This allows, hopefully optimized, macros from the host OS's headers to be used when building any hosted target obviating the need for NEED_GENERIC_BYTESWAPS unless the target simply doesn't define its own optimized versions (MIPS!). Throw in some 64-bit swaps for completeness' sake; they generate no code if not yet used anyway. Change-Id: I21b384b55fea46833d01ea3cad1ad8952ea01a11
* Fuze+: fixed brightness settings: previously there were 81 settings for only ↵Avi Eisenberg2014-08-25
| | | | | | | | 26 possible brightnesses, now there are 33 for 33 Change-Id: Idc6e3a635850f3ee54ec23246795af88af960ab0 Reviewed-on: http://gerrit.rockbox.org/916 Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
* Ukrainian language updateKyryljan_Serhij2014-08-24
| | | | | | Change-Id: Ie06a1a1ecded66d1efb3beeee1aa7b69656715ef Reviewed-on: http://gerrit.rockbox.org/921 Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
* One last missing !defined(SIMULATOR) for chip8Frank Gevaerts2014-08-23
| | | | Change-Id: Iab2d9150126f6c611604469d105186b936825012
* Hope this works...Franklin Wei2014-08-23
| | | | | | Change-Id: I8a94f0be82f63ed1e81433beb41ff2d60a1e6eef Reviewed-on: http://gerrit.rockbox.org/926 Reviewed-by: Frank Gevaerts <frank@gevaerts.be>
* Yellow go bye-byeFranklin Wei2014-08-22
| | | | | | Change-Id: I12ce8b7781b4b1ce1c47b2973057586177f90157 Reviewed-on: http://gerrit.rockbox.org/923 Reviewed-by: Frank Gevaerts <frank@gevaerts.be>
* Fixed a chip8 bugFranklin Wei2014-08-22
| | | | | | Change-Id: Ia28610713461eb02e8911be7fa0d5ad8ec8ba7fe Reviewed-on: http://gerrit.rockbox.org/919 Reviewed-by: Frank Gevaerts <frank@gevaerts.be>
* Make sure load_context is the last thing in switch_thread.Michael Sevakis2014-08-20
| | | | | | This should fix the android crash issue (fingers crossed). Change-Id: I9d3f773dbdf7dde60bd76962dcf66a3bad8b0925
* Added Clip/+ to 2048 targetsFranklin Wei2014-08-19
| | | | | | Change-Id: I9fb5a50f214e9dd87d1f1f62f4324876bdd94fe8 Reviewed-on: http://gerrit.rockbox.org/918 Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
* 2048: service pack 1 :)Franklin Wei2014-08-19
| | | | | | | | | - fixed some bugs - added 1-bit LCD support Change-Id: I7bb458d79d799dcd6b11d9d538773404f9a7f97c Reviewed-on: http://gerrit.rockbox.org/917 Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
* thread-unix patchup!Michael Sevakis2014-08-18
| | | | | | | | | | | | | | | The changed thread code may not wish to save the old context under certain circumstances but thread-unix.c assumed it would, cached it and used it unconditionally. Also, prevent it from leaking away all the jump buffers (old problem). Creating and removing threads would eventually run it out of buffers and then it would crash after that. Plugins, like Pictureflow, which have worker threads could only be started a few times. Implement a simple O(1) allocator that will reuse them and stays self-contained to its own types (as it appears the original author intended). Change-Id: Icf65413c086b346fb79bf827102b725269e2812c
* Always unboost at exitAvi Eisenberg2014-08-18
| | | | | | Change-Id: I8b4a2d61a5f4491265888d84c0f2c684bcf38edb Reviewed-on: http://gerrit.rockbox.org/915 Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
* Oops. Broke an egg. Restore wrongly removed code in mutex.c.Michael Sevakis2014-08-16
| | | | | | | Nice colorful diffs reveals some lines that should NOT have been removed when !defined(HAVE_PRIORITY_SCHEDULING) in mutex_unlock. Change-Id: I4152ea864b7706217c670e1b99250b09e69c5858
* Fix warnings from 6ed0087Michael Sevakis2014-08-16
| | | | | | | | | | | | | | Forgot to (void) an unused parameter when priorityless. usb-drv-rl27xx.c was using a compound init to initialize a semaphore but the structure changed so that it is no longer correct. Use designated initializers to avoid having to complete all fields. Forgot to break compatibility on all plugins and codecs since the kernel objects are now different. Take care of that too and do the sort thing. Change-Id: Ie2ab8da152d40be0c69dc573ced8d697d94b0674
* Base scheduler queues off linked lists and do cleanup/consolidationMichael Sevakis2014-08-16
| | | | | | | | | | | | | | | | | | | | | | | | | Abstracts threading from itself a bit, changes the way its queues are handled and does type hiding for that as well. Do alot here due to already required major brain surgery. Threads may now be on a run queue and a wait queue simultaneously so that the expired timer only has to wake the thread but not remove it from the wait queue which simplifies the implicit wake handling. List formats change for wait queues-- doubly-linked, not circular. Timeout queue is now singly-linked. The run queue is still circular as before. Adds a better thread slot allocator that may keep the slot marked as used regardless of the thread state. Assists in dumping special tasks that switch_thread was tasked to perform (blocking tasks). Deletes alot of code yet surprisingly, gets larger than expected. Well, I'm not not minding that for the time being-- omlettes and break a few eggs and all that. Change-Id: I0834d7bb16b2aecb2f63b58886eeda6ae4f29d59
* Add common linked list functionsMichael Sevakis2014-08-16
| | | | | | | | | Forms implemented to a greater or lesser degree at the moment: ll_* = singly-linked list lld_* = doubly-linked list lldc_* = doubly-linked circular list Change-Id: Ieed5af50fc59165c8b14c3513b3b5d0e6f7de9fa
* hwpatcher: fix horrible typo in the makefileAmaury Pouly2014-08-13
| | | | Change-Id: I6e8d8ae3a5f6e1111a6b7d910a1a6b94e2733ca6
* Added highscore highlight to xobox gameFranklin Wei2014-08-12
| | | | | | Change-Id: Idf6848fc80a56398889d5deeb16bf3707fcd3e30 Reviewed-on: http://gerrit.rockbox.org/893 Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
* Added 2048 gameFranklin Wei2014-08-12
| | | | | | | Change-Id: I4012dca4f93ca0db386a454635534f648ba906e9 Reviewed-on: http://gerrit.rockbox.org/888 Reviewed-by: Michael Giacomelli <giac2000@hotmail.com> Tested: Michael Giacomelli <giac2000@hotmail.com>
* Fix some more straggling stuffMichael Sevakis2014-08-08
| | | | | | | | | | | | | | * HWCODEC bootloaders * Remove references to thread structures outside the kernel. They are private and should not be used elsewhere. The mrobe-100 is an offender that gets squashed. * The ata.c hack stuff for large sector disks on iPod Video gets squashed for the same reason. I will no longer maintain it, period; please find the real reason for its difficulties. Change-Id: Iae1a675beac887754eb3cc59b560c941077523f5
* Bootloaders need the reacharound to get at the internal goodsMichael Sevakis2014-08-08
| | | | | | They need to include kernel-internal.h in order to perform inits. Change-Id: I5b0f155e4ff49a065c6cb97691ecd4396a199979
* Do some kernel cleanupMichael Sevakis2014-08-08
| | | | | | | | | | | | | | | | | | | | * Seal away private thread and kernel definitions and declarations into the internal headers in order to better hide internal structure. * Add a thread-common.c file that keeps shared functions together. List functions aren't messed with since that's about to be changed to different ones. * It is necessary to modify some ARM/PP stuff since GCC was complaining about constant pool distance and I would rather not force dump it. Just bl the cache calls in the startup and exit code and let it use veneers if it must. * Clean up redundant #includes in relevant areas and reorganize them. * Expunge useless and dangerous stuff like remove_thread(). Change-Id: I6e22932fad61a9fac30fd1363c071074ee7ab382
* rkwtool: The tool to inspect and extract update RKW filesMarcin Bukat2014-08-07
| | | | Change-Id: Ie32d0a597b93d23a7d5946a3d9409572b41b45bc
* Fix some stuff for no priority andMichael Sevakis2014-08-06
| | | | | | | | | | thread_queue_wake() doesn't need the 2nd parameter. The original purpose for it never came to be. Non priority version mrsw_writer_wakeup_readers was left improperly finished. Get that back into line. Change-Id: Ic613a2479f3cc14dc7c761517670eb15178da9f5
* One more shot; errno.h needs to be in the ARM one too :)Michael Sevakis2014-08-05
| | | | Change-Id: Icf5e5fb269c975eaaefc6e756f46d4530b982b1f
* Hosted builds using thread.c have errno as thread context.Michael Sevakis2014-08-05
| | | | | | | Never came up testing but I don't have those SDKs installed. Taking a jab at it. Change-Id: I4d0de1c666e0895d41b3de41dd9024626bd37601
* Fix up some more redMichael Sevakis2014-08-05
| | | | | | | find_first_set_bit() becomes a small inline on ARMv5+ and checkwps now gets made with -std=gnu99 (it eats all the GCCOPTS) like the rest of things. Change-Id: Ie6039b17fec057a3dcb0f453d8fd5efac984df89
* Oops. Somehow lost the track of the new files last push.Michael Sevakis2014-08-05
| | | | Change-Id: If3fad318bc2d620fa940de3f9595ff61024939df
* Add multi-reader, single-writer locks to kernel.Michael Sevakis2014-08-06
| | | | | | | | | | | | | | | | | | | | | | | | Any number of readers may be in the critical section at a time and writers are mutually exclusive to all other threads. They are a better choice when data is rarely modified but often read and multiple threads can safely access it for reading. Priority inheritance is fully implemented along with other changes to the kernel to fully support it on multiowner objects. This also cleans up priority code in the kernel and updates some associated structures in existing objects to the cleaner form. Currently doesn't add the mrsw_lock.[ch] files since they're not yet needed by anything but the supporting improvements are still useful. This includes a typed bitarray API (bitarray.h) which is pretty basic for now. Change-Id: Idbe43dcd9170358e06d48d00f1c69728ff45b0e3 Reviewed-on: http://gerrit.rockbox.org/801 Reviewed-by: Michael Sevakis <jethead71@rockbox.org> Tested: Michael Sevakis <jethead71@rockbox.org>
* Russian language updateKyryljan_Serhij2014-08-05
| | | | | | Change-Id: I78af1702c1f60c2fc66ebeb738aed187f13906f3 Reviewed-on: http://gerrit.rockbox.org/903 Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
* Make crosstool-ng build with gnu make 4.0Frank Gevaerts2014-07-30
| | | | Change-Id: Id3a5a310e6fa53e690c92f420994875cb1bfff43
* Support for remote on Samsung YH920/YH925.Szymon Dziok2014-07-28
| | | | | | | Remote buttons are bound to the standard buttons in button-target.h, but they can have a separate buttonmap, if someone wants. Change-Id: Id8c78a3dfec0005bf588dc16416870b4c7c56836
* Samsung YH-925: Don't add anything to adc value while reading it.Szymon Dziok2014-07-28
| | | | | | | OF doesn't do such thing. Values in mV are converted proportionally, so no change to the battery meter. Change-Id: Ic545b0514535e7f17f0379ed02f6bdf515f69ac6
* Samsung YH-920: Proper values for battery monitoring, based on the OF formula.Szymon Dziok2014-07-28
| | | | Change-Id: I894eb6bad600bd059fe9a5ea1103737a736d4005
* Slovak language updatePeter Lecký2014-07-27
| | | | | Change-Id: I3150dd77b3f5ce85d324ce3e9b6931c659dbde58 Signed-off-by: Bertrik Sikken <bertrik@sikken.nl>
* Samsung YH-820: enable battery monitoringSebastian Leonhardt2014-07-27
| | | | | | | | | | The "percent_to_volt_charge" values are quite arbitrary and may need some more tweaking. Change-Id: I9f177d46681030d615fe2c2e78cf9bd2dde026af Reviewed-on: http://gerrit.rockbox.org/824 Reviewed-by: Szymon Dziok <b0hoon@o2.pl> Tested: Szymon Dziok <b0hoon@o2.pl>
* SA9200: Implement clicker.Szymon Dziok2014-07-26
| | | | | | It's not integrated with key click option for now. Change-Id: Ib0769b02bfebe7c55eca7b7ea61df5d6dd83cdd3