| Commit message (Collapse) | Author | Age |
| |
|
|
| |
Change-Id: I47c2d857fbf9e53696e005b075d8a6f041738fe3
|
| |
|
|
|
|
|
|
|
| |
Some targets can only use storage DMA if the memory location is storage
aligned. The required alignment can be more strict than word alignment,
which was used previously. This change ensures that aligned transfers
in test_disk can use DMA.
Change-Id: I605b4d57f9e9c04920587017032f14449645693a
|
| |
|
|
|
|
|
|
|
|
| |
This changes JPEG fill and invalid byte handling to be like
mozjpeg, and bases entropy data start on SOS marker location.
Thanks to Stefan Waldmann and Dean Tersigni for reporting.
Change-Id: I3c79cc6ac8d714fdc75c12b57ba427d611c99519
Chaange-Id: Ibc7c17d38d5be63642bdaf6adfd6acc2a6cf4450
|
| |
|
|
|
|
| |
This fixes the "implicit declaration of function 'printf'" warning
Change-Id: I97d247bcab26ddba4d22e0fd19af45fdb47b8cce
|
| |
|
|
|
|
|
| |
I misunderstood the code a bit when I committed b58b9c2. The
read_char_no_whitespace() probably have to be done.
Change-Id: I024420149a04dbeed4d714795282bb7f88a8e1da
|
| |
|
|
|
|
|
|
|
| |
Note that the error checking is probably useful if done correctly,
but I have no way to test this, so just removing the offending code
is the only way forward. Thanks to the fairly creative bug, the code
did nothing at all anyway.
Change-Id: Ifeef57202f31e842ca1befa331f8b34e1c76757c
|
| |
|
|
|
|
|
| |
seems more logical to me, and is more consistent, since
"SAMSUNG_YH92X_PAD" is already used in the tex files.
Change-Id: Ie9a9d850ea86155a7dcf86c88a22a420a10a3837
|
| |
|
|
|
|
|
|
| |
Change 12x12 and 22x22 sized tiles to hand-optimized ones
with better readibility :)
Tile values >= 1024 are abbreviated to "1k", "2k" etc.
Change-Id: I15f4649b20442b71027a3b1564bc51c7e72105ce
|
| |
|
|
|
|
|
| |
Change source to match manual description:
use UP key to open virtual keyboard.
Change-Id: I5c6ffc356db42f305c918053c31a9595bf0dc3ac
|
| |
|
|
|
|
|
|
|
| |
This patch fixes some (mostly small) plugin issues with the "big"
YH-keymap patch (a507b). Only one fix affects the main keymaps
(virtual keyboard "DONE" now exits after long key /release/ instead
of long button /press/).
Change-Id: Id34f925ebfa97ae4974cd9405fbe1fee4f597833
|
| |
|
|
| |
Change-Id: I3fb322f28b23e4b7a27a71e66c50887d298de554
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main "innovation" in this patch are two "virtual buttons"
for the record switch on YH92x targets. When the switch state
changes, a single BUTTON_REC_SW_ON or .._OFF button event will
be generated. Thus keymap code can react on switching, but
not on the actual state of the switch.
Wherever sensible, the following user scheme is applied:
- use PLAY as confirm button
- use REW button or Long REW to exit
- use REC (YH820) or FFWD (YH92X) as modifier key for button combos
Change-Id: Ic8d1db9cc6869daed8dda98990dfdf7f6fd5d5a1
|
| |
|
|
|
|
| |
Let's give the defined, yet unused keymaps some sense :)
Change-Id: I372217351f7edc35c69c8c29fba782d32c895d5b
|
| |
|
|
|
|
| |
These fit by pure chance exactly the YH820 screen :)
Change-Id: I0f7a7f5d14aa0497da5ddf63cf1f95a2c4989460
|
| |
|
|
|
|
|
| |
* allow button combos for QUIT (fixes MPIO_HD300)
* allow quitting during PAUSE mode
Change-Id: Iaf8ffc65cdcfe6c1d25bfbad3e38764eea2664cc
|
| |
|
|
|
|
|
| |
KEYA is defined for Fuze+ (even in the manual),
but wasn't implemented yet.
Change-Id: Ib0a93544926c15893b1cce967db931f3b515422c
|
| |
|
|
|
|
|
|
|
|
| |
* improve manual (hopefully fixes fs#11988). Parts of the
description are taken from fs#10820.
* move ACTION_STD_CONTEXT from alternate select to alternate
menu action, as not all targets have ACTION_STD_MENU
* add menu entries for "Quit" and "Quit without saving"
Change-Id: Iec86a1608756a899f9f9d7ec7d479838dfd1d95f
|
| |
|
|
|
|
|
|
|
| |
- more whitespace to enhance readability
- better/fixed/more comments ;)
- some minor optimizations
- general code cleanup
Change-Id: I2b5f69aba0f83f989abb2c636920646e4315583f
|
| |
|
|
| |
Change-Id: I2feaee4225f04e3b93f8ccde555090437238ee0f
|
| |
|
|
|
|
|
|
| |
This tiny patch gives the player a bit time to
overlook the terrain and move the thumb to the
action button.
Change-Id: I63a4347c5bdafdd354f8c95b2bcdc64e046133a5
|
| |
|
|
| |
Change-Id: I1b814e8475798830d204b4838d98b8b671d93e02
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not needed as picture flow has it's own buffer.
This reverts commit 9076b433d18b5db1a1987fe99ca7c70808f22b0e.
Detailed explanation from Thomas Martiz (thanks!):
buflib buffers can be passed to yielding functions just fine. Problems
only arise if the are concurrent allocations, for example if two threads
allocate from the same context simultaneously or if the callee does it's
own allocations. This can't happen in the pictureflow case, it has it's
own context and a single thread allocating from it.
Therefore the problem isn't yield() itself, but possible concurrent
buflib_alloc() calls that result from the thread switch. This is because
compaction only ever happens on allocation (and not in a backgroud
thread or so).
|
| |
|
|
| |
Change-Id: I0f276a74010ef463ebdb0eb0cc00fc50123966f0
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- square sine tick and tock sounds (more annoying, more useful;-)
- optical indication of tics on display
- unification of mode of operation for SWCODEC and HWCODEC (tested on simulator)
Both playback and display drawing happen in main loop, always.
- operating in two modes now:
-- 1. classic dumb metronome
--- active when openened as application without file to open
--- the usual functionality with tapping and bpm change
--- controls indicated on display
-- 2. track mode with programmable series of parts
--- active when started as viewer for a .tempo file
--- differing meters (4/4, 3/4, 6/8, etc.)
--- patterns (tick/tock/silence on each beat)
--- smooth tempo changes in those tracks
This version had lots of testing regarding metronome accuracy,
resulting in the realization that PLL A and PLL B differ
on the Clip+, causing drift. There is still drift when the timer
intervall is too small, so I settled on 2 ms as compromise.
This is the final version, after adding documentation and extensive
help from Sebastian Leonhardt testing it on slower hardware (YH820),
where it works up to 650 actual bpm with display indication.
Latest change: Documentation nitpicks.
Change-Id: I764c8252526db188352385c5462f9453d882beb9
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reorganization
- Separated iBasso devices from PLATFORM_ANDROID. These are now standlone
hosted targets. Most device specific code is in the
firmware/target/hosted/ibasso directory.
- No dependency on Android SDK, only the Android NDK is needed.
32 bit Android NDK and Android API Level 16.
- Separate implementation for each device where feasible.
Code cleanup
- Rewrite of existing code, from simple reformat to complete reimplementation.
- New backlight interface, seperating backlight from touchscreen.
- Rewrite of device button handler, removing unneeded code and fixing memory
leaks.
- New Debug messages interface logging to Android adb logcat (DEBUGF, panicf,
logf).
- Rewrite of lcd device handler, removing unneeded code and fixing memory leaks.
- Rewrite of audiohw device handler/pcm interface, removing unneeded code and
fixing memory leaks, enabling 44.1/48kHz pthreaded playback.
- Rewrite of power and powermng, proper shutdown, using batterylog results
(see http://gerrit.rockbox.org/r/#/c/1047/).
- Rewrite of configure (Android NDK) and device specific config.
- Rewrite of the Android NDK specific Makefile.
Misc
- All plugins/games/demos activated.
- Update tinyalsa to latest from https://github.com/tinyalsa/tinyalsa.
Includes
- http://gerrit.rockbox.org/r/#/c/993/
- http://gerrit.rockbox.org/r/#/c/1010/
- http://gerrit.rockbox.org/r/#/c/1035/
Does not include http://gerrit.rockbox.org/r/#/c/1007/ due to new backlight
interface and new option for hold switch, touchscreen, physical button
interaction.
Rockbox needs the iBasso DX50/DX90 loader for startup, see
http://gerrit.rockbox.org/r/#/c/1099/
The loader expects Rockbox to be installed in /mnt/sdcard/.rockbox/. If
/mnt/sdcard/ is accessed as USB mass storage device, Rockbox will exit
gracefully and the loader will restart Rockbox on USB disconnect.
Tested on iBasso DX50.
Compiled (not tested) for iBasso DX90.
Compiled (not tested) for PLATFORM_ANDROID.
Change-Id: I5f5e22e68f5b4cf29c28e2b40b2c265f2beb7ab7
|
| |
|
|
| |
Change-Id: Ie01251af2cd843979b5fdefcfa541ba377d13bd7
|
| |
|
|
|
|
| |
_remote_backlight_* and _buttonlight_* are cleaned as well
Change-Id: I73653752831bbe170c26ba95d3bc04c2e3a5cf30
|
| |
|
|
| |
Change-Id: I30219d626316776eb73b4205d63376fa3dbc6361
|
| |
|
|
|
|
| |
XWorld grabs the audio buffer when it starts, so there can be no playback, making the playback control menu useless :P
Change-Id: Ia4e2c207f41619ef9b028917130d6dbf7dfba054
|
| |
|
|
|
|
|
|
|
|
| |
Either by mistake or because its meaning changed, usb_powered() doesn't mean
what the name suggest, so clarify its meaning by renaming it to usb_powered_only.
So use of usb_powered() are replaced by usb_inserted() when it makes more sense.
Change-Id: I112887e2d8560e84587bee5f55c826dde8c806d8
Reviewed-on: http://gerrit.rockbox.org/1097
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
If any of those functions should be (unused) API functions,
they can easily be turned back once really needed.
Detected using a new cppcheck check that
uses the internal symbol database to catch
functions that are only used in the current file.
Change-Id: Ic2b1e5b8020b76397f11cefc4e205f3b7ac1f184
|
| |
|
|
|
|
|
|
|
|
| |
If we don't provide a callback to buflib_alloc(),
the buffer is always movable (to reduce fragmentation).
Since we pass our buffer to functions that call yield(),
this could lead to memory corruption on buflib compaction.
Change-Id: Id1fad1822479d692551c55cb8bc87cea7b78f759
|
| |
|
|
|
|
|
|
|
| |
Happy New Year!
Change-Id: I228e4b9af9561eb70f75ebb57e333c78065873df
Reviewed-on: http://gerrit.rockbox.org/1093
Reviewed-by: Thomas Jarosch <tomj@simonv.com>
Tested: Thomas Jarosch <tomj@simonv.com>
|
| |
|
|
|
|
|
|
|
|
| |
- Comment keymaps.h
- Tie XWORLD_DEBUG into ROCKBOX_HAS_LOGF to ease debugging
- Fix up the manual a little bit
Change-Id: I12cfb58001199036cd67dbaa27f164e6790a199d
Reviewed-on: http://gerrit.rockbox.org/1084
Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
|
| |
|
|
|
|
| |
Change-Id: I6bf564cf009d935ebb1d7fb77ccb2eab8c87d2c7
Reviewed-on: http://gerrit.rockbox.org/1083
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
|
| |
|
|
|
|
|
|
| |
A temporary fix for keymaps.h, the logic needs rewritten
Change-Id: Ic8c81a5f01620ffc409cf6220b2916c0ec428dbe
Reviewed-on: http://gerrit.rockbox.org/1082
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
|
| |
|
|
|
|
|
|
| |
ondavx747. Also fixes errors for ondavx777.
Change-Id: I1a5daa844759316df4dec7b869425ea9a174814b
Reviewed-on: http://gerrit.rockbox.org/1081
Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
|
| |
|
|
|
|
| |
Change-Id: I62d7702d2e6541777f5553e27e166470004cd06d
Reviewed-on: http://gerrit.rockbox.org/1080
Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
|
| |
|
|
|
|
|
|
| |
also fix a couple unused vars
Change-Id: Ib05d2e22dd7477bc9bd193232bd3de8a0816beb2
Reviewed-on: http://gerrit.rockbox.org/1079
Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
|
| |
|
|
| |
Change-Id: Ic565444bf1df955703dfe91adaf3094e8ab9b990
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Co-conspirators: Franklin Wei, Benjamin Brown
--------------------------------------------------------------------
This work is based on:
- Fabien Sanglard's "Fabother World" based on
- Piotr Padkowski's newRaw interpreter which was based on
- Gregory Montoir's reverse engineering of
- Eric Chahi's assembly code
--------------------------------------------------------------------
Progress:
* The plugin runs pretty nicely (with sound!) on most color targets
* Keymaps for color LCD targets are complete
* The manual entry is finished
* Grayscale/monochrome support is NOT PLANNED
- the game looks horrible in grayscale! :p
--------------------------------------------------------------------
Notes:
* The original game strings were built-in to the executable, and
were copyrighted and could not be used.
* This port ships with an alternate set of strings by default, but
can load the "official" strings from a file at runtime.
--------------------------------------------------------------------
To be done (in descending order of importance):
* vertical stride compatibility <30% done>
* optimization <10% done>
Change-Id: I3155b0d97c2ac470cb8a2040f40d4139ddcebfa5
Reviewed-on: http://gerrit.rockbox.org/1077
Reviewed-by: Michael Giacomelli <giac2000@hotmail.com>
|
| |
|
|
|
|
|
|
| |
Stick to the safer version of those two.
Tested mikmod still works with some nice Necros .s3m files.
Change-Id: I6774cdf3345a4c89b2f9cf3bb8d832963ca30c38
|
| |
|
|
|
|
|
|
|
|
| |
No harm done, same values are assigned
in the "default" case.
cppcheck reported:
[rockbox/apps/plugins/zxbox/tapefile.c:674] -> [rockbox/apps/plugins/zxbox/tapefile.c:681]: (warning) Buffer 'seg_desc' is being written before its old content has been used. 'break;' missing?
Change-Id: I2bf044db9022c848c304f1ad88c012bd85ee61df
|
| |
|
|
|
|
|
| |
cppcheck reported:
[rockbox/apps/plugins/wavrecord.c:3672]: (error) Array 'sampr[9][2]' index sampr[9][1] out of bounds.
Change-Id: Ib1e9c25842aa275b15d8d817018cc523269b1f42
|
| |
|
|
|
|
|
|
|
|
|
| |
We should be safe since STM_Load() should
never be called if STM_Test() fails.
Still it's better safe than sorry.
cppcheck reported:
[rockbox/apps/plugins/mikmod/load_stm.c:302]: (error) Array 'STM_Version[3]' accessed at index 3, which is out of bounds.
Change-Id: I914935fd108c492d013de24d17dcb9c227af6cd8
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test code:
--------------
int main(void)
{
static unsigned short extra_spaces[] = { 0, 0x3000 };
return sizeof(extra_spaces);
}
--------------
-> returns four instead of two.
cppcheck reported:
[rockbox/apps/plugins/text_viewer/tv_text_processor.c:180]: (error) Array 'break_chars[27]' acces
sed at index 53, which is out of bounds.
[rockbox/apps/plugins/text_viewer/tv_text_processor.c:195]: (error) Array 'extra_spaces[2]' acces
sed at index 3, which is out of bounds.
Change-Id: I66c305cc5c99e59e7c8e0aa9c86cecbe293ff037
|
| |
|
|
|
|
| |
Keymap for the YH820 fits much better for the YH920 anyway.
Change-Id: I54d7f3be9dfaf689e76c73d39da4649395e912a1
|
| |
|
|
|
|
| |
594b6e2 (FS#10251).
Change-Id: I652545c812a8bd4d5d1be5f200fce9c97733b636
|
| |
|
|
| |
Change-Id: Ib598737327043809f60127f7c538f2d45ddabb87
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following updates were made to disktidy:
- Fixed bug FS#12825. disktidy now checks subdirectories again for files to delete.
- Use iterative rather than recursive method to traverse file system.
- Once disktidy finishes a run it now returns to it's main menu rather than exiting.
- Added "Last Run Stats" view to disktidy. This shows how many files and directories
were deleted in the last run as well as the total size of those files, the length of
time the run took and when the run took place (for players with RTC).
- Added "Playback Control" option to disktidy main menu.
Change-Id: I9b7d6d5d08aef2b5f85fb63fcd2ec60f1c1ec2e0
Reviewed-on: http://gerrit.rockbox.org/808
Reviewed-by: Franklin Wei <frankhwei536@gmail.com>
Tested: Franklin Wei <frankhwei536@gmail.com>
Reviewed-by: Marcin Bukat <marcin.bukat@gmail.com>
|