From 276ff3bceb6bb365029b870d994a928c0c314e72 Mon Sep 17 00:00:00 2001
From: Steve Bavin <pondlife@pondlife.me>
Date: Fri, 6 Jul 2007 22:34:18 +0000
Subject: Copy current track path as a string, not a slightly-oversized block.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13808 a1c6a512-1295-4272-9138-f99709370657
---
 apps/gui/gwps-common.c | 5 ++++-
 apps/gui/gwps.c        | 3 ++-
 apps/gui/gwps.h        | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/apps/gui/gwps-common.c b/apps/gui/gwps-common.c
index fe7e1ed..4032d8b 100644
--- a/apps/gui/gwps-common.c
+++ b/apps/gui/gwps-common.c
@@ -398,8 +398,11 @@ bool update(struct gui_wps *gwps)
         }
 
         if (gwps->state->id3)
-            memcpy(gwps->state->current_track_path, gwps->state->id3->path,
+        {
+            strncpy(gwps->state->current_track_path, gwps->state->id3->path,
                    sizeof(gwps->state->current_track_path));
+            gwps->state->current_track_path[sizeof(gwps->state->current_track_path)-1] = '\0';
+        }
     }
 
     if (gwps->state->id3)
diff --git a/apps/gui/gwps.c b/apps/gui/gwps.c
index c0fe24f..d726dae 100644
--- a/apps/gui/gwps.c
+++ b/apps/gui/gwps.c
@@ -728,8 +728,9 @@ void wps_state_update_id3_nid3(struct mp3entry *id3, struct mp3entry *nid3)
 
 static void wps_state_update_ctp(const char *path)
 {
-    memcpy(wps_state.current_track_path, path,
+    strncpy(wps_state.current_track_path, path,
            sizeof(wps_state.current_track_path));
+    wps_state.current_track_path[sizeof(wps_state.current_track_path)-1] = '\0';
 }
 /* wps_state end*/
 
diff --git a/apps/gui/gwps.h b/apps/gui/gwps.h
index ab82581..cfa7e70 100644
--- a/apps/gui/gwps.h
+++ b/apps/gui/gwps.h
@@ -378,7 +378,7 @@ struct wps_state
     bool wps_time_countup;
     struct mp3entry* id3;
     struct mp3entry* nid3;
-    char current_track_path[MAX_PATH+1];
+    char current_track_path[MAX_PATH];
 };
 
 
-- 
cgit v1.1