From 83ce56846a65ce14b2410d07da8fcc4790e0b6f7 Mon Sep 17 00:00:00 2001 From: Brandon Low Date: Sat, 22 Apr 2006 21:31:07 +0000 Subject: Remove an unneeded define, add a todo git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9765 a1c6a512-1295-4272-9138-f99709370657 --- apps/codecs/mpa.c | 3 +-- apps/playback.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/codecs/mpa.c b/apps/codecs/mpa.c index bbfbb57..fa5dab6 100644 --- a/apps/codecs/mpa.c +++ b/apps/codecs/mpa.c @@ -34,8 +34,6 @@ struct mad_synth synth IBSS_ATTR; void abort(void) { } -/* These extra 8 bytes fake-added to each read make mad decode the last frame */ -#define MAD_BUFFER_GUARD 8 #define INPUT_CHUNK_SIZE 8192 mad_fixed_t mad_frame_overlap[2][32][18] IBSS_ATTR; @@ -183,6 +181,7 @@ enum codec_status codec_start(struct codec_api *api) inputbuffer = ci->request_buffer(&size, INPUT_CHUNK_SIZE); if (size == 0 || inputbuffer == NULL) break; + /* size + MAD_BUFFER_GUARD to help mad decode the last frame */ mad_stream_buffer(&stream, (unsigned char *)inputbuffer, size + MAD_BUFFER_GUARD); } diff --git a/apps/playback.c b/apps/playback.c index 0bc0fb3..33d0d7a 100644 --- a/apps/playback.c +++ b/apps/playback.c @@ -20,6 +20,7 @@ /* TODO: Fast codecs seem to cause badness on track skipping (stop, old audio, * then new audio). Investigate the CFL_FLUSH mode used for all track skips */ /* TODO: Check for a possibly broken codepath on a rapid skip, stop event */ +/* TODO: same in reverse ^^ */ /* TODO: Can use the track changed callback to detect end of track and seek * in the previous track until this happens */ /* Design: we have prev_ti already, have a conditional for what type of seek -- cgit v1.1