diff options
| author | Simon Tatham <anakin@pobox.com> | 2023-05-03 12:57:27 +0100 |
|---|---|---|
| committer | Simon Tatham <anakin@pobox.com> | 2023-05-03 13:01:43 +0100 |
| commit | 63346a8ceac9ac1061e59af2a99ab1a44c851392 (patch) | |
| tree | 51c4f45e840e983ac0df08435f6e1f0b4adad911 /PuzzleApplet.java | |
| parent | 89e9026ee49fd5469ad989e629effd2e4f6ade2a (diff) | |
| download | puzzles-63346a8ceac9ac1061e59af2a99ab1a44c851392.zip puzzles-63346a8ceac9ac1061e59af2a99ab1a44c851392.tar.gz puzzles-63346a8ceac9ac1061e59af2a99ab1a44c851392.tar.bz2 puzzles-63346a8ceac9ac1061e59af2a99ab1a44c851392.tar.xz | |
Windows: reorganise menu ids.
A user pointed out today that IDM_PREFS overlaps the second preset,
because I forgot that IDM_PRESETS was not a single id but the base for
an open-ended series.
Looking more closely, there are several other problems with the IDM_*
constants. IDM_GAMES (used in COMBINED mode) shouldn't be at an
arbitrary distance _above_ IDM_PRESETS, because that risks a
collision; instead, the games' and presets' ids should interleave.
Also, the ids above IDM_GAMES were going up in steps of 1, which
should have been 0x10, for the usual reason that the bottom four bits
of the id aren't guaranteed. And IDM_KEYEMUL was completely unused (I
suspect it was part of the discarded WinCE support).
Now the #defines that are the bases of series are labelled as
IDM_FOO_BASE; they interleave as they should; and there's a clear
comment.
Diffstat (limited to 'PuzzleApplet.java')
0 files changed, 0 insertions, 0 deletions