aboutsummaryrefslogtreecommitdiff
path: root/grid.c
diff options
context:
space:
mode:
authorSimon Tatham <anakin@pobox.com>2015-04-10 07:55:16 +0100
committerSimon Tatham <anakin@pobox.com>2015-04-10 07:58:26 +0100
commit7f64f4a50e46304b7bad011a1251e146ab63ca15 (patch)
tree23e91a703c0c5bb2883a710a93d76830877ec56a /grid.c
parent10460d1bc7dab94e84c5fbbde221c3d20f9e263b (diff)
downloadpuzzles-7f64f4a50e46304b7bad011a1251e146ab63ca15.zip
puzzles-7f64f4a50e46304b7bad011a1251e146ab63ca15.tar.gz
puzzles-7f64f4a50e46304b7bad011a1251e146ab63ca15.tar.bz2
puzzles-7f64f4a50e46304b7bad011a1251e146ab63ca15.tar.xz
Sort out abs/fabs confusion.
My Mac has just upgraded itself to include a version of clang which warns if you use abs() on a floating-point value, or fabs() on an integer. Fixed the two occurrences that came up in this build (and which were actual build failures, because of -Werror), one in each direction. I think both were benign. The potentially dangerous one was using abs in place of fabs in grid_find_incentre(), because that could actually lose precision, but I think that function had plenty of precision to spare (grid point separation being of the order of tens of pixels) so nothing should have gone seriously wrong with the old code.
Diffstat (limited to 'grid.c')
-rw-r--r--grid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/grid.c b/grid.c
index bae29f4..6a90c99 100644
--- a/grid.c
+++ b/grid.c
@@ -1069,7 +1069,7 @@ void grid_find_incentre(grid_face *f)
eq[2] = eqs[0][3]*eqs[1][2] - eqs[1][3]*eqs[0][2];
/* Parametrise x and y in terms of some t. */
- if (abs(eq[0]) < abs(eq[1])) {
+ if (fabs(eq[0]) < fabs(eq[1])) {
/* Parameter is x. */
xt[0] = 1; xt[1] = 0;
yt[0] = -eq[0]/eq[1]; yt[1] = eq[2]/eq[1];