diff options
| author | Ben Harris <bjh21@bjh21.me.uk> | 2023-02-01 21:28:35 +0000 |
|---|---|---|
| committer | Ben Harris <bjh21@bjh21.me.uk> | 2023-02-01 21:28:35 +0000 |
| commit | 875f0af21fbced5cbf6cf63b86fe3dc51682c863 (patch) | |
| tree | 514d4e689413c994ab6eef6cb75f7372c8d38087 /html | |
| parent | 2a9be2b89df3e6a07a1d90a06f8ac00a92d789e5 (diff) | |
| download | puzzles-875f0af21fbced5cbf6cf63b86fe3dc51682c863.zip puzzles-875f0af21fbced5cbf6cf63b86fe3dc51682c863.tar.gz puzzles-875f0af21fbced5cbf6cf63b86fe3dc51682c863.tar.bz2 puzzles-875f0af21fbced5cbf6cf63b86fe3dc51682c863.tar.xz | |
Avoid invalid moves when solving Tracks
The solver, when it decided that an edge or square should be both TRACK
and NOTRACK, would correctly decide that the puzzle was insoluble, but
would also mark the edge with both flags in its working copy. This
could then lead to assertion violations if that working copy of the
board was used for something else, for instance if it was fed back into
the solver. This couldn't happen in normal play, since failed solutions
just cause the solve command to fail, but the diagnostic "H" command
could trigger it from a save file, causing an assertion failure:
"state->sflags[y*state->p.w + x] & S_CLUE".
Now when the solver runs into this situation, it marks the puzzle as
insoluble but doesn't set the invalid flag, so the board remains valid
and future solve operations are safe.
This save file is the one that demonstrated the problem:
SAVEFILE:41:Simon Tatham's Portable Puzzle Collection
GAME :12:Train Tracks
PARAMS :5:6x6t0
CPARAMS :5:6x6t0
DESC :31:b0t9l,,S0,00,0,0,4,0,0,S0,0,0,0
NSTATES :1:8
STATEPOS:1:2
MOVE :1:H
MOVE :1:H
MOVE :1:H
MOVE :1:H
MOVE :1:H
MOVE :1:H
MOVE :1:H
Diffstat (limited to 'html')
0 files changed, 0 insertions, 0 deletions