aboutsummaryrefslogtreecommitdiff
path: root/penrose.c
diff options
context:
space:
mode:
authorBen Harris <bjh21@bjh21.me.uk>2023-02-16 21:21:15 +0000
committerBen Harris <bjh21@bjh21.me.uk>2023-02-18 00:13:15 +0000
commit0186d78da9e83103eb80b3814d4de8031f29232f (patch)
tree26774b7be7540d980a1ee5cba5d83445a528bd5b /penrose.c
parenta7e738aceb36e4a70d41cf09a74b2d7a3af6cbe0 (diff)
downloadpuzzles-0186d78da9e83103eb80b3814d4de8031f29232f.zip
puzzles-0186d78da9e83103eb80b3814d4de8031f29232f.tar.gz
puzzles-0186d78da9e83103eb80b3814d4de8031f29232f.tar.bz2
puzzles-0186d78da9e83103eb80b3814d4de8031f29232f.tar.xz
Mark many more function (and some objects) static
I noticed commit db3b531e2cab765a00475054d2e9046c9d0437d3 in the history where Simon added a bunch of "static" qualifiers. That suggested that consistently marking internal functions "static" is desirable, so I tried a build using GCC's -Wmissing-declarations, which requires prior declaration (presumed to be in a header file) of all global functions. This commit makes the GTK build clean under GCC's -Wmissing-declarations. I've also adding "static" to a few obviously internal objects, but GCC doesn't complain about those so I certainly haven't got them all.
Diffstat (limited to 'penrose.c')
-rw-r--r--penrose.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/penrose.c b/penrose.c
index 4015ef7..b056ae5 100644
--- a/penrose.c
+++ b/penrose.c
@@ -512,7 +512,7 @@ void penrose_calculate_size(int which, int tilesize, int w, int h,
int show_recursion = 0;
int ntiles, nfinal;
-int test_cb(penrose_state *state, vector *vs, int n, int depth)
+static int test_cb(penrose_state *state, vector *vs, int n, int depth)
{
int i, xoff = 0, yoff = 0;
double l = penrose_side_length(state->start_size, depth);
@@ -542,7 +542,7 @@ int test_cb(penrose_state *state, vector *vs, int n, int depth)
return 0;
}
-void usage_exit(void)
+static void usage_exit(void)
{
fprintf(stderr, "Usage: penrose-test [--recursion] P2|P3 SIZE DEPTH\n");
exit(1);