diff options
| author | Ben Harris <bjh21@bjh21.me.uk> | 2023-02-18 18:52:21 +0000 |
|---|---|---|
| committer | Ben Harris <bjh21@bjh21.me.uk> | 2023-02-19 12:41:13 +0000 |
| commit | e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6 (patch) | |
| tree | 325d20828f8389a2c5f287f56b5e8082b4d0c2a3 /puzzles.h | |
| parent | 26c7f3aa285a45176c940afebe3885ad2be2ed65 (diff) | |
| download | puzzles-e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6.zip puzzles-e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6.tar.gz puzzles-e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6.tar.bz2 puzzles-e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6.tar.xz | |
Convert a lot of floating-point constants to single precision
For reasons now lost to history, Puzzles generally uses single-precision
floating point. However, C floating-point constants are by default
double-precision, and if they're then operated on along with a
single-precision variable the value of the variable gets promoted to
double precision, then the operation gets done, and then often the
result gets converted back to single precision again.
This is obviously silly, so I've used Clang's "-Wdouble-promotion" to
find instances of this and mark the constants as single-precision as
well. This is a bit awkward for PI, which ends up with a cast. Maybe
there should be a PIF, or maybe PI should just be single-precision.
This doesn't eliminate all warnings from -Wdouble-promotion. Some of
the others might merit fixing but adding explicit casts to double just
to shut the compiler up would be going too far, I feel.
Diffstat (limited to 'puzzles.h')
0 files changed, 0 insertions, 0 deletions