summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Holmgren <magnushol@gmail.com>2007-07-24 20:40:10 +0000
committerMagnus Holmgren <magnushol@gmail.com>2007-07-24 20:40:10 +0000
commit277ee087038fdf7b6bb296a99f52f5c3490c60a9 (patch)
tree5b0fdecd2d420874d85187f0f8b46845cc7f4804
parent22bc7de528c0129a02049af9e21df0f198a29c6d (diff)
downloadrockbox-277ee087038fdf7b6bb296a99f52f5c3490c60a9.zip
rockbox-277ee087038fdf7b6bb296a99f52f5c3490c60a9.tar.gz
rockbox-277ee087038fdf7b6bb296a99f52f5c3490c60a9.tar.bz2
rockbox-277ee087038fdf7b6bb296a99f52f5c3490c60a9.tar.xz
MP4: Fix a sign error preventing some files from playing (e.g., if tagged by MusicBrainz).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13973 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/metadata/mp4.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/metadata/mp4.c b/apps/metadata/mp4.c
index d4e9bb6..13f323f5 100644
--- a/apps/metadata/mp4.c
+++ b/apps/metadata/mp4.c
@@ -426,7 +426,7 @@ static bool read_mp4_tags(int fd, struct mp3entry* id3,
if (sub_size > sizeof(tag_name) - 1)
{
read(fd, tag_name, sizeof(tag_name) - 1);
- lseek(fd, sub_size - sizeof(tag_name) - 1, SEEK_CUR);
+ lseek(fd, sub_size - (sizeof(tag_name) - 1), SEEK_CUR);
tag_name[sizeof(tag_name) - 1] = 0;
}
else
@@ -672,8 +672,8 @@ bool get_mp4_metadata(int fd, struct mp3entry* id3)
else
{
logf("MP4 metadata error");
- DEBUGF("MP4 metadata error. errno %d, length %ld, frequency %ld, filesize %ld\n",
- errno, id3->length, id3->frequency, id3->filesize);
+ DEBUGF("MP4 metadata error. errno %d, frequency %ld, filesize %ld\n",
+ errno, id3->frequency, id3->filesize);
return false;
}