summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Jarosch <tomj@simonv.com>2015-01-13 21:57:24 +0100
committerThomas Jarosch <tomj@simonv.com>2015-01-13 21:57:24 +0100
commit2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8 (patch)
tree8f19d94810148cb1a775dca8c07a1997023bd5fb
parent1212edd352e924111bb3db6330755b33f13fbe71 (diff)
downloadrockbox-2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8.zip
rockbox-2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8.tar.gz
rockbox-2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8.tar.bz2
rockbox-2ee2a9697a1cea6ca3b9fa328440b8f46aa84fd8.tar.xz
Fix crash on uninitialized variable
The WRITE() macro checks if the "fw" pointer is open upon fwrite() error. Since fw was not initialized before use, it might crash for non-zero fw. cppcheck reported. [utils/jz4740_tools/HXFreplace.c:187]: (error) Uninitialized variable: fw Change-Id: I558170f9f17828c9fd515a5da36ad8b5cb30a9ad
-rw-r--r--utils/jz4740_tools/HXFreplace.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/jz4740_tools/HXFreplace.c b/utils/jz4740_tools/HXFreplace.c
index bcfff82..5a05525 100644
--- a/utils/jz4740_tools/HXFreplace.c
+++ b/utils/jz4740_tools/HXFreplace.c
@@ -107,7 +107,7 @@ static int checksum(FILE *file)
int main(int argc, char *argv[])
{
- FILE *infile, *outfile, *fw;
+ FILE *infile, *outfile, *fw = NULL;
fprintf(stderr, "HXFreplace v" VERSION " - (C) 2008 Maurus Cuelenaere\n");
fprintf(stderr, "This is free software; see the source for copying conditions. There is NO\n");