summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Holmgren <magnushol@gmail.com>2010-11-14 13:13:06 +0000
committerMagnus Holmgren <magnushol@gmail.com>2010-11-14 13:13:06 +0000
commit4480e3a82cc12bddde528331f0838f4f232a148c (patch)
tree6e2b7d65ee2be4655f534715fb278bcf42c87bce
parent91beb7a46d45005f284b7662563664ef5c193e2f (diff)
downloadrockbox-4480e3a82cc12bddde528331f0838f4f232a148c.zip
rockbox-4480e3a82cc12bddde528331f0838f4f232a148c.tar.gz
rockbox-4480e3a82cc12bddde528331f0838f4f232a148c.tar.bz2
rockbox-4480e3a82cc12bddde528331f0838f4f232a148c.tar.xz
Hopefully fix FS#11696: scrollwheel doesn't respond in some cases.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28584 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/action.c7
-rw-r--r--firmware/drivers/button.c6
2 files changed, 9 insertions, 4 deletions
diff --git a/apps/action.c b/apps/action.c
index d61930a..003f11f 100644
--- a/apps/action.c
+++ b/apps/action.c
@@ -205,7 +205,12 @@ static int get_action_worker(int context, int timeout,
pcmbuf_beep(4000, KEYCLICK_DURATION, 2500*global_settings.keyclick);
#endif
- if ((context != last_context) && ((last_button & BUTTON_REL) == 0))
+ if ((context != last_context) && ((last_button & BUTTON_REL) == 0)
+#ifdef HAVE_SCROLLWHEEL
+ /* Scrollwheel doesn't generate release events */
+ && !(last_button & (BUTTON_SCROLL_BACK | BUTTON_SCROLL_FWD))
+#endif
+ )
{
if (button & BUTTON_REL)
{
diff --git a/firmware/drivers/button.c b/firmware/drivers/button.c
index 12a1ad0..403b521 100644
--- a/firmware/drivers/button.c
+++ b/firmware/drivers/button.c
@@ -115,13 +115,13 @@ static bool button_try_post(int button, int data)
/* one can swipe over the scren very quickly,
* for this to work we want to forget about old presses and
* only respect the very latest ones */
- const int force_post = true;
+ const bool force_post = true;
#else
/* Only post events if the queue is empty,
* to avoid afterscroll effects.
* i.e. don't post new buttons if previous ones haven't been
- * processed yet */
- const int force_post = false;
+ * processed yet - but always post releases */
+ const bool force_post = button & BUTTON_REL;
#endif
bool ret = queue_empty(&button_queue);