summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonathan Gordon <rockbox@jdgordon.info>2012-08-14 12:12:15 +1000
committerJonathan Gordon <rockbox@jdgordon.info>2012-08-14 12:12:15 +1000
commit70eb3e6a563758a80ec894c009ca51bd79945043 (patch)
tree88f291ce485f961cb7705dfa597ec62e74884a21
parentbd6e6ed40385c5d5f357a39909ae6a5db60f7ce9 (diff)
downloadrockbox-70eb3e6a563758a80ec894c009ca51bd79945043.zip
rockbox-70eb3e6a563758a80ec894c009ca51bd79945043.tar.gz
rockbox-70eb3e6a563758a80ec894c009ca51bd79945043.tar.bz2
rockbox-70eb3e6a563758a80ec894c009ca51bd79945043.tar.xz
Revert "fix erroneous button read in yesno screen and missed buttons in action.c."
This reverts commit 15775c8badac65ad9d7477a1706c019703c15b47.
-rw-r--r--apps/action.c6
-rw-r--r--apps/gui/yesno.c7
2 files changed, 2 insertions, 11 deletions
diff --git a/apps/action.c b/apps/action.c
index 3c130e3..5ebcbf7 100644
--- a/apps/action.c
+++ b/apps/action.c
@@ -232,13 +232,7 @@ static int get_action_worker(int context, int timeout,
/* Data from sys events can be pulled with button_get_data
* multimedia button presses don't go through the action system */
if (button == BUTTON_NONE || button & (SYS_EVENT|BUTTON_MULTIMEDIA))
- {
- /* no button pressed so no point in waiting for release */
- if (button == BUTTON_NONE)
- wait_for_release = false;
return button;
- }
-
/* the special redraw button should result in a screen refresh */
if (button == BUTTON_REDRAW)
return ACTION_REDRAW;
diff --git a/apps/gui/yesno.c b/apps/gui/yesno.c
index dc04651..a2abae3 100644
--- a/apps/gui/yesno.c
+++ b/apps/gui/yesno.c
@@ -169,10 +169,9 @@ enum yesno_res gui_syncyesno_run(const struct text_message * main_message,
screens[i].stop_scroll();
gui_yesno_draw(&(yn[i]));
}
-
/* make sure to eat any extranous keypresses */
- action_wait_for_release();
-
+ while (get_action(CONTEXT_STD+99, TIMEOUT_NOBLOCK))
+ action_wait_for_release();
while (result==-1)
{
/* Repeat the question every 5secs (more or less) */
@@ -206,7 +205,6 @@ enum yesno_res gui_syncyesno_run(const struct text_message * main_message,
result=YESNO_YES;
break;
case ACTION_NONE:
- case ACTION_UNKNOWN:
case SYS_CHARGER_DISCONNECTED:
case SYS_BATTERY_UPDATE:
/* ignore some SYS events that can happen */
@@ -235,7 +233,6 @@ enum yesno_res gui_syncyesno_run(const struct text_message * main_message,
screens[i].scroll_stop(yn[i].vp);
viewportmanager_theme_undo(i, true);
}
-
return(result);
}