summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Sevakis <jethead71@rockbox.org>2013-08-16 09:28:36 -0400
committerMichael Sevakis <jethead71@rockbox.org>2013-08-16 09:28:36 -0400
commitb1209d47899ea1906d2638bdaacb99b76f101e3f (patch)
tree643ec5db6bb178adc1110ff942a293feab5d0ab2
parentb662e3a2dcaf144471e0558681f4b78dac013f30 (diff)
downloadrockbox-b1209d47899ea1906d2638bdaacb99b76f101e3f.zip
rockbox-b1209d47899ea1906d2638bdaacb99b76f101e3f.tar.gz
rockbox-b1209d47899ea1906d2638bdaacb99b76f101e3f.tar.bz2
rockbox-b1209d47899ea1906d2638bdaacb99b76f101e3f.tar.xz
Fix FS#12889 : Audible pop right after setting Repeat/Shuffle
The quickscreen calls settings_apply() and the crossfeed code wasn't checking that the right crossfeed was set before updating the filter for the custom setting, which was overwriting the Meier crossfeed data (custom and Meier share the same data space). Change-Id: Ifaa2f46fe062d4497681a2dd0d5068ec906c96a3
-rw-r--r--lib/rbcodec/dsp/crossfeed.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/rbcodec/dsp/crossfeed.c b/lib/rbcodec/dsp/crossfeed.c
index fc40c6b..0428f58 100644
--- a/lib/rbcodec/dsp/crossfeed.c
+++ b/lib/rbcodec/dsp/crossfeed.c
@@ -164,6 +164,9 @@ void dsp_set_crossfeed_cross_params(long lf_gain, long hf_gain, long cutoff)
crossfeed_hf_gain = hf_gain;
crossfeed_cutoff = cutoff;
+ if (crossfeed_type != CROSSFEED_TYPE_CUSTOM)
+ return;
+
struct dsp_config *dsp = dsp_get_config(CODEC_IDX_AUDIO);
crossfeed_custom_update_filter(&crossfeed_state,
dsp_get_output_frequency(dsp));