diff options
| author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2012-02-06 22:35:08 +0100 |
|---|---|---|
| committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2012-02-06 22:35:08 +0100 |
| commit | f1eedb80a2efbf60cfc25182b72e3da07e0f1250 (patch) | |
| tree | 99f7e24e93d2e77b5553988adacddbde1e60bbf8 | |
| parent | 779c2f3eb1cdc5636c4f9252f5cf0fbe3a672462 (diff) | |
| download | rockbox-f1eedb80a2efbf60cfc25182b72e3da07e0f1250.zip rockbox-f1eedb80a2efbf60cfc25182b72e3da07e0f1250.tar.gz rockbox-f1eedb80a2efbf60cfc25182b72e3da07e0f1250.tar.bz2 rockbox-f1eedb80a2efbf60cfc25182b72e3da07e0f1250.tar.xz | |
Don't try to save settings if none available.
Fixes a crash when leaving the encoder settings dialog with the Ok button but
the dynamically loaded library missing, in which case no settings will be
available.
Change-Id: I889a0bbcde6bed2df658b5df57341edf6802daad
| -rw-r--r-- | rbutil/rbutilqt/base/encoderlame.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/rbutil/rbutilqt/base/encoderlame.cpp b/rbutil/rbutilqt/base/encoderlame.cpp index 7528948..8950d41 100644 --- a/rbutil/rbutilqt/base/encoderlame.cpp +++ b/rbutil/rbutilqt/base/encoderlame.cpp @@ -82,11 +82,12 @@ void EncoderLame::generateSettings() void EncoderLame::saveSettings() { - // no user settings right now. - RbSettings::setSubValue("lame", RbSettings::EncoderVolume, - getSetting(VOLUME)->current().toDouble()); - RbSettings::setSubValue("lame", RbSettings::EncoderQuality, - getSetting(QUALITY)->current().toDouble()); + if(m_symbolsResolved) { + RbSettings::setSubValue("lame", RbSettings::EncoderVolume, + getSetting(VOLUME)->current().toDouble()); + RbSettings::setSubValue("lame", RbSettings::EncoderQuality, + getSetting(QUALITY)->current().toDouble()); + } } bool EncoderLame::start() |