Re-enable the currently unused and broken dithering and noise shaping code already in Rockbox, and make it a user option instead of a codec-controlled option. The majority of people probably will not even hear any difference with this enabled, but feedback is welcome. Save your settings!

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11368 a1c6a512-1295-4272-9138-f99709370657

13 files changed, 0 insertions, 13 deletions

diff --git a/apps/codecs/a52.c b/apps/codecs/a52.c
index 0c69c6a..3d0c35d 100644
--- a/apps/codecs/a52.c
+++ b/apps/codecs/a52.c
@@ -141,7 +141,6 @@ enum codec_status codec_start(struct codec_api *api)
     ci->memset(iedata, 0, iend - iedata);
     #endif
 
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_STEREO_MODE, (long *)STEREO_NONINTERLEAVED);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (long *)28);
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (long *)(1024*128));
diff --git a/apps/codecs/aac.c b/apps/codecs/aac.c
index 0c48422..56c2a79 100644
--- a/apps/codecs/aac.c
+++ b/apps/codecs/aac.c
@@ -73,7 +73,6 @@ enum codec_status codec_start(struct codec_api* api)
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*16));
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
 
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_STEREO_MODE, (int *)STEREO_NONINTERLEAVED);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(29));
 
diff --git a/apps/codecs/adx.c b/apps/codecs/adx.c
index 99c5f4b..902f3ce 100644
--- a/apps/codecs/adx.c
+++ b/apps/codecs/adx.c
@@ -62,7 +62,6 @@ enum codec_status codec_start(struct codec_api *api)
     /* we only render 16 bits */
     ci->configure(DSP_SET_SAMPLE_DEPTH, (long *)16);
     /*ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*256));*/
-    ci->configure(DSP_DITHER, (bool *)false);
   
 next_track:
     DEBUGF("ADX: next_track\n");
diff --git a/apps/codecs/aiff.c b/apps/codecs/aiff.c
index 1e7adca..8e5a392 100644
--- a/apps/codecs/aiff.c
+++ b/apps/codecs/aiff.c
@@ -83,7 +83,6 @@ enum codec_status codec_start(struct codec_api *api)
 
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*256));
-    ci->configure(DSP_DITHER, (bool *)false);
   
 next_track:
     if (codec_init(api)) {
diff --git a/apps/codecs/alac.c b/apps/codecs/alac.c
index 890dcdb..06c8154 100644
--- a/apps/codecs/alac.c
+++ b/apps/codecs/alac.c
@@ -64,7 +64,6 @@ enum codec_status codec_start(struct codec_api* api)
   ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
   ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*128));
 
-  ci->configure(DSP_DITHER, (bool *)false);
   ci->configure(DSP_SET_STEREO_MODE, (int *)STEREO_NONINTERLEAVED);
   ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(ALAC_OUTPUT_DEPTH-1));
 
diff --git a/apps/codecs/flac.c b/apps/codecs/flac.c
index 880fd69..ce54e67 100644
--- a/apps/codecs/flac.c
+++ b/apps/codecs/flac.c
@@ -264,7 +264,6 @@ enum codec_status codec_start(struct codec_api* api)
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*128));
 
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_STEREO_MODE, (long *)STEREO_NONINTERLEAVED);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(FLAC_OUTPUT_DEPTH-1));
 
diff --git a/apps/codecs/mpa.c b/apps/codecs/mpa.c
index 81604de..ff6090e 100644
--- a/apps/codecs/mpa.c
+++ b/apps/codecs/mpa.c
@@ -95,7 +95,6 @@ enum codec_status codec_start(struct codec_api *api)
 
     /* Create a decoder instance */
 
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(MAD_F_FRACBITS));
     ci->configure(DSP_SET_CLIP_MIN, (int *)-MAD_F_ONE);
     ci->configure(DSP_SET_CLIP_MAX, (int *)(MAD_F_ONE - 1));
diff --git a/apps/codecs/mpc.c b/apps/codecs/mpc.c
index 563b313..f9622f8 100644
--- a/apps/codecs/mpc.c
+++ b/apps/codecs/mpc.c
@@ -90,7 +90,6 @@ enum codec_status codec_start(struct codec_api *api)
     ci->memset(iedata, 0, iend - iedata);
     #endif
     
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (long *)(28));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (long *)(1024*16));
     ci->configure(CODEC_SET_FILEBUF_PRESEEK, (long *)(0));
diff --git a/apps/codecs/shorten.c b/apps/codecs/shorten.c
index 8d62a12..c571df8 100644
--- a/apps/codecs/shorten.c
+++ b/apps/codecs/shorten.c
@@ -63,7 +63,6 @@ enum codec_status codec_start(struct codec_api* api)
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*128));
 
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_STEREO_MODE, (long *)STEREO_NONINTERLEAVED);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(SHN_OUTPUT_DEPTH-1));
     
diff --git a/apps/codecs/sid.c b/apps/codecs/sid.c
index bdffb87..c95e44b 100644
--- a/apps/codecs/sid.c
+++ b/apps/codecs/sid.c
@@ -1239,7 +1239,6 @@ enum codec_status codec_start(struct codec_api *api)
 
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*256));
-    ci->configure(DSP_DITHER, (bool *)false);
 
 next_track:
     if (codec_init(api)) {
diff --git a/apps/codecs/vorbis.c b/apps/codecs/vorbis.c
index 1900364..0475572 100644
--- a/apps/codecs/vorbis.c
+++ b/apps/codecs/vorbis.c
@@ -129,7 +129,6 @@ enum codec_status codec_start(struct codec_api *api)
     rb->memset(iedata, 0, iend - iedata);
     #endif
 
-    rb->configure(DSP_DITHER, (bool *)false);
     rb->configure(DSP_SET_SAMPLE_DEPTH, (long *)24);
     rb->configure(DSP_SET_CLIP_MAX, (long *)((1 << 24) - 1));
     rb->configure(DSP_SET_CLIP_MIN, (long *)-((1 << 24) - 1));
diff --git a/apps/codecs/wav.c b/apps/codecs/wav.c
index 3c86e3f..ba99b94 100644
--- a/apps/codecs/wav.c
+++ b/apps/codecs/wav.c
@@ -246,7 +246,6 @@ enum codec_status codec_start(struct codec_api *api)
     ci->configure(DSP_SET_SAMPLE_DEPTH, (long *)28);
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*256));
-    ci->configure(DSP_DITHER, (bool *)false);
   
 next_track:
     if (codec_init(api)) {
diff --git a/apps/codecs/wavpack.c b/apps/codecs/wavpack.c
index 1871b46..de815e6 100644
--- a/apps/codecs/wavpack.c
+++ b/apps/codecs/wavpack.c
@@ -62,7 +62,6 @@ enum codec_status codec_start(struct codec_api* api)
     ci->configure(CODEC_SET_FILEBUF_WATERMARK, (int *)(1024*512));
     ci->configure(CODEC_SET_FILEBUF_CHUNKSIZE, (int *)(1024*128));
   
-    ci->configure(DSP_DITHER, (bool *)false);
     ci->configure(DSP_SET_SAMPLE_DEPTH, (int *)(28));
 
     next_track: