summaryrefslogtreecommitdiff
path: root/apps/debug_menu.c
diff options
context:
space:
mode:
authorJens Arnold <amiconn@rockbox.org>2005-10-08 20:09:07 +0000
committerJens Arnold <amiconn@rockbox.org>2005-10-08 20:09:07 +0000
commit1f39f2e7486ef6448103d5ac1d020cad59e9fd95 (patch)
treed69eb7b3d4ada51941f5068991914077191647a7 /apps/debug_menu.c
parentb76e8c09fa4f273738fb5f56d75a9dd1344ec51b (diff)
downloadrockbox-1f39f2e7486ef6448103d5ac1d020cad59e9fd95.zip
rockbox-1f39f2e7486ef6448103d5ac1d020cad59e9fd95.tar.gz
rockbox-1f39f2e7486ef6448103d5ac1d020cad59e9fd95.tar.bz2
rockbox-1f39f2e7486ef6448103d5ac1d020cad59e9fd95.tar.xz
Ported the memory guard debug feature to coldfire, using the breakpoint logic. There are 3 shortcomings compared to SH1: (1) While the setting itself survives RoLo, it cannot be read back because the debug module programming model is write only. (2) system_reboot() from a 'Debug' exception doesn't work because the CPU enters emulation mode, and the only way leaving this mode is via an rte instruction. (3) (fixable) Catching write accesses to the flash doesn't actually do anything because the flash memory area is set write protected in CSMR2, so a write attempt stalls the bus. * Cosmetic changes in system.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7600 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/debug_menu.c')
-rw-r--r--apps/debug_menu.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/apps/debug_menu.c b/apps/debug_menu.c
index 0d34b23..acee5d3 100644
--- a/apps/debug_menu.c
+++ b/apps/debug_menu.c
@@ -1696,7 +1696,7 @@ bool dbg_screendump(void)
}
#endif
-#if CONFIG_CPU == SH7034
+#if CONFIG_CPU == SH7034 || defined(CPU_COLDFIRE)
bool dbg_set_memory_guard(void)
{
static const struct opt_items names[MAXMEMGUARD] = {
@@ -1711,7 +1711,7 @@ bool dbg_set_memory_guard(void)
return false;
}
-#endif /* CONFIG_CPU == SH7034 */
+#endif /* CONFIG_CPU == SH7034 || defined(CPU_COLDFIRE) */
bool debug_menu(void)
{
@@ -1732,9 +1732,9 @@ bool debug_menu(void)
{ "PCM recording", pcm_rec_screen },
{ "S/PDIF analyzer", dbg_spdif },
#endif
-#if CONFIG_CPU == SH7034
+#if CONFIG_CPU == SH7034 || defined(CPU_COLDFIRE)
{ "Catch mem accesses", dbg_set_memory_guard },
-#endif /* CONFIG_CPU == SH7034 */
+#endif
{ "View OS stacks", dbg_os },
#ifdef HAVE_LCD_BITMAP
{ "View battery", view_battery },