diff options
| author | Bertrik Sikken <bertrik@sikken.nl> | 2008-04-20 10:24:15 +0000 |
|---|---|---|
| committer | Bertrik Sikken <bertrik@sikken.nl> | 2008-04-20 10:24:15 +0000 |
| commit | db2d61f4eab4adc099abeaafa5e6f97d75f92824 (patch) | |
| tree | 5446b007aafb5d26a622a9d40e5be3e5ecebafa4 /apps | |
| parent | 8924686224eef5672bb3087e0ed358b745d603d1 (diff) | |
| download | rockbox-db2d61f4eab4adc099abeaafa5e6f97d75f92824.zip rockbox-db2d61f4eab4adc099abeaafa5e6f97d75f92824.tar.gz rockbox-db2d61f4eab4adc099abeaafa5e6f97d75f92824.tar.bz2 rockbox-db2d61f4eab4adc099abeaafa5e6f97d75f92824.tar.xz | |
Killed unnecessary global variables by making them static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/enc_config.c | 2 | ||||
| -rw-r--r-- | apps/gui/bitmap/list.c | 5 | ||||
| -rw-r--r-- | apps/recorder/peakmeter.c | 4 | ||||
| -rw-r--r-- | apps/recorder/peakmeter.h | 3 |
4 files changed, 5 insertions, 9 deletions
diff --git a/apps/enc_config.c b/apps/enc_config.c index 3412e96..9d64536 100644 --- a/apps/enc_config.c +++ b/apps/enc_config.c @@ -46,7 +46,7 @@ static int enc_menuitem_enteritem(int action, static void enc_rec_settings_changed(struct encoder_config *cfg); /* this is used by all encoder menu items, MUST be initialised before the call to do_menu() */ -struct menucallback_data { +static struct menucallback_data { struct encoder_config *cfg; bool global; } menu_callback_data; diff --git a/apps/gui/bitmap/list.c b/apps/gui/bitmap/list.c index 869acc5..107f7f4 100644 --- a/apps/gui/bitmap/list.c +++ b/apps/gui/bitmap/list.c @@ -44,9 +44,8 @@ #define SCROLLBAR_WIDTH 6 #define ICON_PADDING 1 -/* globals */ -struct viewport title_text[NB_SCREENS], title_icons[NB_SCREENS], - list_text[NB_SCREENS], list_icons[NB_SCREENS]; +static struct viewport title_text[NB_SCREENS], title_icons[NB_SCREENS], + list_text[NB_SCREENS], list_icons[NB_SCREENS]; /* should probably be moved somewhere else */ int list_title_height(struct gui_synclist *list, struct viewport *vp) diff --git a/apps/recorder/peakmeter.c b/apps/recorder/peakmeter.c index fb2e465..3e85fd5 100644 --- a/apps/recorder/peakmeter.c +++ b/apps/recorder/peakmeter.c @@ -82,8 +82,8 @@ bool peak_meter_enabled = true; /** Parameters **/ /* Range */ -unsigned short peak_meter_range_min; /* minimum of range in samples */ -unsigned short peak_meter_range_max; /* maximum of range in samples */ +static unsigned short peak_meter_range_min; /* minimum of range in samples */ +static unsigned short peak_meter_range_max; /* maximum of range in samples */ static unsigned short pm_range; /* range width in samples */ static bool pm_use_dbfs = true; /* true if peakmeter displays dBfs */ static bool level_check; /* true if peeked at peakmeter before drawing */ diff --git a/apps/recorder/peakmeter.h b/apps/recorder/peakmeter.h index 9b8b24a..9aa3290 100644 --- a/apps/recorder/peakmeter.h +++ b/apps/recorder/peakmeter.h @@ -76,9 +76,6 @@ extern void peak_meter_set_trigger_listener(void (*listener)(int status)); extern void peak_meter_draw_trig(int x[], int y[], int trig_width[], int nb_screens); -extern unsigned short peak_meter_range_min; -extern unsigned short peak_meter_range_max; - #define DB_SCALE_SRC_VALUES_SIZE 12 struct meter_scales{ /* buffered peak values */ |